Ftp::connect() - Code Metrics - ticaje/Agnostic-Connector - Measure and Improve Code Quality continuously with Scrutinizer

Ftp::connect() A
last analyzed 2021-06-19 09:06 UTC

↳ Parent: Ftp

Complexity

Conditions	3
Paths	4

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	6
c	1
b	0
f	0
dl	0
loc	9
rs	10
cc	3
nc	4
nop	1

<?php
declare(strict_types=1);

/**
 * Gateway Client Class
 * @category    Ticaje
 * @author      Max Demian <[email protected]>
 */

namespace Ticaje\AConnector\Gateway\Client;

use Ticaje\AConnector\Interfaces\CredentialInterface;
use Ticaje\AConnector\Interfaces\Protocol\FtpClientInterface;

/**
 * Class Ftp
 * @package Ticaje\AConnector\Gateway\Client
 */
class Ftp extends Base implements FtpClientInterface
{
    private $connected;

    /**
     * @inheritDoc
     */
    public function isConnected(): bool
    {
        return $this->connected;
    }

    /**
     * @inheritDoc
     */
    public function connect(CredentialInterface $credentials)
    {
        try {
            $this->client = $this->clientFactory->create($credentials->getAll());
            $this->connected = $this->client->login($credentials->username, $credentials->password) ? true : false;

        } catch (\Exception $exception) {
            $this->connected = false;
        }
        return $this->connected;
    }

    /**
     * @inheritDoc
     */
    public function get($path = '')
    {
        return $this->client->get($path);
    }

    /**
     * @inheritDoc
     */
    public function ls($dir = '.'): array
    {
        return $this->client->nlist($dir);
    }

    /**
     * @inheritDoc
     */
    public function download($path = '', $destination = false)
    {
        return $this->client->get($path, $destination);
    }
}


1			<?php
2			declare(strict_types=1);
3
4			/**
5			* Gateway Client Class
6			* @category Ticaje
7			* @author Max Demian <[email protected]>
8			*/
9
10			namespace Ticaje\AConnector\Gateway\Client;
11
12			use Ticaje\AConnector\Interfaces\CredentialInterface;
13			use Ticaje\AConnector\Interfaces\Protocol\FtpClientInterface;
14
15			/**
16			* Class Ftp
17			* @package Ticaje\AConnector\Gateway\Client
18			*/
19			class Ftp extends Base implements FtpClientInterface
20			{
21			private $connected;
22
23			/**
24			* @inheritDoc
25			*/
26			public function isConnected(): bool
27			{
28			return $this->connected;
29			}
30
31			/**
32			* @inheritDoc
33			*/
34			public function connect(CredentialInterface $credentials)
35			{
36			try {
37			$this->client = $this->clientFactory->create($credentials->getAll());
38			$this->connected = $this->client->login($credentials->username, $credentials->password) ? true : false;
			0 ignored issues – show Bug introduced 2020-04-15 18:22 UTC by Report Bug Copy Issue Report Accessing `password` on the interface `Ticaje\AConnector\Interfaces\CredentialInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history... Bug introduced 2020-04-15 18:22 UTC by Report Bug Copy Issue Report Accessing `username` on the interface `Ticaje\AConnector\Interfaces\CredentialInterface` suggest that you code against a concrete implementation. How about adding an `instanceof` check? Loading history...
39			} catch (\Exception $exception) {
40			$this->connected = false;
41			}
42			return $this->connected;
43			}
44
45			/**
46			* @inheritDoc
47			*/
48			public function get($path = '')
49			{
50			return $this->client->get($path);
51			}
52
53			/**
54			* @inheritDoc
55			*/
56			public function ls($dir = '.'): array
57			{
58			return $this->client->nlist($dir);
59			}
60
61			/**
62			* @inheritDoc
63			*/
64			public function download($path = '', $destination = false)
65			{
66			return $this->client->get($path, $destination);
67			}
68			}
69

ticaje / Agnostic-Connector

Ftp::connect() A last analyzed 2021-06-19 09:06 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Ftp::connect() A
last analyzed 2021-06-19 09:06 UTC