Issues in Authorized.php (master) - Issues in master - tianye/WechatOpenPlatform - Measure and Improve Code Quality continuously with Scrutinizer

Issues (65)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Authorized.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace OpenOauth;

use OpenOauth\Core\Core;
use OpenOauth\Core\Http\Http;

class Authorized extends Core
{
    const GET_API_QUERY_AUTH           = 'https://api.weixin.qq.com/cgi-bin/component/api_query_auth'; //使用授权码换取公众号的接口调用凭据和授权信息
    const GET_API_AUTHORIZER_TOKEN_URL = 'https://api.weixin.qq.com/cgi-bin/component/api_authorizer_token'; //获取（刷新）授权公众号的接口调用凭据（令牌）

    /**
     * @param $redirect_path
     */
    public function getAuthHTML($redirect_path)
    {
        $component_app_id = $this->configs->component_app_id;
        $pre_auth_code    = $this->getComponentPreAuthCode();
        $redirect_uri     = $this->current() . $redirect_path;

        $editorSrc = <<<HTML
         <script language="JavaScript" type="text/javascript">
           window.location.href="https://mp.weixin.qq.com/cgi-bin/componentloginpage?component_appid=$component_app_id&pre_auth_code=$pre_auth_code&redirect_uri=$redirect_uri";
    </script>
HTML;
        exit($editorSrc);

    }

    public function current()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $protocol = (!empty($_SERVER['HTTPS'])
            && $_SERVER['HTTPS'] !== 'off'
            || $_SERVER['SERVER_PORT'] === 443) ? 'https://' : 'http://';

        if (isset($_SERVER['HTTP_X_FORWARDED_HOST'])) {
            $host = $_SERVER['HTTP_X_FORWARDED_HOST'];
        } else {
            $host = $_SERVER['HTTP_HOST'];
        }

        return $protocol . $host . '/';
    }

    /**
     * 使用授权码换取公众号的接口调用凭据和授权信息
     *
     * @param string $authorizer_app_id
     *
     * @return array|bool|null|string|void
     */
    public function getApiQueryAuth($authorizer_app_id = '')
    {
        $time = time();

        $authorization_info_key = 'authorized:' . $this->configs->component_app_id . ':' . $authorizer_app_id;
        $query_auth_key         = 'query_auth:' . $this->configs->component_app_id . ':' . $authorizer_app_id;

        $query_auth_info = parent::$databaseDriver->_get($query_auth_key);
        //如果存在数据
        if (!empty($query_auth_info)) {

            //没超时 返回数据
            if ($query_auth_info['expired_time'] >= ($time + 1000) && $query_auth_info['authorization_state'] == 'authorized') {
                return $query_auth_info;
            } else {
                //如果超时了 获取新的 access_token 和 新的 刷新令牌 refresh_token
                $api_authorizer_token = $this->getApiAuthorizerToken($query_auth_info['authorization_info']['authorizer_appid'], $query_auth_info['authorization_info']['authorizer_refresh_token']);
                if (!empty($api_authorizer_token)) {
                    $query_auth_info['authorization_info']['authorizer_access_token']  = $api_authorizer_token['authorizer_access_token'];
                    $query_auth_info['authorization_info']['authorizer_refresh_token'] = $api_authorizer_token['authorizer_refresh_token'];
                    $query_auth_info['authorization_info']['expires_in']               = $api_authorizer_token['expires_in'];
                    $query_auth_info['expired_time']                                   = $time + $api_authorizer_token['expires_in'];
                    $query_auth_info['authorization_state']                            = 'authorized';

                    parent::$databaseDriver->_set($query_auth_key, $query_auth_info);

                    return $query_auth_info;
                }
            }
        }

        $authorization_info = parent::$databaseDriver->_get($authorization_info_key);

        $query_data = http_build_query(['component_access_token' => $this->getComponentAccessToken()]);

        if ($authorization_info['AuthorizationCodeExpiredTime'] <= $time) {
            $this->setError('授权Code超时');

            return false;
        }
        $request_data = [
            'component_appid'    => $authorization_info['AppId'],
            'authorization_code' => $authorization_info['AuthorizationCode'],
        ];

        $response_data = Http::_post(self::GET_API_QUERY_AUTH . '?' . $query_data, $request_data);

        if (!$response_data) {

            $this->setError(Http::$error);

            return false;
        }

        $response_data['authorization_state'] = 'authorized';
        $response_data['expired_time']        = $time + $response_data['authorization_info']['expires_in'];
        parent::$databaseDriver->_set($query_auth_key, $response_data);

        return $response_data;
    }

    /**
     * 获取（刷新）授权公众号的接口调用凭据（令牌)
     *
     * @param  string $authorizer_app_id        公众号app_id
     * @param  string $authorizer_refresh_token 刷新TOKEN的 authorizer_refresh_token
     *
     * @return array authorization_info
     */
    private function getApiAuthorizerToken($authorizer_app_id = '', $authorizer_refresh_token = '')
    {
        $query_data   = http_build_query(['component_access_token' => $this->getComponentAccessToken()]);
        $request_data = [
            'component_appid'          => $this->configs->component_app_id,
            'authorizer_appid'         => $authorizer_app_id,
            'authorizer_refresh_token' => $authorizer_refresh_token,
        ];

        $response_data = Http::_post(self::GET_API_AUTHORIZER_TOKEN_URL . '?' . $query_data, $request_data);

        if (!$response_data) {

            $this->setError(Http::$error);

            return false;
        }

        return $response_data;
    }

    /**
     * 获取授权服务号 AccessToken
     *
     * @param string $authorizer_app_id
     *
     * @return bool
     */
    public function getAuthorizerAccessToken($authorizer_app_id = '')
    {
        $query_auth_info = $this->getApiQueryAuth($authorizer_app_id);

        if (!empty($query_auth_info)) {

            if ($query_auth_info['authorization_state'] == 'authorized') {
                return $query_auth_info['authorization_info']['authorizer_access_token'];
            } else {
                $this->setError('已经取消授权的服务号:' . $query_auth_info['authorization_info']['authorizer_appid']);

                return false;
            }
        }

        return false;
    }
}

1		<?php
2
3		namespace OpenOauth;
4
5		use OpenOauth\Core\Core;
6		use OpenOauth\Core\Http\Http;
7
8		class Authorized extends Core
9		{
10		const GET_API_QUERY_AUTH = 'https://api.weixin.qq.com/cgi-bin/component/api_query_auth'; //使用授权码换取公众号的接口调用凭据和授权信息
11		const GET_API_AUTHORIZER_TOKEN_URL = 'https://api.weixin.qq.com/cgi-bin/component/api_authorizer_token'; //获取（刷新）授权公众号的接口调用凭据（令牌）
12
13		/**
14		* @param $redirect_path
15		*/
16		public function getAuthHTML($redirect_path)
17		{
18		$component_app_id = $this->configs->component_app_id;
19		$pre_auth_code = $this->getComponentPreAuthCode();
20		$redirect_uri = $this->current() . $redirect_path;
21
22		$editorSrc = <<<HTML
23		<script language="JavaScript" type="text/javascript">
24		window.location.href="https://mp.weixin.qq.com/cgi-bin/componentloginpage?component_appid=$component_app_id&pre_auth_code=$pre_auth_code&redirect_uri=$redirect_uri";
25		</script>
26		HTML;
27		exit($editorSrc);
		0 ignored issues – show Coding Style Compatibility introduced 2017-06-14 07:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getAuthHTML()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
28		}
29
30	View Code Duplication	public function current()
		0 ignored issues – show Duplication introduced 2017-08-29 08:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2017-08-29 08:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this `current` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
31		{
32		$protocol = (!empty($_SERVER['HTTPS'])
33		&& $_SERVER['HTTPS'] !== 'off'
34		\|\| $_SERVER['SERVER_PORT'] === 443) ? 'https://' : 'http://';
35
36		if (isset($_SERVER['HTTP_X_FORWARDED_HOST'])) {
37		$host = $_SERVER['HTTP_X_FORWARDED_HOST'];
38		} else {
39		$host = $_SERVER['HTTP_HOST'];
40		}
41
42		return $protocol . $host . '/';
43		}
44
45		/**
46		* 使用授权码换取公众号的接口调用凭据和授权信息
47		*
48		* @param string $authorizer_app_id
49		*
50		* @return array\|bool\|null\|string\|void
51		*/
52		public function getApiQueryAuth($authorizer_app_id = '')
53		{
54		$time = time();
55
56		$authorization_info_key = 'authorized:' . $this->configs->component_app_id . ':' . $authorizer_app_id;
57		$query_auth_key = 'query_auth:' . $this->configs->component_app_id . ':' . $authorizer_app_id;
58
59		$query_auth_info = parent::$databaseDriver->_get($query_auth_key);
60		//如果存在数据
61		if (!empty($query_auth_info)) {
62
63		//没超时返回数据
64		if ($query_auth_info['expired_time'] >= ($time + 1000) && $query_auth_info['authorization_state'] == 'authorized') {
65		return $query_auth_info;
66		} else {
67		//如果超时了获取新的 access_token 和新的刷新令牌 refresh_token
68		$api_authorizer_token = $this->getApiAuthorizerToken($query_auth_info['authorization_info']['authorizer_appid'], $query_auth_info['authorization_info']['authorizer_refresh_token']);
69		if (!empty($api_authorizer_token)) {
70		$query_auth_info['authorization_info']['authorizer_access_token'] = $api_authorizer_token['authorizer_access_token'];
71		$query_auth_info['authorization_info']['authorizer_refresh_token'] = $api_authorizer_token['authorizer_refresh_token'];
72		$query_auth_info['authorization_info']['expires_in'] = $api_authorizer_token['expires_in'];
73		$query_auth_info['expired_time'] = $time + $api_authorizer_token['expires_in'];
74		$query_auth_info['authorization_state'] = 'authorized';
75
76		parent::$databaseDriver->_set($query_auth_key, $query_auth_info);
77
78		return $query_auth_info;
79		}
80		}
81		}
82
83		$authorization_info = parent::$databaseDriver->_get($authorization_info_key);
84
85		$query_data = http_build_query(['component_access_token' => $this->getComponentAccessToken()]);
86
87		if ($authorization_info['AuthorizationCodeExpiredTime'] <= $time) {
88		$this->setError('授权Code超时');
89
90		return false;
91		}
92		$request_data = [
93		'component_appid' => $authorization_info['AppId'],
94		'authorization_code' => $authorization_info['AuthorizationCode'],
95		];
96
97		$response_data = Http::_post(self::GET_API_QUERY_AUTH . '?' . $query_data, $request_data);
98
99		if (!$response_data) {
		0 ignored issues – show Bug Best Practice introduced 2016-08-06 08:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$response_data` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
100		$this->setError(Http::$error);
101
102		return false;
103		}
104
105		$response_data['authorization_state'] = 'authorized';
106		$response_data['expired_time'] = $time + $response_data['authorization_info']['expires_in'];
107		parent::$databaseDriver->_set($query_auth_key, $response_data);
108
109		return $response_data;
110		}
111
112		/**
113		* 获取（刷新）授权公众号的接口调用凭据（令牌)
114		*
115		* @param string $authorizer_app_id 公众号app_id
116		* @param string $authorizer_refresh_token 刷新TOKEN的 authorizer_refresh_token
117		*
118		* @return array authorization_info
119		*/
120		private function getApiAuthorizerToken($authorizer_app_id = '', $authorizer_refresh_token = '')
121		{
122		$query_data = http_build_query(['component_access_token' => $this->getComponentAccessToken()]);
123		$request_data = [
124		'component_appid' => $this->configs->component_app_id,
125		'authorizer_appid' => $authorizer_app_id,
126		'authorizer_refresh_token' => $authorizer_refresh_token,
127		];
128
129		$response_data = Http::_post(self::GET_API_AUTHORIZER_TOKEN_URL . '?' . $query_data, $request_data);
130
131		if (!$response_data) {
		0 ignored issues – show Bug Best Practice introduced 2016-08-06 08:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$response_data` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
132		$this->setError(Http::$error);
133
134		return false;
135		}
136
137		return $response_data;
138		}
139
140		/**
141		* 获取授权服务号 AccessToken
142		*
143		* @param string $authorizer_app_id
144		*
145		* @return bool
146		*/
147		public function getAuthorizerAccessToken($authorizer_app_id = '')
148		{
149		$query_auth_info = $this->getApiQueryAuth($authorizer_app_id);
150
151		if (!empty($query_auth_info)) {
152
153		if ($query_auth_info['authorization_state'] == 'authorized') {
154		return $query_auth_info['authorization_info']['authorizer_access_token'];
155		} else {
156		$this->setError('已经取消授权的服务号:' . $query_auth_info['authorization_info']['authorizer_appid']);
157
158		return false;
159		}
160		}
161
162		return false;
163		}
164		}

tianye / WechatOpenPlatform

Issues (65)

Security Analysis not enabled

src/Authorized.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like