Tools - Code Metrics - tianye/WechatOpenPlatform - Measure and Improve Code Quality continuously with Scrutinizer

Tools A
last analyzed 2017-08-29 08:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	45
Duplicated Lines	6.67 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
dl	3
loc	45
rs	10
c	0
b	0
f	0
wmc	9
lcom	0
cbo	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	dataRecodes()	0	4	1
B	verifySignature()	3	21	8

How to fix Duplicated Code

<?php

namespace OpenOauth\Core;

class Tools
{
    /**
     * 记录日志
     *
     * @param $title
     * @param $data
     * @param $path
     *
     * @return int
     */
    public static function dataRecodes($title, $data, $path)
    {
        return dataRecodes($title, $data, $path);
    }

    /**
     * 验证签名 成功 true 失败 false
     *
     * @param $token
     *
     * @return bool
     */
    public static function verifySignature($token)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $signature = $_GET['signature'];
        $timestamp = $_GET['timestamp'];
        $nonce     = $_GET['nonce'];

        if (!is_string($signature) || !is_numeric($timestamp) || $timestamp <= 0 || !is_string($nonce) || $nonce == '') {

            return false;
        }

        $tmpArr = [$token, $timestamp, $nonce];
        sort($tmpArr, SORT_STRING);
        $tmpStr = implode($tmpArr);
        $tmpStr = sha1($tmpStr);

        if ($tmpStr == $signature && $signature != null) {
            return true;
        } else {
            return false;
        }
    }
}

1		<?php
2
3		namespace OpenOauth\Core;
4
5		class Tools
6		{
7		/**
8		* 记录日志
9		*
10		* @param $title
11		* @param $data
12		* @param $path
13		*
14		* @return int
15		*/
16		public static function dataRecodes($title, $data, $path)
17		{
18		return dataRecodes($title, $data, $path);
19		}
20
21		/**
22		* 验证签名成功 true 失败 false
23		*
24		* @param $token
25		*
26		* @return bool
27		*/
28		public static function verifySignature($token)
		0 ignored issues – show Coding Style introduced 2016-08-06 08:39 UTC by Report Bug Copy Issue Report `verifySignature` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
29		{
30		$signature = $_GET['signature'];
31		$timestamp = $_GET['timestamp'];
32		$nonce = $_GET['nonce'];
33
34	View Code Duplication	if (!is_string($signature) \|\| !is_numeric($timestamp) \|\| $timestamp <= 0 \|\| !is_string($nonce) \|\| $nonce == '') {
		0 ignored issues – show Duplication introduced 2016-08-06 08:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		return false;
36		}
37
38		$tmpArr = [$token, $timestamp, $nonce];
39		sort($tmpArr, SORT_STRING);
40		$tmpStr = implode($tmpArr);
41		$tmpStr = sha1($tmpStr);
42
43		if ($tmpStr == $signature && $signature != null) {
44		return true;
45		} else {
46		return false;
47		}
48		}
49		}

tianye / WechatOpenPlatform

Tools A last analyzed 2017-08-29 08:44 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

Tools A
last analyzed 2017-08-29 08:44 UTC