OpenOauth\Core\CacheDriver\RedisDriver

Complexity

Total Complexity

10

Size/Duplication

Total Lines	109
Duplicated Lines	33.94 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	27	27	3
A	_get()	10	10	2
A	_set()	0	11	2
A	packData()	0	4	1
A	unpackData()	0	4	1
A	createFileName()	0	4	1

<?php

namespace OpenOauth\Core\CacheDriver;

use OpenOauth\Core\CacheDriver\BaseDriver;
use OpenOauth\Core\Config;
use Predis\Client;

/**
 * 文件缓存驱动.
 *
 */
class RedisDriver extends BaseDriver
{
    private $redis;
    private $pre;

    public function __construct($configs = [], $dir = 'Cache:OpenOauth:')

This method seems to be duplicated in your project.

    {
        parent::__construct($dir);

        $this->pre = $this->cacheDir;

        $config = $configs + ['host' => '127.0.0.1', 'port' => '6379', 'database' => '0', 'scheme' => 'tcp', 'auth' => null];

        ini_set('default_socket_timeout', 50);//socket连接超时时间;

        $this->redis = new Client(
            [
                'scheme' => $config['scheme'],
                'host'   => $config['host'],
                'port'   => $config['port'],
            ]);

        if (!empty($config['auth'])) {
            $this->redis->auth($config['auth']);
        }

        $this->redis->select($config['database']);

        if (!$this->redis) {
            exit('Redis初始化连接失败-cache');

The method __construct() contains an exit expression.

        }
    }

    /**
     * 根据缓存名获取缓存内容.
     *
     * @param string $name
     *
     * @return bool|mixed|string
     */
    public function _get($name)

This method seems to be duplicated in your project.

    {
        $name = $this->createFileName($name);
        $data = $this->redis->get($name);
        if ($data) {
            $data = $this->unpackData($data);
        }

        return $data;
    }

    /**
     * 根据缓存名 设置缓存值和超时时间.
     *
     * @param string $name    缓存名
     * @param void   $value   缓存值
     * @param int    $expires 超时时间
     *
     * @return boolean;

The doc-type boolean; could not be parsed: Expected "|" or "end of type", but got ";" at position 7. (view supported doc-types)

     */
    public function _set($name, $value, $expires)
    {
        $name = $this->createFileName($name);
        $data = $this->packData($value);

        if ($expires === 0) {
            return $this->redis->set($name, $data);
        }

        return $this->redis->setex($name, $expires, $data);
    }

    /**
     * 数据打包.
     *
     * @param void $data    缓存值
     * @param int  $expires 超时时间

There is no parameter named $expires. Was it maybe removed?

     *
     * @return string
     */
    private function packData($data)
    {
        return serialize($data);
    }

    /**
     * 数据解包.
     *
     * @param $data
     *
     * @return mixed
     */
    private function unpackData($data)
    {
        return unserialize($data);
    }

    /**
     * 创建缓存文件名.
     *
     * @param string $name 缓存名
     *
     * @return string
     */
    private function createFileName($name)
    {
        return $this->pre . md5($name);
    }
}