ShortApi - Code Metrics - tianye/WechatMpSDK - Measure and Improve Code Quality continuously with Scrutinizer

ShortApi A
last analyzed 2017-08-29 08:57 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	50
Duplicated Lines	28 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	7
c	0
b	0
f	0
lcom	1
cbo	1
dl	14
loc	50
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	url()	0	19	2
B	current()	14	14	5

How to fix Duplicated Code

<?php
namespace Wechat\API;

/**
 * 微信Url相关接口.
 *
 * @author Tian.
 */
class ShortApi extends BaseApi
{
    /**
     *  生成短连接
     *
     * @param string $long_url 需要转换的长链接，支持http://、https://、weixin://wxpay 格式的url
     * @param string $action   此处填long2short，代表长链接转短链接
     *
     * @return bool.  成功返回ok

     */
    public function url($long_url, $action = 'long2short')
    {
        if (!is_string($long_url)) {
            $this->setError('参数错误');

            return false;
        }

        $queryStr = [
            "action"   => $action,
            "long_url" => $long_url,
        ];

        $this->module = 'shorturl';

        $res = $this->_post('', $queryStr);

        return $res;
    }

    /**
     * 获取当前URL
     *
     * @return string
     */
    public static function current()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $protocol = (!empty($_SERVER['HTTPS'])
            && $_SERVER['HTTPS'] !== 'off'
            || $_SERVER['SERVER_PORT'] === 443) ? 'https://' : 'http://';

        if (isset($_SERVER['HTTP_X_FORWARDED_HOST'])) {
            $host = $_SERVER['HTTP_X_FORWARDED_HOST'];
        } else {
            $host = $_SERVER['HTTP_HOST'];
        }

        return $protocol . $host . $_SERVER['REQUEST_URI'];
    }
}


1		<?php
2		namespace Wechat\API;
3
4		/**
5		* 微信Url相关接口.
6		*
7		* @author Tian.
8		*/
9		class ShortApi extends BaseApi
10		{
11		/**
12		* 生成短连接
13		*
14		* @param string $long_url 需要转换的长链接，支持http://、https://、weixin://wxpay 格式的url
15		* @param string $action 此处填long2short，代表长链接转短链接
16		*
17		* @return bool. 成功返回ok
		0 ignored issues – show Documentation introduced 2016-08-06 08:27 UTC by Report Bug Copy Issue Report The doc-type `bool.` could not be parsed: Unknown type name "bool." at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
18		*/
19		public function url($long_url, $action = 'long2short')
20		{
21		if (!is_string($long_url)) {
22		$this->setError('参数错误');
23
24		return false;
25		}
26
27		$queryStr = [
28		"action" => $action,
29		"long_url" => $long_url,
30		];
31
32		$this->module = 'shorturl';
33
34		$res = $this->_post('', $queryStr);
35
36		return $res;
37		}
38
39		/**
40		* 获取当前URL
41		*
42		* @return string
43		*/
44	View Code Duplication	public static function current()
		0 ignored issues – show Duplication introduced 2016-08-06 08:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style introduced 2016-08-06 08:27 UTC by Report Bug Copy Issue Report `current` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
45		{
46		$protocol = (!empty($_SERVER['HTTPS'])
47		&& $_SERVER['HTTPS'] !== 'off'
48		\|\| $_SERVER['SERVER_PORT'] === 443) ? 'https://' : 'http://';
49
50		if (isset($_SERVER['HTTP_X_FORWARDED_HOST'])) {
51		$host = $_SERVER['HTTP_X_FORWARDED_HOST'];
52		} else {
53		$host = $_SERVER['HTTP_HOST'];
54		}
55
56		return $protocol . $host . $_SERVER['REQUEST_URI'];
57		}
58		}
59

tianye / WechatMpSDK

ShortApi A last analyzed 2017-08-29 08:57 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

ShortApi A
last analyzed 2017-08-29 08:57 UTC