| Conditions | 1 |
| Paths | 1 |
| Total Lines | 57 |
| Code Lines | 47 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 62 | public function provideCalls() |
||
| 63 | { |
||
| 64 | $page = 1; |
||
| 65 | $app = 'app.id'; |
||
| 66 | $domain = 'example.com'; |
||
| 67 | $api = 'http://api.similarweb.com/Site/'.$domain; |
||
| 68 | $mobileApi = 'http://api.similarweb.com/Mobile/0/'.$app; |
||
| 69 | $formatToken = 'Format=JSON&UserKey=api_token'; |
||
| 70 | $startEndMd = 'start=08-2014&end=09-2014&md=true'; |
||
| 71 | $args = $formatToken.'&'.$startEndMd.'&page='.$page; |
||
| 72 | $argsNoPage = $formatToken.'&gr=monthly&'.$startEndMd; |
||
| 73 | |||
| 74 | $domainArgs = array($domain); |
||
| 75 | $proPeriodArgs = array($domain, 'monthly', '08-2014', '09-2014', true, $page); |
||
| 76 | $proPeriodArgsNoPage = array($domain, 'monthly', '08-2014', '09-2014', true); |
||
| 77 | $proNoPeriodArgs = array($domain, '08-2014', '09-2014', true, $page); |
||
| 78 | |||
| 79 | $items = array( |
||
| 80 | array('GlobalRank', $domainArgs, $api.'/globalRank?'.$formatToken), |
||
| 81 | array('SimilarSites', $domainArgs, $api.'/similarSites?'.$formatToken), |
||
| 82 | array('Tagging', $domainArgs, $api.'/tags?'.$formatToken), |
||
| 83 | array('V0WebsiteCategorization', $domainArgs, $api.'/category?'.$formatToken), |
||
| 84 | array('WebsiteCategoryRank', $domainArgs, $api.'/categoryRank?'.$formatToken), |
||
| 85 | array('WebsiteCountryRank', $domainArgs, $api.'/countryRank?'.$formatToken), |
||
| 86 | |||
| 87 | array('Traffic', $domainArgs, $api.'/v1/traffic?'.$formatToken), |
||
| 88 | array('Engagement', $domainArgs, $api.'/v1/engagement?'.$formatToken), |
||
| 89 | array('Keywords', $domainArgs, $api.'/v1/searchintelligence?'.$formatToken), |
||
| 90 | array('SocialReferrals', $domainArgs, $api.'/v1/SocialReferringSites?'.$formatToken), |
||
| 91 | |||
| 92 | array('AdultWebsites', $domainArgs, $api.'/v2/Category?'.$formatToken), |
||
| 93 | array('AlsoVisited', $domainArgs, $api.'/v2/AlsoVisited?'.$formatToken), |
||
| 94 | array('CategoryRank', $domainArgs, $api.'/v2/CategoryRank?'.$formatToken), |
||
| 95 | array('Destinations', $domainArgs, $api.'/v2/leadingdestinationsites?'.$formatToken), |
||
| 96 | array('EstimatedVisitors', $domainArgs, $api.'/v2/EstimatedTraffic?'.$formatToken), |
||
| 97 | array('Referrals', $domainArgs, $api.'/v2/leadingreferringsites?'.$formatToken), |
||
| 98 | array('SimilarWebsites', $domainArgs, $api.'/v2/SimilarSites?'.$formatToken), |
||
| 99 | array('WebsiteCategorization', $domainArgs, $api.'/v2/Category?'.$formatToken), |
||
| 100 | array('WebsiteTags', $domainArgs, $api.'/v2/Tags?'.$formatToken), |
||
| 101 | |||
| 102 | array('TrafficPro', $proPeriodArgs, $api.'/v1/visits?'.$argsNoPage), |
||
| 103 | array('EngagementPageViews', $proPeriodArgsNoPage, $api.'/v1/pageviews?'.$argsNoPage), |
||
| 104 | array('EngagementVisitDuration', $proPeriodArgsNoPage, $api.'/v1/visitduration?'.$argsNoPage), |
||
| 105 | array('EngagementBounceRate', $proPeriodArgsNoPage, $api.'/v1/bouncerate?'.$argsNoPage), |
||
| 106 | array('KeywordsOrganicSearch', $proNoPeriodArgs, $api.'/v1/orgsearch?'.$args), |
||
| 107 | array('KeywordsPaidSearch', $proNoPeriodArgs, $api.'/v1/paidsearch?'.$args), |
||
| 108 | array('ReferralsPro', $proNoPeriodArgs, $api.'/v1/referrals?'.$args), |
||
| 109 | array('KeywordCompetitorsOrganic', $proNoPeriodArgs, $api.'/v1/orgkwcompetitor?'.$args), |
||
| 110 | array('KeywordCompetitorsPaid', $proNoPeriodArgs, $api.'/v1/paidkwcompetitor?'.$args), |
||
| 111 | |||
| 112 | array('MobileApp', array(0, $app), $mobileApi.'/v1/GetAppDetails?'.$formatToken), |
||
| 113 | array('MobileAppInstalls', array(0, $app), $mobileApi.'/v1/GetAppInstalls?'.$formatToken), |
||
| 114 | array('MobileRelatedApps', array(0, $domain), 'http://api.similarweb.com/Mobile/0/'.$domain.'/v1/GetRelatedSiteApps?'.$formatToken), |
||
| 115 | ); |
||
| 116 | |||
| 117 | return $items; |
||
| 118 | } |
||
| 119 | } |
||
| 120 |