AbstractTestCase::expectExceptionClass() - Code Metrics - Inspection of "PHPUnit 7.x support" - thunderer/Serializard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#5)

by Tomasz

created 2018-02-13 09:31 UTC

AbstractTestCase::expectExceptionClass() A

↳ Parent: AbstractTestCase

Complexity

Conditions	2
Paths	2

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	1

<?php
namespace Thunder\Serializard\Tests;

use PHPUnit\Framework\TestCase;

/**
 * @author Tomasz Kowalczyk <[email protected]>
 */
abstract class AbstractTestCase extends TestCase
{
    public function expectExceptionClass($exception)
    {
        version_compare(phpversion(), '7.0.0') > 0
            ? parent::expectException($exception)
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
            : $this->setExpectedException($exception);

    }
}


1			<?php
2			namespace Thunder\Serializard\Tests;
3
4			use PHPUnit\Framework\TestCase;
5
6			/**
7			* @author Tomasz Kowalczyk <[email protected]>
8			*/
9			abstract class AbstractTestCase extends TestCase
10			{
11			public function expectExceptionClass($exception)
12			{
13			version_compare(phpversion(), '7.0.0') > 0
14			? parent::expectException($exception)
			0 ignored issues – show Comprehensibility Bug introduced 2018-02-13 09:39 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`expectException()` instead of `expectExceptionClass()`). Are you sure this is correct? If so, you might want to change this to `$this->expectException()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
15			: $this->setExpectedException($exception);
			0 ignored issues – show Bug introduced 2017-03-06 20:52 UTC by Report Bug Copy Issue Report The method `setExpectedException()` does not exist on `Thunder\Serializard\Tests\AbstractTestCase`. Did you maybe mean `setExpectedExceptionFromAnnotation()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
16			}
17			}
18

thunderer / Serializard

Pull Request — master (#5)

AbstractTestCase::expectExceptionClass() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like