Conditions | 14 |
Paths | 67 |
Total Lines | 55 |
Code Lines | 32 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
19 | public function __invoke($var) |
||
20 | { |
||
21 | $data = file_get_contents($this->path); |
||
22 | if(!$data) { |
||
23 | throw new \RuntimeException(sprintf('Failed to read file at path %s!', $this->path)); |
||
24 | } |
||
25 | |||
26 | $yaml = Yaml::parse($data); |
||
27 | $keys = array_keys($yaml); |
||
28 | $yaml = $yaml[$keys[0]]; |
||
29 | if(!$yaml) { |
||
30 | throw new \InvalidArgumentException('No config at '.$this->path); |
||
31 | } |
||
32 | |||
33 | $hasPolicy = array_key_exists('exclusion_policy', $yaml); |
||
34 | if(!$hasPolicy || ($hasPolicy && 'ALL' !== $yaml['exclusion_policy'])) { |
||
35 | throw new \RuntimeException(sprintf('This serializer supports only ALL, %s given!', $yaml['exclusion_policy'])); |
||
36 | } |
||
37 | |||
38 | $ref = new \ReflectionObject($var); |
||
39 | $result = []; |
||
40 | $properties = array_key_exists('properties', $yaml) ? $yaml['properties'] : array(); |
||
41 | foreach($properties as $key => $config) { |
||
42 | if($config['expose'] !== true) { |
||
43 | continue; |
||
44 | } |
||
45 | |||
46 | $name = array_key_exists('serialized_name', $config) ? $config['serialized_name'] : $key; |
||
47 | |||
48 | if($ref->hasProperty($key)) { |
||
49 | $prop = $ref->getProperty($key); |
||
50 | $prop->setAccessible(true); |
||
51 | |||
52 | $result[$name] = $prop->getValue($var); |
||
53 | |||
54 | continue; |
||
55 | } |
||
56 | |||
57 | $method = 'get'.ucfirst($key); |
||
58 | if(method_exists($var, $method)) { |
||
59 | $result[$name] = call_user_func_array([$var, $method], []); |
||
60 | |||
61 | continue; |
||
62 | } |
||
63 | |||
64 | // no method or property found, skip current key |
||
65 | } |
||
66 | |||
67 | $virtual = array_key_exists('virtual_properties', $yaml) ? $yaml['virtual_properties'] : array(); |
||
68 | foreach($virtual as $method => $config) { |
||
69 | $result[$config['serialized_name']] = call_user_func_array([$var, $method], []); |
||
70 | } |
||
71 | |||
72 | return $result; |
||
73 | } |
||
74 | } |
||
75 |