Thunder\Serializard\NormalizerContainer\NormalizerContainer

Complexity

Total Complexity

12

Size/Duplication

Total Lines	63
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
A	add()	16	16	4
A	addAlias()	11	11	2
A	getRoot()	4	4	1
B	getHandler()	22	22	5

<?php
namespace Thunder\Serializard\NormalizerContainer;

/**
 * @author Tomasz Kowalczyk <tomasz@kowalczyk.cc>
 */
final class NormalizerContainer implements NormalizerContainerInterface

This class seems to be duplicated in your project.

{
    private $handlers = array();
    private $interfaces = array();
    private $aliases = array();

    public function add($class, $root, $handler)
    {
        if(false === is_callable($handler)) {
            throw new \RuntimeException(sprintf('Invalid handler for class %s!', $class));
        }

        if(class_exists($class)) {
            $this->aliases[$class] = $root;
            $this->handlers[$class] = $handler;
        } elseif(interface_exists($class)) {
            $this->aliases[$class] = $root;
            $this->interfaces[$class] = $handler;
        } else {
            throw new \RuntimeException(sprintf('Given value %s is neither class nor interface name!', $class));
        }
    }

    public function addAlias($alias, $class)
    {
        $handler = $this->getHandler($class);

        if(null === $handler) {
            throw new \RuntimeException(sprintf('Handler for class %s does not exist!', $class));
        }

        $this->handlers[$alias] = $handler;
        $this->aliases[$alias] = $this->aliases[$class];
    }

    public function getRoot($class)
    {
        return $this->aliases[$class];
    }

    public function getHandler($class)
    {
        if(array_key_exists($class, $this->handlers)) {
            return $this->handlers[$class];
        }

        $parents = array_intersect(array_keys($this->handlers), class_parents($class));
        if($parents) {

The expression $parents of type array<integer|string> is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->handlers[array_pop($parents)];
        }

        $interfaces = array_intersect(array_keys($this->interfaces), array_values(class_implements($class)));
        if($interfaces) {

The expression $interfaces of type array<integer|string> is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            if(count($interfaces) > 1) {
                throw new \RuntimeException(sprintf('Class %s implements interfaces with colliding handlers!', $class));
            }

            return $this->interfaces[$interfaces[0]];
        }

        return null;
    }
}