Thunder\Serializard\NormalizerContainer\FallbackNormalizerContainer

Complexity

Total Complexity

13

Size/Duplication

Total Lines	70
Duplicated Lines	37.14 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	setDefault()	0	4	1
A	hasDefault()	0	4	1
A	getDefault()	0	4	1
A	add()	12	12	3
A	addAlias()	7	7	1
B	getHandler()	7	26	6

<?php
namespace Thunder\Serializard\NormalizerContainer;

use Thunder\Serializard\Exception\ClassNotFoundException;
use Thunder\Serializard\Exception\NormalizerConflictException;
use Thunder\Serializard\Exception\NormalizerNotFoundException;

/**
 * @author Tomasz Kowalczyk <tomasz@kowalczyk.cc>
 */
final class FallbackNormalizerContainer implements NormalizerContainerInterface
{
    private $default;
    private $handlers = [];
    private $interfaces = [];
    private $aliases = [];

    public function add($class, callable $handler)

This method seems to be duplicated in your project.

    {
        if(class_exists($class)) {
            $this->aliases[$class] = $class;
            $this->handlers[$class] = $handler;
        } elseif(interface_exists($class)) {
            $this->aliases[$class] = $class;
            $this->interfaces[$class] = $handler;
        } else {
            throw ClassNotFoundException::fromClass($class);
        }
    }

    public function addAlias($alias, $class)

This method seems to be duplicated in your project.

    {
        $handler = $this->getHandler($class);

        $this->handlers[$alias] = $handler;
        $this->aliases[$alias] = $this->aliases[$class];
    }

    public function getHandler($class)
    {
        if(isset($this->handlers[$class])) {
            return $this->handlers[$class];
        }

        $parents = array_intersect(array_keys($this->handlers), class_parents($class));
        if($parents) {

The expression $parents of type array<integer|string> is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->handlers[array_pop($parents)];
        }

        $interfaces = array_intersect(array_keys($this->interfaces), array_values(class_implements($class)));
        if($interfaces) {

The expression $interfaces of type array<integer|string> is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

This code seems to be duplicated across your project.

            if(\count($interfaces) > 1) {
                throw NormalizerConflictException::fromClass($class, $interfaces);
            }

            return $this->interfaces[array_shift($interfaces)];
        }

        if(null === $this->default) {
            throw NormalizerNotFoundException::fromClass($class);
        }

        return $this->default;
    }

    public function setDefault(callable $handler)
    {
        $this->default = $handler;
    }

    public function hasDefault()
    {
        return null !== $this->default;
    }

    public function getDefault()
    {
        return $this->default;
    }
}