Issues in Compiler.php (master) - Issues in master - thunderer/Logeek - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Compiler.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
declare(strict_types=1);
namespace Thunder\Logeek;

final class Compiler
{
    public function compile(Board $board, $code): array
    {
        $lines = explode("\n", trim($code));
        $tree = $this->buildTree($lines);
        $functions = [];
        foreach($tree as $fn) {
            $tokens = explode(' ', $fn['line']);
            if(!$tokens || !$fn['line']) {

                continue;
            }
            $functions[$tokens[1]] = $this->compileTree($board, $fn['sub']);
        }

        return $functions;
    }

    private function compileTree(Board $board, array $tree): array
    {
        $code = [];
        while(true) {
            if(!$tree) {

                break;
            }
            $line = array_shift($tree);
            $tokens = explode(' ', $line['line']);
            if(!$tokens || !$line['line']) {

                continue;
            }
            switch($tokens[0]) {
                case 'for': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $code[] = [
                        'action' => 'for',
                        'iterations' => $tokens[1],
                        'program' => $this->compileTree($board, $line['sub']),
                    ];
                    break;
                }
                case 'none': { break; }
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                case 'if': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $else = array_shift($tree);
                    $code[] = [
                        'action' => 'if',
                        'left' => $tokens[1],
                        'operator' => $tokens[2],
                        'right' => $tokens[3],
                        'true' => $this->compileTree($board, $line['sub']),
                        'false' => $this->compileTree($board, $else['sub']),
                    ];
                    break;
                }
                case 'while': {
switch ($expr) {
    case "A": { //wrong
        doSomething();
        break;
    }
    case "B"; //wrong
        doSomething();
        break;
    case "C": //right
        doSomething();
        break;
}
                    $code[] = [
                        'action' => 'while',
                        'left' => $tokens[1],
                        'operator' => $tokens[2],
                        'right' => $tokens[3],
                        'program' => $this->compileTree($board, $line['sub']),
                    ];
                    break;
                }
                default: {
switch ($expr) {
    default: { //wrong
        doSomething();
        break;
    }
}

switch ($expr) {
    default: //right
        doSomething();
        break;
}
                    $code = array_merge($code, $this->compileSimple($board, $tokens));
                }
            }
        }

        return $code;
    }

    private function compileSimple(Board $board, array $tokens): array
    {
        $action = array_shift($tokens);
        $number = 1;
        if(is_numeric($action)) {
            $number = $action;
            $action = array_shift($tokens);
        }

        $code = [];
        for($i = 0; $i < $number; $i++) {
            $args = $board->getAction($action)->getArguments();
            if(\count($args) !== \count($tokens)) {
                throw new \RuntimeException(sprintf('Action args %s does not match tokens %s!', json_encode($args), json_encode($tokens)));
            }
            $code[] = array_merge(['action' => $action], array_combine($args, $tokens));
        }

        return $code;
    }

    private function buildTree(array $lines): array
    {
        $tree = [];
        while($lines) {

            $line = array_shift($lines);
            $level = $this->getLineLevel($line);
            $subLines = [];
            while($lines && $this->getLineLevel($lines[0]) > $level) {

                $subLines[] = array_shift($lines);
            }
            $tree[] = [
                'line' => trim($line),
                'level' => $level,
                'sub' => $this->buildTree($subLines),
            ];
        }

        return $tree;
    }

    private function getLineLevel($line): int
    {
        return (int)((\strlen($line) - \strlen(ltrim($line))) / 2);
    }
}


1			<?php
2			declare(strict_types=1);
3			namespace Thunder\Logeek;
4
5			final class Compiler
6			{
7			public function compile(Board $board, $code): array
8			{
9			$lines = explode("\n", trim($code));
10			$tree = $this->buildTree($lines);
11			$functions = [];
12			foreach($tree as $fn) {
13			$tokens = explode(' ', $fn['line']);
14			if(!$tokens \|\| !$fn['line']) {
			0 ignored issues – show Bug Best Practice introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$tokens` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
15			continue;
16			}
17			$functions[$tokens[1]] = $this->compileTree($board, $fn['sub']);
18			}
19
20			return $functions;
21			}
22
23			private function compileTree(Board $board, array $tree): array
24			{
25			$code = [];
26			while(true) {
27			if(!$tree) {
			0 ignored issues – show Bug Best Practice introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$tree` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
28			break;
29			}
30			$line = array_shift($tree);
31			$tokens = explode(' ', $line['line']);
32			if(!$tokens \|\| !$line['line']) {
			0 ignored issues – show Bug Best Practice introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$tokens` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
33			continue;
34			}
35			switch($tokens[0]) {
36			case 'for': {
			0 ignored issues – show Coding Style introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
37			$code[] = [
38			'action' => 'for',
39			'iterations' => $tokens[1],
40			'program' => $this->compileTree($board, $line['sub']),
41			];
42			break;
43			}
44			case 'none': { break; }
			0 ignored issues – show Coding Style introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
45			case 'if': {
			0 ignored issues – show Coding Style introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
46			$else = array_shift($tree);
47			$code[] = [
48			'action' => 'if',
49			'left' => $tokens[1],
50			'operator' => $tokens[2],
51			'right' => $tokens[3],
52			'true' => $this->compileTree($board, $line['sub']),
53			'false' => $this->compileTree($board, $else['sub']),
54			];
55			break;
56			}
57			case 'while': {
			0 ignored issues – show Coding Style introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this `case` statements should be defined using a colon. As per the PSR-2 coding standard, case statements should not be wrapped in curly braces. There is no need for braces, since each case is terminated by the next `break`. There is also the option to use a semicolon instead of a colon, this is discouraged because many programmers do not even know it works and the colon is universal between programming languages. switch ($expr) { case "A": { //wrong doSomething(); break; } case "B"; //wrong doSomething(); break; case "C": //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
58			$code[] = [
59			'action' => 'while',
60			'left' => $tokens[1],
61			'operator' => $tokens[2],
62			'right' => $tokens[3],
63			'program' => $this->compileTree($board, $line['sub']),
64			];
65			break;
66			}
67			default: {
			0 ignored issues – show Coding Style introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this DEFAULT statements must be defined using a colon As per the PSR-2 coding standard, default statements should not be wrapped in curly braces. switch ($expr) { default: { //wrong doSomething(); break; } } switch ($expr) { default: //right doSomething(); break; } To learn more about the PSR-2 coding standard, please refer to the PHP-Fig. Loading history...
68			$code = array_merge($code, $this->compileSimple($board, $tokens));
69			}
70			}
71			}
72
73			return $code;
74			}
75
76			private function compileSimple(Board $board, array $tokens): array
77			{
78			$action = array_shift($tokens);
79			$number = 1;
80			if(is_numeric($action)) {
81			$number = $action;
82			$action = array_shift($tokens);
83			}
84
85			$code = [];
86			for($i = 0; $i < $number; $i++) {
87			$args = $board->getAction($action)->getArguments();
88			if(\count($args) !== \count($tokens)) {
89			throw new \RuntimeException(sprintf('Action args %s does not match tokens %s!', json_encode($args), json_encode($tokens)));
90			}
91			$code[] = array_merge(['action' => $action], array_combine($args, $tokens));
92			}
93
94			return $code;
95			}
96
97			private function buildTree(array $lines): array
98			{
99			$tree = [];
100			while($lines) {
			0 ignored issues – show Bug Best Practice introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$lines` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
101			$line = array_shift($lines);
102			$level = $this->getLineLevel($line);
103			$subLines = [];
104			while($lines && $this->getLineLevel($lines[0]) > $level) {
			0 ignored issues – show Bug Best Practice introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$lines` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
105			$subLines[] = array_shift($lines);
106			}
107			$tree[] = [
108			'line' => trim($line),
109			'level' => $level,
110			'sub' => $this->buildTree($subLines),
111			];
112			}
113
114			return $tree;
115			}
116
117			private function getLineLevel($line): int
118			{
119			return (int)((\strlen($line) - \strlen(ltrim($line))) / 2);
120			}
121			}
122

thunderer / Logeek

Issues (18)

Security Analysis no request data

src/Compiler.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like