PickAction::execute() - Code Metrics - thunderer/Logeek - Measure and Improve Code Quality continuously with Scrutinizer

PickAction::execute() A
last analyzed 2018-07-09 09:45 UTC

↳ Parent: PickAction

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	3
nc	3
nop	3

<?php
declare(strict_types=1);
namespace Thunder\Logeek\Action;

use Thunder\Logeek\ActionInterface;
use Thunder\Logeek\Board;

final class PickAction implements ActionInterface
{
    private static $moveMap = [
        'left' => [0, -1],
        'right' => [0, 1],
        'up' => [-1, 0],
        'down' => [1, 0],
    ];

    public function execute(Board $board, string $alias, array $operation)
    {
        $direction = $board->getActorDirection($alias);
        list($x, $y) = $board->getActorPosition($alias);
        $newX = $x + static::$moveMap[$direction][0];

        $newY = $y + static::$moveMap[$direction][1];


        if('up' === $operation['direction']) {
            $board->debug('Pick[up]');
            $board->setField($newX, $newY, 'ground');
            $board->setActorPick($alias, 'brick');
        } elseif('down' === $operation['direction']) {
            $board->debug('Pick[down]');
            $board->setField($newX, $newY, 'brick');
            $board->setActorPick($alias, null);
        }
    }

    public function getAlias(): string
    {
        return 'pick';
    }

    public function getArguments(): array
    {
        return ['direction'];
    }
}


1			<?php
2			declare(strict_types=1);
3			namespace Thunder\Logeek\Action;
4
5			use Thunder\Logeek\ActionInterface;
6			use Thunder\Logeek\Board;
7
8			final class PickAction implements ActionInterface
9			{
10			private static $moveMap = [
11			'left' => [0, -1],
12			'right' => [0, 1],
13			'up' => [-1, 0],
14			'down' => [1, 0],
15			];
16
17			public function execute(Board $board, string $alias, array $operation)
18			{
19			$direction = $board->getActorDirection($alias);
20			list($x, $y) = $board->getActorPosition($alias);
21			$newX = $x + static::$moveMap[$direction][0];
			0 ignored issues – show Comprehensibility introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Since `Thunder\Logeek\Action\PickAction` is declared final, using late-static binding will have no effect. You might want to replace `static` with `self` instead. Late static binding only has effect in subclasses. A `final` class cannot be extended anymore so late static binding cannot occurr. Consider replacing `static::` with `self::`. To learn more about late static binding, please refer to the PHP core documentation. Loading history...
22			$newY = $y + static::$moveMap[$direction][1];
			0 ignored issues – show Comprehensibility introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Since `Thunder\Logeek\Action\PickAction` is declared final, using late-static binding will have no effect. You might want to replace `static` with `self` instead. Late static binding only has effect in subclasses. A `final` class cannot be extended anymore so late static binding cannot occurr. Consider replacing `static::` with `self::`. To learn more about late static binding, please refer to the PHP core documentation. Loading history...
23
24			if('up' === $operation['direction']) {
25			$board->debug('Pick[up]');
26			$board->setField($newX, $newY, 'ground');
27			$board->setActorPick($alias, 'brick');
28			} elseif('down' === $operation['direction']) {
29			$board->debug('Pick[down]');
30			$board->setField($newX, $newY, 'brick');
31			$board->setActorPick($alias, null);
32			}
33			}
34
35			public function getAlias(): string
36			{
37			return 'pick';
38			}
39
40			public function getArguments(): array
41			{
42			return ['direction'];
43			}
44			}
45

thunderer / Logeek

PickAction::execute() A last analyzed 2018-07-09 09:45 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

PickAction::execute() A
last analyzed 2018-07-09 09:45 UTC