DistanceSensorAction::execute() - Code Metrics - thunderer/Logeek - Measure and Improve Code Quality continuously with Scrutinizer

DistanceSensorAction::execute() A
last analyzed 2018-07-09 09:45 UTC

↳ Parent: DistanceSensorAction

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	2
nc	2
nop	3

<?php
declare(strict_types=1);
namespace Thunder\Logeek\Action;

use Thunder\Logeek\ActionInterface;
use Thunder\Logeek\Board;

final class DistanceSensorAction implements ActionInterface
{
    private static $moveMap = [
        'left' => [0, -1],
        'right' => [0, 1],
        'up' => [-1, 0],
        'down' => [1, 0],
    ];

    public function execute(Board $board, string $alias, array $operation)
    {
        $distance = 0;
        list($x, $y) = $board->getActorPosition($alias);
        $direction = $board->getActorDirection($alias);
        list($diffX, $diffY) = static::$moveMap[$direction];

        while ('ground' === $board->getField($x + $diffX, $y + $diffY)) {
            $board->debug('Scan Field[%s:%s] Field[%s:%s] Type[%s]',
                $y, $x, $y + $diffY, $x + $diffX,
                $board->getField($x + $diffX, $y + $diffY));
            $x += $diffX;
            $y += $diffY;
            $distance++;
        }
        $board->setVariable($operation['variable'], $distance);
        $board->debug('Scan Distance[%s] Variable[%s]', $distance, $operation['variable']);
    }

    public function getAlias(): string
    {
        return 'sensor-distance';
    }

    public function getArguments(): array
    {
        return ['variable'];
    }
}


1			<?php
2			declare(strict_types=1);
3			namespace Thunder\Logeek\Action;
4
5			use Thunder\Logeek\ActionInterface;
6			use Thunder\Logeek\Board;
7
8			final class DistanceSensorAction implements ActionInterface
9			{
10			private static $moveMap = [
11			'left' => [0, -1],
12			'right' => [0, 1],
13			'up' => [-1, 0],
14			'down' => [1, 0],
15			];
16
17			public function execute(Board $board, string $alias, array $operation)
18			{
19			$distance = 0;
20			list($x, $y) = $board->getActorPosition($alias);
21			$direction = $board->getActorDirection($alias);
22			list($diffX, $diffY) = static::$moveMap[$direction];
			0 ignored issues – show Comprehensibility introduced 2018-07-09 09:38 UTC by Report Bug Copy Issue Report Since `Thunder\Logeek\Action\DistanceSensorAction` is declared final, using late-static binding will have no effect. You might want to replace `static` with `self` instead. Late static binding only has effect in subclasses. A `final` class cannot be extended anymore so late static binding cannot occurr. Consider replacing `static::` with `self::`. To learn more about late static binding, please refer to the PHP core documentation. Loading history...
23			while ('ground' === $board->getField($x + $diffX, $y + $diffY)) {
24			$board->debug('Scan Field[%s:%s] Field[%s:%s] Type[%s]',
25			$y, $x, $y + $diffY, $x + $diffX,
26			$board->getField($x + $diffX, $y + $diffY));
27			$x += $diffX;
28			$y += $diffY;
29			$distance++;
30			}
31			$board->setVariable($operation['variable'], $distance);
32			$board->debug('Scan Distance[%s] Variable[%s]', $distance, $operation['variable']);
33			}
34
35			public function getAlias(): string
36			{
37			return 'sensor-distance';
38			}
39
40			public function getArguments(): array
41			{
42			return ['variable'];
43			}
44			}
45

thunderer / Logeek

DistanceSensorAction::execute() A last analyzed 2018-07-09 09:45 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

DistanceSensorAction::execute() A
last analyzed 2018-07-09 09:45 UTC