NoaaCapAlerts\Model\NoaaAlertFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getAlerts()	0	36	2
A	__construct()	0	5	1

<?php

namespace NoaaCapAlerts\Model;


use NoaaCapAlerts\Model\Polygon\PolygonFactory;
use NoaaCapAlerts\Parser\NoaaIndexParser;
use NoaaCapAlerts\XmlProvider\XmlProvider;

class NoaaAlertFactory
{
    private $xmlProvider;
    private $indexParser;

    public function __construct(XmlProvider $xmlProvider, NoaaIndexParser $indexParser, PolygonFactory $polygonFactory)
    {
        $this->xmlProvider = $xmlProvider;
        $this->indexParser = $indexParser;
        $this->polygonFactory = $polygonFactory;

The property polygonFactory does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function getAlerts(): array
    {
        $alerts = array();
        $alertData = $this->indexParser->parse($this->xmlProvider->getXml());

        foreach ($alertData as $data) {
            $alert = new NoaaAlert(
                $data['idString'],
                $data['idKey'],
                $data['updatedDateTime'],
                $data['publishedDateTime'],
                $data['authorName'],
                $data['title'],
                $data['link'],
                $data['summary'],
                $data['capEvent'],
                $data['capEffectiveDateTime'],
                $data['capExpiresDateTime'],
                $data['capStatus'],
                $data['capMsgType'],
                $data['capCategory'],
                $data['capUrgencyExpected'],
                $data['capSeverity'],
                $data['capCertainty'],
                $data['capAreaDesc'],
                $data['capPolygon'],
                $data['capGeo'],
                $data['capGeoString'],
                $data['vtec'],
                $this->polygonFactory->create($data['capPolygon'])
            );

            $alerts[] = $alert;
        }

        return $alerts;
    }
}