NoaaCapAlerts\XmlProvider\XmlProviderFactory

Complexity

Total Complexity

3

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getXmlProvider()	0	7	2
A	__construct()	0	3	1

<?php

namespace NoaaCapAlerts\XmlProvider;

class XmlProviderFactory
{
    protected $localFilePath;

    function __construct(string $localFilePath = null)
    {
        $this->localFilePath = $localFilePath;
    }

    public function getXmlProvider() : XmlProvider
    {
        if ($this->localFilePath != null) {

It seems like you are loosely comparing $this->localFilePath of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

            return new FileProvider($this->localFilePath);
        }

        return new DownloaderProvider();
    }
}