Inspection of "Merge pull request #1281 from peter-kehl/master" - thorsten/phpMyFAQ - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e63c28...e9dabe )

by Thorsten

created 2016-12-26 19:47 UTC

Status

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -19,10 +19,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
 
     if (isset($_FILES['userfile']) && 0 == $_FILES['userfile']['error']) {
         
-        $ok  = 1;
+        $ok = 1;
         $finfo = new finfo(FILEINFO_MIME_ENCODING);
         if ('utf-8' == $finfo->file($_FILES['userfile']['tmp_name'])) {
             print 'This file is not UTF_8 encoded.';
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
         $handle          = fopen($_FILES['userfile']['tmp_name'], 'r');
         $dat             = fgets($handle, 65536);
         $versionFound    = PMF_String::substr($dat, 0, 9);
-        $versionExpected = '-- pmf' . substr($faqConfig->get('main.currentVersion'), 0, 3);
+        $versionExpected = '-- pmf'.substr($faqConfig->get('main.currentVersion'), 0, 3);
 
         if ($versionFound !== $versionExpected) {
             printf('%s (Version check failure: "%s" found, "%s" expected)',
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
                 if (PMF_String::substr($dat, 0, $backup_prefix_pattern_len) == $backup_prefix_pattern) {
                     $table_prefix = trim(PMF_String::substr($dat, $backup_prefix_pattern_len));
                 }
-                if ( (PMF_String::substr($dat, 0, 2) != '--') && ($dat != '') ) {
+                if ((PMF_String::substr($dat, 0, 2) != '--') && ($dat != '')) {
                     $mquery[] = trim(PMF_String::substr($dat, 0, -1));
                 }
             }

Please login to merge, or discard this patch.

phpmyfaq/admin/group.php 2 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -20,10 +20,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
         $groupAction = 'add';
         $message = '<p class="alert alert-error">';
         foreach ($messages as $err) {
-            $message .= $err . '<br />';
+            $message .= $err.'<br />';
         }
         $message .= '</p>';
     }

Please login to merge, or discard this patch.

Braces +5 added lines, -3 removed lines patch added patch discarded remove patch

@@ -210,8 +210,9 @@  discard block
 block discarded – undo
             'auto_join'   => $group_auto_join
         );
 
-        if ($user->perm->addGroup($group_data) <= 0)
-            $messages[] = $PMF_LANG['ad_adus_dberr'];
+        if ($user->perm->addGroup($group_data) <= 0) {
+                    $messages[] = $PMF_LANG['ad_adus_dberr'];
+        }
     }
     // no errors, show list
     if (count($messages) == 0) {
@@ -228,8 +229,9 @@  discard block
 block discarded – undo
     }
 }
 
-if (!isset($message))
+if (!isset($message)) {
     $message = '';
+}
 
 // show new group form
 if ($groupAction == 'add' && $permission['addgroup']) {

Please login to merge, or discard this patch.

phpmyfaq/admin/record.save.php 1 patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

@@ -19,10 +19,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
     if (!is_null($question) && !is_null($categories)) {
         // Save entry
         $logging = new PMF_Logging($faqConfig);
-        $logging->logAdmin($user, 'Beitragsave ' . $recordId);
+        $logging->logAdmin($user, 'Beitragsave '.$recordId);
 
         printf(
             '<header><h2><i class="icon-pencil"></i> %s</h2></header>',
@@ -137,8 +137,8 @@  discard block
 block discarded – undo
             'email'         => $email,
             'comment'       => (!is_null($comment) ? 'y' : 'n'),
             'date'          => empty($date) ? date('YmdHis') : str_replace(array('-', ':', ' '), '', $date),
-            'dateStart'     => (empty($dateStart) ? '00000000000000' : str_replace('-', '', $dateStart) . '000000'),
-            'dateEnd'       => (empty($dateEnd) ? '99991231235959' : str_replace('-', '', $dateEnd) . '235959'),
+            'dateStart'     => (empty($dateStart) ? '00000000000000' : str_replace('-', '', $dateStart).'000000'),
+            'dateEnd'       => (empty($dateEnd) ? '99991231235959' : str_replace('-', '', $dateEnd).'235959'),
             'linkState'     => '',
             'linkDateCheck' => 0);
 
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
         } else {
             printf(
                 '<p class="alert alert-error">%s</p>',
-                print $PMF_LANG['ad_entry_savedfail'] . $faqConfig->getDb()->error()
+                print $PMF_LANG['ad_entry_savedfail'].$faqConfig->getDb()->error()
             );
         }
         

Please login to merge, or discard this patch.

phpmyfaq/admin/ajax.tags_list.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -19,10 +19,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
 
 $oTag              = new PMF_Tags($faqConfig);
 $autoCompleteValue = PMF_Filter::filterInput(INPUT_GET, 'q', FILTER_SANITIZE_STRIPPED);
-if (! is_null($autoCompleteValue)) {
+if (!is_null($autoCompleteValue)) {
     if (strpos($autoCompleteValue, ',')) {
         $arrayOfValues     = explode(',', $autoCompleteValue);
         $autoCompleteValue = end($arrayOfValues);

Please login to merge, or discard this patch.

phpmyfaq/admin/glossary.main.php 1 patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

@@ -19,10 +19,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -47,12 +47,12 @@  discard block
 block discarded – undo
         $definition = PMF_Filter::filterInput(INPUT_POST, 'definition', FILTER_SANITIZE_SPECIAL_CHARS);
         if ($glossary->addGlossaryItem($item, $definition)) {
             echo '<p class="alert alert-success"><a href="#" class="close" data-dismiss="alert">×</a>';
-            echo $PMF_LANG['ad_glossary_save_success'] . '</p>';
+            echo $PMF_LANG['ad_glossary_save_success'].'</p>';
         } else {
             echo '<p class="alert alert-error"><a href="#" class="close" data-dismiss="alert">×</a>';
             echo $PMF_LANG['ad_glossary_save_error'];
             echo '<br />'.$PMF_LANG["ad_adus_dberr"].'<br />';
-            echo $faqConfig->getDb()->error() . '</p>';
+            echo $faqConfig->getDb()->error().'</p>';
         }
     }
 
@@ -62,12 +62,12 @@  discard block
 block discarded – undo
         $definition = PMF_Filter::filterInput(INPUT_POST, 'definition', FILTER_SANITIZE_SPECIAL_CHARS);
         if ($glossary->updateGlossaryItem($id, $item, $definition)) {
             echo '<p class="alert alert-success"><a href="#" class="close" data-dismiss="alert">×</a>';
-            echo $PMF_LANG['ad_glossary_update_success'] . '</p>';
+            echo $PMF_LANG['ad_glossary_update_success'].'</p>';
         } else {
             echo '<p class="alert alert-error"><a href="#" class="close" data-dismiss="alert">×</a>';
             echo $PMF_LANG['ad_glossary_update_error'];
             echo '<br />'.$PMF_LANG["ad_adus_dberr"].'<br />';
-            echo $faqConfig->getDb()->error() . '</p>';
+            echo $faqConfig->getDb()->error().'</p>';
         }
     }
 
@@ -75,12 +75,12 @@  discard block
 block discarded – undo
         $id = PMF_Filter::filterInput(INPUT_GET, 'id', FILTER_VALIDATE_INT);
         if ($glossary->deleteGlossaryItem($id)) {
             echo '<p class="alert alert-success"><a href="#" class="close" data-dismiss="alert">×</a>';
-            echo $PMF_LANG['ad_glossary_delete_success'] . '</p>';
+            echo $PMF_LANG['ad_glossary_delete_success'].'</p>';
         } else {
             echo '<p class="alert alert-error"><a href="#" class="close" data-dismiss="alert">×</a>';
             echo $PMF_LANG['ad_glossary_delete_error'];
             echo '<br />'.$PMF_LANG["ad_adus_dberr"].'<br />';
-            echo $faqConfig->getDb()->error() . '</p>';
+            echo $faqConfig->getDb()->error().'</p>';
         }
     }
 

Please login to merge, or discard this patch.

phpmyfaq/admin/ajax.user.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -19,10 +19,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
 
             $user->getUserById($userId, true);
             if ($user->getStatus() == 'protected' || $userId == 1) {
-                $message = '<p class="error">' . $PMF_LANG['ad_user_error_protectedAccount'] . '</p>';
+                $message = '<p class="error">'.$PMF_LANG['ad_user_error_protectedAccount'].'</p>';
             } else {
                 if (!$user->deleteUser()) {
                     $message = $PMF_LANG['ad_user_error_delete'];
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
                         $permissions->removeFromAllGroups($userId);
                     }
     
-                    $message = '<p class="success">' . $PMF_LANG['ad_user_deleted'] . '</p>';
+                    $message = '<p class="success">'.$PMF_LANG['ad_user_deleted'].'</p>';
                 }
             }
             print json_encode($message);

Please login to merge, or discard this patch.

phpmyfaq/admin/report.export.php 1 patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

@@ -20,10 +20,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -45,18 +45,18 @@  discard block
 block discarded – undo
 
     $text    = array();
     $text[0] = array();
-    ($useCategory)     ? $text[0][] = $PMF_LANG['ad_stat_report_category'] : '';
-    ($useSubcategory)  ? $text[0][] = $PMF_LANG['ad_stat_report_sub_category'] : '';
-    ($useTranslation)  ? $text[0][] = $PMF_LANG['ad_stat_report_translations'] : '';
-    ($useLanguage)     ? $text[0][] = $PMF_LANG['ad_stat_report_language'] : '';
-    ($useId)           ? $text[0][] = $PMF_LANG['ad_stat_report_id'] : '';
-    ($useSticky)       ? $text[0][] = $PMF_LANG['ad_stat_report_sticky'] : '';
-    ($useTitle)        ? $text[0][] = $PMF_LANG['ad_stat_report_title'] : '';
+    ($useCategory) ? $text[0][] = $PMF_LANG['ad_stat_report_category'] : '';
+    ($useSubcategory) ? $text[0][] = $PMF_LANG['ad_stat_report_sub_category'] : '';
+    ($useTranslation) ? $text[0][] = $PMF_LANG['ad_stat_report_translations'] : '';
+    ($useLanguage) ? $text[0][] = $PMF_LANG['ad_stat_report_language'] : '';
+    ($useId) ? $text[0][] = $PMF_LANG['ad_stat_report_id'] : '';
+    ($useSticky) ? $text[0][] = $PMF_LANG['ad_stat_report_sticky'] : '';
+    ($useTitle) ? $text[0][] = $PMF_LANG['ad_stat_report_title'] : '';
     ($useCreationDate) ? $text[0][] = $PMF_LANG['ad_stat_report_creation_date'] : '';
-    ($useOwner)        ? $text[0][] = $PMF_LANG['ad_stat_report_owner'] : '';
+    ($useOwner) ? $text[0][] = $PMF_LANG['ad_stat_report_owner'] : '';
     ($useLastModified) ? $text[0][] = $PMF_LANG['ad_stat_report_last_modified_person'] : '';
-    ($useUrl)          ? $text[0][] = $PMF_LANG['ad_stat_report_url'] : '';
-    ($useVisits)       ? $text[0][] = $PMF_LANG['ad_stat_report_visits'] : '';
+    ($useUrl) ? $text[0][] = $PMF_LANG['ad_stat_report_url'] : '';
+    ($useVisits) ? $text[0][] = $PMF_LANG['ad_stat_report_visits'] : '';
 
     $report = new PMF_Report($faqConfig);
 

Please login to merge, or discard this patch.

phpmyfaq/admin/ajax.comment.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -19,10 +19,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -35,11 +35,11 @@  discard block
 block discarded – undo
         'filter'  => FILTER_VALIDATE_INT,
         'flags'   => FILTER_REQUIRE_ARRAY
     );
-    $checkNews  = array(
+    $checkNews = array(
         'filter'  => FILTER_VALIDATE_INT,
         'flags'   => FILTER_REQUIRE_ARRAY
     );
-    $ret     = false;
+    $ret = false;
     
     $faqComments  = PMF_Filter::filterInputArray(INPUT_POST, array('faq_comments' => $checkFaqs));
     $newsComments = PMF_Filter::filterInputArray(INPUT_POST, array('news_comments' => $checkNews));

Please login to merge, or discard this patch.

phpmyfaq/admin/stat.adminlog.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -21,10 +21,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -35,13 +35,13 @@  discard block
 block discarded – undo
     $date    = new PMF_Date($faqConfig);
     $perpage = 15;
     $pages   = PMF_Filter::filterInput(INPUT_GET, 'pages', FILTER_VALIDATE_INT);
-    $page    = PMF_Filter::filterInput(INPUT_GET, 'page' , FILTER_VALIDATE_INT, 1);
+    $page    = PMF_Filter::filterInput(INPUT_GET, 'page', FILTER_VALIDATE_INT, 1);
     
     if (is_null($pages)) {
-        $pages = round(($logging->getNumberOfEntries() + ($perpage / 3)) / $perpage, 0);
+        $pages = round(($logging->getNumberOfEntries() + ($perpage/3))/$perpage, 0);
     }
     
-    $start = ($page - 1) * $perpage;
+    $start = ($page - 1)*$perpage;
     $ende  = $start + $perpage;
 
     $baseUrl = sprintf(

Please login to merge, or discard this patch.

		@@ -19,10 +19,10 @@ discard block
		block discarded – undo
19	19
20	20	if (!defined('IS_VALID_PHPMYFAQ')) {
21	21	$protocol = 'http';
22		- if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
	22	+ if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
23	23	$protocol = 'https';
24	24	}
25		- header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
	25	+ header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
26	26	exit();
27	27	}
28	28
		@@ -43,7 +43,7 @@ discard block
		block discarded – undo
43	43
44	44	if (isset($_FILES['userfile']) && 0 == $_FILES['userfile']['error']) {
45	45
46		- $ok = 1;
	46	+ $ok = 1;
47	47	$finfo = new finfo(FILEINFO_MIME_ENCODING);
48	48	if ('utf-8' == $finfo->file($_FILES['userfile']['tmp_name'])) {
49	49	print 'This file is not UTF_8 encoded.';
		@@ -52,7 +52,7 @@ discard block
		block discarded – undo
52	52	$handle = fopen($_FILES['userfile']['tmp_name'], 'r');
53	53	$dat = fgets($handle, 65536);
54	54	$versionFound = PMF_String::substr($dat, 0, 9);
55		- $versionExpected = '-- pmf' . substr($faqConfig->get('main.currentVersion'), 0, 3);
	55	+ $versionExpected = '-- pmf'.substr($faqConfig->get('main.currentVersion'), 0, 3);
56	56
57	57	if ($versionFound !== $versionExpected) {
58	58	printf('%s (Version check failure: "%s" found, "%s" expected)',
		@@ -82,7 +82,7 @@ discard block
		block discarded – undo
82	82	if (PMF_String::substr($dat, 0, $backup_prefix_pattern_len) == $backup_prefix_pattern) {
83	83	$table_prefix = trim(PMF_String::substr($dat, $backup_prefix_pattern_len));
84	84	}
85		- if ( (PMF_String::substr($dat, 0, 2) != '--') && ($dat != '') ) {
	85	+ if ((PMF_String::substr($dat, 0, 2) != '--') && ($dat != '')) {
86	86	$mquery[] = trim(PMF_String::substr($dat, 0, -1));
87	87	}
88	88	}

		@@ -20,10 +20,10 @@ discard block
		block discarded – undo
20	20
21	21	if (!defined('IS_VALID_PHPMYFAQ')) {
22	22	$protocol = 'http';
23		- if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
	23	+ if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
24	24	$protocol = 'https';
25	25	}
26		- header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
	26	+ header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
27	27	exit();
28	28	}
29	29
		@@ -222,7 +222,7 @@ discard block
		block discarded – undo
222	222	$groupAction = 'add';
223	223	$message = '<p class="alert alert-error">';
224	224	foreach ($messages as $err) {
225		- $message .= $err . '<br />';
	225	+ $message .= $err.'<br />';
226	226	}
227	227	$message .= '</p>';
228	228	}

		@@ -210,8 +210,9 @@ discard block
		block discarded – undo
210	210	'auto_join' => $group_auto_join
211	211	);
212	212
213		- if ($user->perm->addGroup($group_data) <= 0)
214		- $messages[] = $PMF_LANG['ad_adus_dberr'];
	213	+ if ($user->perm->addGroup($group_data) <= 0) {
	214	+ $messages[] = $PMF_LANG['ad_adus_dberr'];
	215	+ }
215	216	}
216	217	// no errors, show list
217	218	if (count($messages) == 0) {
		@@ -228,8 +229,9 @@ discard block
		block discarded – undo
228	229	}
229	230	}
230	231
231		-if (!isset($message))
	232	+if (!isset($message)) {
232	233	$message = '';
	234	+}
233	235
234	236	// show new group form
235	237	if ($groupAction == 'add' && $permission['addgroup']) {

		@@ -21,10 +21,10 @@ discard block
		block discarded – undo
21	21
22	22	if (!defined('IS_VALID_PHPMYFAQ')) {
23	23	$protocol = 'http';
24		- if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
	24	+ if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
25	25	$protocol = 'https';
26	26	}
27		- header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
	27	+ header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
28	28	exit();
29	29	}
30	30
		@@ -35,13 +35,13 @@ discard block
		block discarded – undo
35	35	$date = new PMF_Date($faqConfig);
36	36	$perpage = 15;
37	37	$pages = PMF_Filter::filterInput(INPUT_GET, 'pages', FILTER_VALIDATE_INT);
38		- $page = PMF_Filter::filterInput(INPUT_GET, 'page' , FILTER_VALIDATE_INT, 1);
	38	+ $page = PMF_Filter::filterInput(INPUT_GET, 'page', FILTER_VALIDATE_INT, 1);
39	39
40	40	if (is_null($pages)) {
41		- $pages = round(($logging->getNumberOfEntries() + ($perpage / 3)) / $perpage, 0);
	41	+ $pages = round(($logging->getNumberOfEntries() + ($perpage/3))/$perpage, 0);
42	42	}
43	43
44		- $start = ($page - 1) * $perpage;
	44	+ $start = ($page - 1)*$perpage;
45	45	$ende = $start + $perpage;
46	46
47	47	$baseUrl = sprintf(

thorsten / phpMyFAQ

GitHub Access Token became invalid

Push — master ( e63c28...e9dabe )

Status

Category

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +5 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +6 added lines, -6 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +8 added lines, -8 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +12 added lines, -12 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch