Inspection of "Merge pull request #1077 from thorsten/scrutinizer..." - thorsten/phpMyFAQ - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 2.9 ( 5ab43f...869669 )

by Thorsten

created 2016-01-03 19:03 UTC

Status

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -55,18 +55,18 @@
 block discarded – undo
                     <thead>
                         <tr>
 <?php
-    ($useCategory)     ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_category']) : '';
-    ($useSubcategory)  ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_sub_category']) : '';
-    ($useTranslation)  ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_translations']) : '';
-    ($useLanguage)     ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_language']) : '';
-    ($useId)           ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_id']) : '';
-    ($useSticky)       ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_sticky']) : '';
-    ($useTitle)        ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_title']) : '';
+    ($useCategory) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_category']) : '';
+    ($useSubcategory) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_sub_category']) : '';
+    ($useTranslation) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_translations']) : '';
+    ($useLanguage) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_language']) : '';
+    ($useId) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_id']) : '';
+    ($useSticky) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_sticky']) : '';
+    ($useTitle) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_title']) : '';
     ($useCreationDate) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_creation_date']) : '';
-    ($useOwner)        ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_owner']) : '';
+    ($useOwner) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_owner']) : '';
     ($useLastModified) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_last_modified_person']) : '';
-    ($useUrl)          ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_url']) : '';
-    ($useVisits)       ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_visits']) : '';
+    ($useUrl) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_url']) : '';
+    ($useVisits) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_visits']) : '';
     ?>
                         </tr>
                     </thead>

Please login to merge, or discard this patch.

Indentation +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -1,23 +1,23 @@
 block discarded – undo
 <?php
 /**
- * View a generated report.
- *
- * PHP Version 5.5
- *
- * This Source Code Form is subject to the terms of the Mozilla Public License,
- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
- * obtain one at http://mozilla.org/MPL/2.0/.
- *
- * @category  phpMyFAQ
- *
- * @author    Gustavo Solt <[email protected]>
- * @author    Thorsten Rinne <[email protected]>
- * @copyright 2011-2016 phpMyFAQ Team
- * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
- *
- * @link      http://www.phpmyfaq.de
- * @since     2011-01-12
- */
+     * View a generated report.
+     *
+     * PHP Version 5.5
+     *
+     * This Source Code Form is subject to the terms of the Mozilla Public License,
+     * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+     * obtain one at http://mozilla.org/MPL/2.0/.
+     *
+     * @category  phpMyFAQ
+     *
+     * @author    Gustavo Solt <[email protected]>
+     * @author    Thorsten Rinne <[email protected]>
+     * @copyright 2011-2016 phpMyFAQ Team
+     * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+     *
+     * @link      http://www.phpmyfaq.de
+     * @since     2011-01-12
+     */
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
     if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {

Please login to merge, or discard this patch.

phpmyfaq/admin/session.keepalive.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -51,7 +51,7 @@
 block discarded – undo
 if (!$user instanceof PMF_User_CurrentUser) {
     $user = PMF_User_CurrentUser::getFromSession($faqConfig);
 }
-$refreshTime = (PMF_AUTH_TIMEOUT - PMF_AUTH_TIMEOUT_WARNING) * 60;
+$refreshTime = (PMF_AUTH_TIMEOUT - PMF_AUTH_TIMEOUT_WARNING)*60;
 ?>
 <!DOCTYPE html>
 <html lang="<?php print $PMF_LANG['metaLanguage']; ?>" class="no-js">

Please login to merge, or discard this patch.

Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

@@ -1,26 +1,26 @@
 block discarded – undo
 <?php
 /**
- * A dummy page used within an IFRAME for warning the user about his next
- * session expiration and to give him the contextual possibility for
- * refreshing the session by clicking <OK>.
- *
- * PHP Version 5.5
- *
- * This Source Code Form is subject to the terms of the Mozilla Public License,
- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
- * obtain one at http://mozilla.org/MPL/2.0/.
- *
- * @category  phpMyFAQ
- *
- * @author    Matteo Scaramuccia <[email protected]>
- * @author    Thorsten Rinne <[email protected]>
- * @author    Uwe Pries <[email protected]>
- * @copyright 2006-2016 phpMyFAQ Team
- * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
- *
- * @link      http://www.phpmyfaq.de
- * @since     2006-05-08
- */
+     * A dummy page used within an IFRAME for warning the user about his next
+     * session expiration and to give him the contextual possibility for
+     * refreshing the session by clicking <OK>.
+     *
+     * PHP Version 5.5
+     *
+     * This Source Code Form is subject to the terms of the Mozilla Public License,
+     * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+     * obtain one at http://mozilla.org/MPL/2.0/.
+     *
+     * @category  phpMyFAQ
+     *
+     * @author    Matteo Scaramuccia <[email protected]>
+     * @author    Thorsten Rinne <[email protected]>
+     * @author    Uwe Pries <[email protected]>
+     * @copyright 2006-2016 phpMyFAQ Team
+     * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+     *
+     * @link      http://www.phpmyfaq.de
+     * @since     2006-05-08
+     */
 define('PMF_ROOT_DIR', dirname(__DIR__));
 
 //

Please login to merge, or discard this patch.

phpmyfaq/admin/stat.adminlog.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -37,10 +37,10 @@
 block discarded – undo
     $page = PMF_Filter::filterInput(INPUT_GET, 'page', FILTER_VALIDATE_INT, 1);
 
     if (is_null($pages)) {
-        $pages = round(($logging->getNumberOfEntries() + ($perpage / 3)) / $perpage, 0);
+        $pages = round(($logging->getNumberOfEntries() + ($perpage/3))/$perpage, 0);
     }
 
-    $start = ($page - 1) * $perpage;
+    $start = ($page - 1)*$perpage;
     $ende = $start + $perpage;
 
     $baseUrl = sprintf(

Please login to merge, or discard this patch.

phpmyfaq/admin/stat.main.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -139,7 +139,7 @@
		block discarded – undo
139	139	<tr>
140	140	<td><?php echo $PMF_LANG['ad_stat_vpd'];
141	141	?>:</td>
142		- <td><?php echo(($danz != 0) ? round(($vanz / $danz), 2) : 0);
	142	+ <td><?php echo(($danz != 0) ? round(($vanz/$danz), 2) : 0);
143	143	?></td>
144	144	</tr>
145	145	<tr>

Please login to merge, or discard this patch.

Indentation +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -1,23 +1,23 @@
 block discarded – undo
 <?php
 /**
- * The main statistics page.
- *
- * PHP Version 5.5
- *
- * This Source Code Form is subject to the terms of the Mozilla Public License,
- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
- * obtain one at http://mozilla.org/MPL/2.0/.
- *
- * @category  phpMyFAQ
- *
- * @author    Thorsten Rinne <[email protected]>
- * @author    Matteo Scaramuccia <[email protected]>
- * @copyright 2003-2016 phpMyFAQ Team
- * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
- *
- * @link      http://www.phpmyfaq.de
- * @since     2003-02-24
- */
+         * The main statistics page.
+         *
+         * PHP Version 5.5
+         *
+         * This Source Code Form is subject to the terms of the Mozilla Public License,
+         * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+         * obtain one at http://mozilla.org/MPL/2.0/.
+         *
+         * @category  phpMyFAQ
+         *
+         * @author    Thorsten Rinne <[email protected]>
+         * @author    Matteo Scaramuccia <[email protected]>
+         * @copyright 2003-2016 phpMyFAQ Team
+         * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+         *
+         * @link      http://www.phpmyfaq.de
+         * @since     2003-02-24
+         */
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
     if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {

Please login to merge, or discard this patch.

phpmyfaq/admin/stat.ratings.php 2 patches

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -101,18 +101,18 @@
 block discarded – undo
         ?></td>
                         <td>
                             <?php
-                            if (round($data['num'] * 20) > 75) {
+                            if (round($data['num']*20) > 75) {
                                 $progressBar = 'success';
-                            } elseif (round($data['num'] * 20) < 25) {
+                            } elseif (round($data['num']*20) < 25) {
                                 $progressBar = 'danger';
                             } else {
                                 $progressBar = 'info';
                             }
         ?>
-                            <meter value="<?php echo round($data['num'] * 20);
+                            <meter value="<?php echo round($data['num']*20);
         ?>" max="100" min="0" low="25" optimum="75"></meter>
                         </td>
-                        <td><?php echo round($data['num'] * 20);
+                        <td><?php echo round($data['num']*20);
         ?>%</td>
                     </tr>
 <?php

Please login to merge, or discard this patch.

Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

@@ -1,22 +1,22 @@
 block discarded – undo
 <?php
 /**
- * The page with the ratings of the votings.
- *
- * PHP Version 5.5
- *
- * This Source Code Form is subject to the terms of the Mozilla Public License,
- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
- * obtain one at http://mozilla.org/MPL/2.0/.
- *
- * @category  phpMyFAQ
- *
- * @author    Thorsten Rinne <[email protected]>
- * @copyright 2003-2016 phpMyFAQ Team
- * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
- *
- * @link      http://www.phpmyfaq.de
- * @since     2003-02-24
- */
+     * The page with the ratings of the votings.
+     *
+     * PHP Version 5.5
+     *
+     * This Source Code Form is subject to the terms of the Mozilla Public License,
+     * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+     * obtain one at http://mozilla.org/MPL/2.0/.
+     *
+     * @category  phpMyFAQ
+     *
+     * @author    Thorsten Rinne <[email protected]>
+     * @copyright 2003-2016 phpMyFAQ Team
+     * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+     *
+     * @link      http://www.phpmyfaq.de
+     * @since     2003-02-24
+     */
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
     if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {

Please login to merge, or discard this patch.

phpmyfaq/admin/stat.search.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -62,10 +62,10 @@  discard block
 block discarded – undo
     $searchesList = $search->getMostPopularSearches($searchesCount + 1, true);
 
     if (is_null($pages)) {
-        $pages = round((count($searchesList) + ($perpage / 3)) / $perpage, 0);
+        $pages = round((count($searchesList) + ($perpage/3))/$perpage, 0);
     }
 
-    $start = ($page - 1) * $perpage;
+    $start = ($page - 1)*$perpage;
     $ende = $start + $perpage;
 
     $baseUrl = sprintf(
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
         }
         ++$displayedCounter;
 
-        $num = round(($searchItem['number'] * 100 / $searchesCount), 2);
+        $num = round(($searchItem['number']*100/$searchesCount), 2);
         ?>
                     <tr class="row_search_id_<?php echo $searchItem['id'] ?>">
                         <td><?php echo PMF_String::htmlspecialchars($searchItem['searchterm']);

Please login to merge, or discard this patch.

phpmyfaq/admin/trans.edit.php 3 patches

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -58,7 +58,7 @@  discard block
 block discarded – undo
 }
 
 $leftVarsOnly = array_slice($_SESSION['trans']['leftVarsOnly'],
-                              ($page - 1) * $itemsPerPage,
+                              ($page - 1)*$itemsPerPage,
                               $itemsPerPage);
 $rightVarsOnly = &$_SESSION['trans']['rightVarsOnly'];
 
@@ -76,8 +76,8 @@  discard block
 block discarded – undo
  * We use these values to add the correct number of input boxes.
  * Left column will always have 2 boxes, right - 1 to 6+ boxes.
  */
-$leftNPlurals = (int) $_SESSION['trans']['leftVarsOnly']['PMF_LANG[nplurals]'];
-$rightNPlurals = (int) $rightVarsOnly['PMF_LANG[nplurals]'];
+$leftNPlurals = (int)$_SESSION['trans']['leftVarsOnly']['PMF_LANG[nplurals]'];
+$rightNPlurals = (int)$rightVarsOnly['PMF_LANG[nplurals]'];
 
 printf(
     '<header class="row"><div class="col-lg-12"><h2 class="page-header"><i class="fa fa-wrench"></i> %s</h2></div></header>',

Please login to merge, or discard this patch.

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

@@ -188,9 +188,12 @@
 block discarded – undo
                            $tt->isKeyIgnorable($key) || $tt->isValIgnorable($line))):
                     ?>
                     <td><input class="form-control" type="text" name="<?php echo $key?>" value="<?php echo PMF_String::htmlspecialchars($rightVarsOnly[$key]) ?>" /></td>
-                    <?php else: ?>
+                    <?php else {
+    : ?>
                     <td><input class="form-control alert-danger" type="text" name="<?php echo $key?>" value="<?php echo PMF_String::htmlspecialchars($line) ?>" /></td>
-                    <?php endif; ?>
+                    <?php endif;
+}
+?>
                 </tr>
                 <?php endwhile; ?>
                 <tr>

Please login to merge, or discard this patch.

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch

@@ -1,22 +1,22 @@  discard block
 block discarded – undo
 <?php
 /**
- * Handle ajax requests for the interface translation tool.
- *
- * PHP Version 5.5
- *
- * This Source Code Form is subject to the terms of the Mozilla Public License,
- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
- * obtain one at http://mozilla.org/MPL/2.0/.
- *
- * @category  phpMyFAQ
- *
- * @author    Anatoliy Belsky <[email protected]>
- * @copyright 2009-2016 phpMyFAQ Team
- * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
- *
- * @link      http://www.phpmyfaq.de
- * @since     2009-05-11
- */
+     * Handle ajax requests for the interface translation tool.
+     *
+     * PHP Version 5.5
+     *
+     * This Source Code Form is subject to the terms of the Mozilla Public License,
+     * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+     * obtain one at http://mozilla.org/MPL/2.0/.
+     *
+     * @category  phpMyFAQ
+     *
+     * @author    Anatoliy Belsky <[email protected]>
+     * @copyright 2009-2016 phpMyFAQ Team
+     * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+     *
+     * @link      http://www.phpmyfaq.de
+     * @since     2009-05-11
+     */
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
     if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
@@ -58,8 +58,8 @@  discard block
 block discarded – undo
 }
 
 $leftVarsOnly = array_slice($_SESSION['trans']['leftVarsOnly'],
-                              ($page - 1) * $itemsPerPage,
-                              $itemsPerPage);
+                                ($page - 1) * $itemsPerPage,
+                                $itemsPerPage);
 $rightVarsOnly = &$_SESSION['trans']['rightVarsOnly'];
 
 $options = array(

Please login to merge, or discard this patch.

phpmyfaq/admin/trans.list.php 2 patches

Braces +12 added lines, -4 removed lines patch added patch discarded remove patch

@@ -107,9 +107,11 @@  discard block
 block discarded – undo
                         <?php echo $PMF_LANG['msgEdit'] ?>
                     </a>
                 </td>
-                <?php else: ?>
+                <?php else {
+    : ?>
                 <td><?php echo $PMF_LANG['msgEdit'] ?></td>
                 <?php endif;
+}
         ?>
                 <?php if ($user->perm->checkRight($user->getUserId(), 'deltranslation') && $showActions): ?>
                 <td>
@@ -118,9 +120,11 @@  discard block
 block discarded – undo
                         <?php echo $PMF_LANG['msgDelete'] ?>
                     </a>
                 </td>
-                <?php else: ?>
+                <?php else {
+    : ?>
                 <td><?php echo $PMF_LANG['msgDelete'] ?></td>
                 <?php endif;
+}
         ?>
                 <?php if ($user->perm->checkRight($user->getUserId(), 'edittranslation') && $showActions): ?>
                 <td>
@@ -129,15 +133,19 @@  discard block
 block discarded – undo
                         <?php echo $PMF_LANG['msgTransToolSendToTeam'] ?>
                     </a>
                 </td>
-                <?php else: ?>
+                <?php else {
+    : ?>
                 <td><?php echo $PMF_LANG['msgTransToolSendToTeam'] ?></td>
                 <?php endif;
+}
         ?>
                 <?php if ($isLangFileWritable): ?>
                 <td><i class="fa fa-ok-circle"></i> <?php echo $PMF_LANG['msgYes'] ?></td>
-                <?php else: ?>
+                <?php else {
+    : ?>
                 <td><i class="fa fa-ban-circle"></i> <?php echo $PMF_LANG['msgNo'] ?></td>
                 <?php endif;
+}
         ?>
                 <td>
                     <?php echo $percents ?>%

Please login to merge, or discard this patch.

Indentation +18 added lines, -18 removed lines patch added patch discarded remove patch

@@ -1,23 +1,23 @@
 block discarded – undo
 <?php
 /**
- * List avaliable interface translations and actions
- * depending on user right.
- *
- * PHP Version 5.5
- *
- * This Source Code Form is subject to the terms of the Mozilla Public License,
- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
- * obtain one at http://mozilla.org/MPL/2.0/.
- *
- * @category  phpMyFAQ
- *
- * @author    Anatoliy Belsky <[email protected]>
- * @copyright 2009-2016 phpMyFAQ Team
- * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
- *
- * @link      http://www.phpmyfaq.de
- * @since     2009-05-11
- */
+     * List avaliable interface translations and actions
+     * depending on user right.
+     *
+     * PHP Version 5.5
+     *
+     * This Source Code Form is subject to the terms of the Mozilla Public License,
+     * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+     * obtain one at http://mozilla.org/MPL/2.0/.
+     *
+     * @category  phpMyFAQ
+     *
+     * @author    Anatoliy Belsky <[email protected]>
+     * @copyright 2009-2016 phpMyFAQ Team
+     * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+     *
+     * @link      http://www.phpmyfaq.de
+     * @since     2009-05-11
+     */
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
     if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {

Please login to merge, or discard this patch.

phpmyfaq/admin/user.php 2 patches

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -59,7 +59,7 @@  discard block
 block discarded – undo
         if (!isset($_SESSION['phpmyfaq_csrf_token']) || $_SESSION['phpmyfaq_csrf_token'] !== $csrfToken) {
             $csrfOkay = false;
         }
-        if (0 === (int) $userId || !$csrfOkay) {
+        if (0 === (int)$userId || !$csrfOkay) {
             $message .= sprintf('<p class="alert alert-danger">%s</p>', $PMF_LANG['ad_user_error_noId']);
         } else {
             $user = new PMF_User($faqConfig);
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
             $csrfOkay = false;
         }
         $userAction = $defaultUserAction;
-        if (0 === (int) $userId || !$csrfOkay) {
+        if (0 === (int)$userId || !$csrfOkay) {
             $message .= sprintf('<p class="alert alert-danger">%s</p>', $PMF_LANG['ad_user_error_noId']);
         } else {
             if (!$user->getUserById($userId, true)) {
@@ -669,8 +669,8 @@  discard block
 block discarded – undo
         $numUsers = count($allUsers);
         $page = PMF_Filter::filterInput(INPUT_GET, 'page', FILTER_VALIDATE_INT, 0);
         $perPage = 10;
-        $numPages = ceil($numUsers / $perPage);
-        $lastPage = $page * $perPage;
+        $numPages = ceil($numUsers/$perPage);
+        $lastPage = $page*$perPage;
         $firstPage = $lastPage - $perPage;
 
         $baseUrl = sprintf(

Please login to merge, or discard this patch.

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch

@@ -1,25 +1,25 @@
 block discarded – undo
 <?php
 /**
- * Displays the user management frontend.
- *
- * PHP Version 5.5
- *
- * This Source Code Form is subject to the terms of the Mozilla Public License,
- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
- * obtain one at http://mozilla.org/MPL/2.0/.
- *
- * @category  phpMyFAQ
- *
- * @author    Lars Tiedemann <[email protected]>
- * @author    Uwe Pries <[email protected]>
- * @author    Sarah Hermann <[email protected]>
- * @author    Thorsten Rinne <[email protected]>
- * @copyright 2005-2016 phpMyFAQ Team
- * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
- *
- * @link      http://www.phpmyfaq.de
- * @since     2005-12-15
- */
+     * Displays the user management frontend.
+     *
+     * PHP Version 5.5
+     *
+     * This Source Code Form is subject to the terms of the Mozilla Public License,
+     * v. 2.0. If a copy of the MPL was not distributed with this file, You can
+     * obtain one at http://mozilla.org/MPL/2.0/.
+     *
+     * @category  phpMyFAQ
+     *
+     * @author    Lars Tiedemann <[email protected]>
+     * @author    Uwe Pries <[email protected]>
+     * @author    Sarah Hermann <[email protected]>
+     * @author    Thorsten Rinne <[email protected]>
+     * @copyright 2005-2016 phpMyFAQ Team
+     * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
+     *
+     * @link      http://www.phpmyfaq.de
+     * @since     2005-12-15
+     */
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
     if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {

Please login to merge, or discard this patch.

		@@ -101,18 +101,18 @@
		block discarded – undo
101	101	?></td>
102	102	<td>
103	103	<?php
104		- if (round($data['num'] * 20) > 75) {
	104	+ if (round($data['num']*20) > 75) {
105	105	$progressBar = 'success';
106		- } elseif (round($data['num'] * 20) < 25) {
	106	+ } elseif (round($data['num']*20) < 25) {
107	107	$progressBar = 'danger';
108	108	} else {
109	109	$progressBar = 'info';
110	110	}
111	111	?>
112		- <meter value="<?php echo round($data['num'] * 20);
	112	+ <meter value="<?php echo round($data['num']*20);
113	113	?>" max="100" min="0" low="25" optimum="75"></meter>
114	114	</td>
115		- <td><?php echo round($data['num'] * 20);
	115	+ <td><?php echo round($data['num']*20);
116	116	?>%</td>
117	117	</tr>
118	118	<?php

		@@ -188,9 +188,12 @@
		block discarded – undo
188	188	$tt->isKeyIgnorable($key) \|\| $tt->isValIgnorable($line))):
189	189	?>
190	190	<td><input class="form-control" type="text" name="<?php echo $key?>" value="<?php echo PMF_String::htmlspecialchars($rightVarsOnly[$key]) ?>" /></td>
191		- <?php else: ?>
	191	+ <?php else {
	192	+ : ?>
192	193	<td><input class="form-control alert-danger" type="text" name="<?php echo $key?>" value="<?php echo PMF_String::htmlspecialchars($line) ?>" /></td>
193		- <?php endif; ?>
	194	+ <?php endif;
	195	+}
	196	+?>
194	197	</tr>
195	198	<?php endwhile; ?>
196	199	<tr>

		@@ -55,18 +55,18 @@
		block discarded – undo
55	55	<thead>
56	56	<tr>
57	57	<?php
58		- ($useCategory) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_category']) : '';
59		- ($useSubcategory) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_sub_category']) : '';
60		- ($useTranslation) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_translations']) : '';
61		- ($useLanguage) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_language']) : '';
62		- ($useId) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_id']) : '';
63		- ($useSticky) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_sticky']) : '';
64		- ($useTitle) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_title']) : '';
	58	+ ($useCategory) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_category']) : '';
	59	+ ($useSubcategory) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_sub_category']) : '';
	60	+ ($useTranslation) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_translations']) : '';
	61	+ ($useLanguage) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_language']) : '';
	62	+ ($useId) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_id']) : '';
	63	+ ($useSticky) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_sticky']) : '';
	64	+ ($useTitle) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_title']) : '';
65	65	($useCreationDate) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_creation_date']) : '';
66		- ($useOwner) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_owner']) : '';
	66	+ ($useOwner) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_owner']) : '';
67	67	($useLastModified) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_last_modified_person']) : '';
68		- ($useUrl) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_url']) : '';
69		- ($useVisits) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_visits']) : '';
	68	+ ($useUrl) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_url']) : '';
	69	+ ($useVisits) ? printf('<th>%s</th>', $PMF_LANG['ad_stat_report_visits']) : '';
70	70	?>
71	71	</tr>
72	72	</thead>

		@@ -1,23 +1,23 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * View a generated report.
4		- *
5		- * PHP Version 5.5
6		- *
7		- * This Source Code Form is subject to the terms of the Mozilla Public License,
8		- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
9		- * obtain one at http://mozilla.org/MPL/2.0/.
10		- *
11		- * @category phpMyFAQ
12		- *
13		- * @author Gustavo Solt <[email protected]>
14		- * @author Thorsten Rinne <[email protected]>
15		- * @copyright 2011-2016 phpMyFAQ Team
16		- * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
17		- *
18		- * @link http://www.phpmyfaq.de
19		- * @since 2011-01-12
20		- */
	3	+ * View a generated report.
	4	+ *
	5	+ * PHP Version 5.5
	6	+ *
	7	+ * This Source Code Form is subject to the terms of the Mozilla Public License,
	8	+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can
	9	+ * obtain one at http://mozilla.org/MPL/2.0/.
	10	+ *
	11	+ * @category phpMyFAQ
	12	+ *
	13	+ * @author Gustavo Solt <[email protected]>
	14	+ * @author Thorsten Rinne <[email protected]>
	15	+ * @copyright 2011-2016 phpMyFAQ Team
	16	+ * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
	17	+ *
	18	+ * @link http://www.phpmyfaq.de
	19	+ * @since 2011-01-12
	20	+ */
21	21	if (!defined('IS_VALID_PHPMYFAQ')) {
22	22	$protocol = 'http';
23	23	if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {

		@@ -51,7 +51,7 @@
		block discarded – undo
51	51	if (!$user instanceof PMF_User_CurrentUser) {
52	52	$user = PMF_User_CurrentUser::getFromSession($faqConfig);
53	53	}
54		-$refreshTime = (PMF_AUTH_TIMEOUT - PMF_AUTH_TIMEOUT_WARNING) * 60;
	54	+$refreshTime = (PMF_AUTH_TIMEOUT - PMF_AUTH_TIMEOUT_WARNING)*60;
55	55	?>
56	56	<!DOCTYPE html>
57	57	<html lang="<?php print $PMF_LANG['metaLanguage']; ?>" class="no-js">

		@@ -1,26 +1,26 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * A dummy page used within an IFRAME for warning the user about his next
4		- * session expiration and to give him the contextual possibility for
5		- * refreshing the session by clicking <OK>.
6		- *
7		- * PHP Version 5.5
8		- *
9		- * This Source Code Form is subject to the terms of the Mozilla Public License,
10		- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
11		- * obtain one at http://mozilla.org/MPL/2.0/.
12		- *
13		- * @category phpMyFAQ
14		- *
15		- * @author Matteo Scaramuccia <[email protected]>
16		- * @author Thorsten Rinne <[email protected]>
17		- * @author Uwe Pries <[email protected]>
18		- * @copyright 2006-2016 phpMyFAQ Team
19		- * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
20		- *
21		- * @link http://www.phpmyfaq.de
22		- * @since 2006-05-08
23		- */
	3	+ * A dummy page used within an IFRAME for warning the user about his next
	4	+ * session expiration and to give him the contextual possibility for
	5	+ * refreshing the session by clicking <OK>.
	6	+ *
	7	+ * PHP Version 5.5
	8	+ *
	9	+ * This Source Code Form is subject to the terms of the Mozilla Public License,
	10	+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can
	11	+ * obtain one at http://mozilla.org/MPL/2.0/.
	12	+ *
	13	+ * @category phpMyFAQ
	14	+ *
	15	+ * @author Matteo Scaramuccia <[email protected]>
	16	+ * @author Thorsten Rinne <[email protected]>
	17	+ * @author Uwe Pries <[email protected]>
	18	+ * @copyright 2006-2016 phpMyFAQ Team
	19	+ * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
	20	+ *
	21	+ * @link http://www.phpmyfaq.de
	22	+ * @since 2006-05-08
	23	+ */
24	24	define('PMF_ROOT_DIR', dirname(__DIR__));
25	25
26	26	//

		@@ -37,10 +37,10 @@
		block discarded – undo
37	37	$page = PMF_Filter::filterInput(INPUT_GET, 'page', FILTER_VALIDATE_INT, 1);
38	38
39	39	if (is_null($pages)) {
40		- $pages = round(($logging->getNumberOfEntries() + ($perpage / 3)) / $perpage, 0);
	40	+ $pages = round(($logging->getNumberOfEntries() + ($perpage/3))/$perpage, 0);
41	41	}
42	42
43		- $start = ($page - 1) * $perpage;
	43	+ $start = ($page - 1)*$perpage;
44	44	$ende = $start + $perpage;
45	45
46	46	$baseUrl = sprintf(

		@@ -1,22 +1,22 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * The page with the ratings of the votings.
4		- *
5		- * PHP Version 5.5
6		- *
7		- * This Source Code Form is subject to the terms of the Mozilla Public License,
8		- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
9		- * obtain one at http://mozilla.org/MPL/2.0/.
10		- *
11		- * @category phpMyFAQ
12		- *
13		- * @author Thorsten Rinne <[email protected]>
14		- * @copyright 2003-2016 phpMyFAQ Team
15		- * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
16		- *
17		- * @link http://www.phpmyfaq.de
18		- * @since 2003-02-24
19		- */
	3	+ * The page with the ratings of the votings.
	4	+ *
	5	+ * PHP Version 5.5
	6	+ *
	7	+ * This Source Code Form is subject to the terms of the Mozilla Public License,
	8	+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can
	9	+ * obtain one at http://mozilla.org/MPL/2.0/.
	10	+ *
	11	+ * @category phpMyFAQ
	12	+ *
	13	+ * @author Thorsten Rinne <[email protected]>
	14	+ * @copyright 2003-2016 phpMyFAQ Team
	15	+ * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
	16	+ *
	17	+ * @link http://www.phpmyfaq.de
	18	+ * @since 2003-02-24
	19	+ */
20	20	if (!defined('IS_VALID_PHPMYFAQ')) {
21	21	$protocol = 'http';
22	22	if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {

		@@ -62,10 +62,10 @@ discard block
		block discarded – undo
62	62	$searchesList = $search->getMostPopularSearches($searchesCount + 1, true);
63	63
64	64	if (is_null($pages)) {
65		- $pages = round((count($searchesList) + ($perpage / 3)) / $perpage, 0);
	65	+ $pages = round((count($searchesList) + ($perpage/3))/$perpage, 0);
66	66	}
67	67
68		- $start = ($page - 1) * $perpage;
	68	+ $start = ($page - 1)*$perpage;
69	69	$ende = $start + $perpage;
70	70
71	71	$baseUrl = sprintf(
		@@ -118,7 +118,7 @@ discard block
		block discarded – undo
118	118	}
119	119	++$displayedCounter;
120	120
121		- $num = round(($searchItem['number'] * 100 / $searchesCount), 2);
	121	+ $num = round(($searchItem['number']*100/$searchesCount), 2);
122	122	?>
123	123	<tr class="row_search_id_<?php echo $searchItem['id'] ?>">
124	124	<td><?php echo PMF_String::htmlspecialchars($searchItem['searchterm']);

		@@ -58,7 +58,7 @@ discard block
		block discarded – undo
58	58	}
59	59
60	60	$leftVarsOnly = array_slice($_SESSION['trans']['leftVarsOnly'],
61		- ($page - 1) * $itemsPerPage,
	61	+ ($page - 1)*$itemsPerPage,
62	62	$itemsPerPage);
63	63	$rightVarsOnly = &$_SESSION['trans']['rightVarsOnly'];
64	64
		@@ -76,8 +76,8 @@ discard block
		block discarded – undo
76	76	* We use these values to add the correct number of input boxes.
77	77	* Left column will always have 2 boxes, right - 1 to 6+ boxes.
78	78	*/
79		-$leftNPlurals = (int) $_SESSION['trans']['leftVarsOnly']['PMF_LANG[nplurals]'];
80		-$rightNPlurals = (int) $rightVarsOnly['PMF_LANG[nplurals]'];
	79	+$leftNPlurals = (int)$_SESSION['trans']['leftVarsOnly']['PMF_LANG[nplurals]'];
	80	+$rightNPlurals = (int)$rightVarsOnly['PMF_LANG[nplurals]'];
81	81
82	82	printf(
83	83	'<header class="row"><div class="col-lg-12"><h2 class="page-header"><i class="fa fa-wrench"></i> %s</h2></div></header>',

		@@ -1,22 +1,22 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Handle ajax requests for the interface translation tool.
4		- *
5		- * PHP Version 5.5
6		- *
7		- * This Source Code Form is subject to the terms of the Mozilla Public License,
8		- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
9		- * obtain one at http://mozilla.org/MPL/2.0/.
10		- *
11		- * @category phpMyFAQ
12		- *
13		- * @author Anatoliy Belsky <[email protected]>
14		- * @copyright 2009-2016 phpMyFAQ Team
15		- * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
16		- *
17		- * @link http://www.phpmyfaq.de
18		- * @since 2009-05-11
19		- */
	3	+ * Handle ajax requests for the interface translation tool.
	4	+ *
	5	+ * PHP Version 5.5
	6	+ *
	7	+ * This Source Code Form is subject to the terms of the Mozilla Public License,
	8	+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can
	9	+ * obtain one at http://mozilla.org/MPL/2.0/.
	10	+ *
	11	+ * @category phpMyFAQ
	12	+ *
	13	+ * @author Anatoliy Belsky <[email protected]>
	14	+ * @copyright 2009-2016 phpMyFAQ Team
	15	+ * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
	16	+ *
	17	+ * @link http://www.phpmyfaq.de
	18	+ * @since 2009-05-11
	19	+ */
20	20	if (!defined('IS_VALID_PHPMYFAQ')) {
21	21	$protocol = 'http';
22	22	if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
		@@ -58,8 +58,8 @@ discard block
		block discarded – undo
58	58	}
59	59
60	60	$leftVarsOnly = array_slice($_SESSION['trans']['leftVarsOnly'],
61		- ($page - 1) * $itemsPerPage,
62		- $itemsPerPage);
	61	+ ($page - 1) * $itemsPerPage,
	62	+ $itemsPerPage);
63	63	$rightVarsOnly = &$_SESSION['trans']['rightVarsOnly'];
64	64
65	65	$options = array(

		@@ -107,9 +107,11 @@ discard block
		block discarded – undo
107	107	<?php echo $PMF_LANG['msgEdit'] ?>
108	108	</a>
109	109	</td>
110		- <?php else: ?>
	110	+ <?php else {
	111	+ : ?>
111	112	<td><?php echo $PMF_LANG['msgEdit'] ?></td>
112	113	<?php endif;
	114	+}
113	115	?>
114	116	<?php if ($user->perm->checkRight($user->getUserId(), 'deltranslation') && $showActions): ?>
115	117	<td>
		@@ -118,9 +120,11 @@ discard block
		block discarded – undo
118	120	<?php echo $PMF_LANG['msgDelete'] ?>
119	121	</a>
120	122	</td>
121		- <?php else: ?>
	123	+ <?php else {
	124	+ : ?>
122	125	<td><?php echo $PMF_LANG['msgDelete'] ?></td>
123	126	<?php endif;
	127	+}
124	128	?>
125	129	<?php if ($user->perm->checkRight($user->getUserId(), 'edittranslation') && $showActions): ?>
126	130	<td>
		@@ -129,15 +133,19 @@ discard block
		block discarded – undo
129	133	<?php echo $PMF_LANG['msgTransToolSendToTeam'] ?>
130	134	</a>
131	135	</td>
132		- <?php else: ?>
	136	+ <?php else {
	137	+ : ?>
133	138	<td><?php echo $PMF_LANG['msgTransToolSendToTeam'] ?></td>
134	139	<?php endif;
	140	+}
135	141	?>
136	142	<?php if ($isLangFileWritable): ?>
137	143	<td><i class="fa fa-ok-circle"></i> <?php echo $PMF_LANG['msgYes'] ?></td>
138		- <?php else: ?>
	144	+ <?php else {
	145	+ : ?>
139	146	<td><i class="fa fa-ban-circle"></i> <?php echo $PMF_LANG['msgNo'] ?></td>
140	147	<?php endif;
	148	+}
141	149	?>
142	150	<td>
143	151	<?php echo $percents ?>%

		@@ -59,7 +59,7 @@ discard block
		block discarded – undo
59	59	if (!isset($_SESSION['phpmyfaq_csrf_token']) \|\| $_SESSION['phpmyfaq_csrf_token'] !== $csrfToken) {
60	60	$csrfOkay = false;
61	61	}
62		- if (0 === (int) $userId \|\| !$csrfOkay) {
	62	+ if (0 === (int)$userId \|\| !$csrfOkay) {
63	63	$message .= sprintf('<p class="alert alert-danger">%s</p>', $PMF_LANG['ad_user_error_noId']);
64	64	} else {
65	65	$user = new PMF_User($faqConfig);
		@@ -180,7 +180,7 @@ discard block
		block discarded – undo
180	180	$csrfOkay = false;
181	181	}
182	182	$userAction = $defaultUserAction;
183		- if (0 === (int) $userId \|\| !$csrfOkay) {
	183	+ if (0 === (int)$userId \|\| !$csrfOkay) {
184	184	$message .= sprintf('<p class="alert alert-danger">%s</p>', $PMF_LANG['ad_user_error_noId']);
185	185	} else {
186	186	if (!$user->getUserById($userId, true)) {
		@@ -669,8 +669,8 @@ discard block
		block discarded – undo
669	669	$numUsers = count($allUsers);
670	670	$page = PMF_Filter::filterInput(INPUT_GET, 'page', FILTER_VALIDATE_INT, 0);
671	671	$perPage = 10;
672		- $numPages = ceil($numUsers / $perPage);
673		- $lastPage = $page * $perPage;
	672	+ $numPages = ceil($numUsers/$perPage);
	673	+ $lastPage = $page*$perPage;
674	674	$firstPage = $lastPage - $perPage;
675	675
676	676	$baseUrl = sprintf(

		@@ -1,25 +1,25 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * Displays the user management frontend.
4		- *
5		- * PHP Version 5.5
6		- *
7		- * This Source Code Form is subject to the terms of the Mozilla Public License,
8		- * v. 2.0. If a copy of the MPL was not distributed with this file, You can
9		- * obtain one at http://mozilla.org/MPL/2.0/.
10		- *
11		- * @category phpMyFAQ
12		- *
13		- * @author Lars Tiedemann <[email protected]>
14		- * @author Uwe Pries <[email protected]>
15		- * @author Sarah Hermann <[email protected]>
16		- * @author Thorsten Rinne <[email protected]>
17		- * @copyright 2005-2016 phpMyFAQ Team
18		- * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
19		- *
20		- * @link http://www.phpmyfaq.de
21		- * @since 2005-12-15
22		- */
	3	+ * Displays the user management frontend.
	4	+ *
	5	+ * PHP Version 5.5
	6	+ *
	7	+ * This Source Code Form is subject to the terms of the Mozilla Public License,
	8	+ * v. 2.0. If a copy of the MPL was not distributed with this file, You can
	9	+ * obtain one at http://mozilla.org/MPL/2.0/.
	10	+ *
	11	+ * @category phpMyFAQ
	12	+ *
	13	+ * @author Lars Tiedemann <[email protected]>
	14	+ * @author Uwe Pries <[email protected]>
	15	+ * @author Sarah Hermann <[email protected]>
	16	+ * @author Thorsten Rinne <[email protected]>
	17	+ * @copyright 2005-2016 phpMyFAQ Team
	18	+ * @license http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
	19	+ *
	20	+ * @link http://www.phpmyfaq.de
	21	+ * @since 2005-12-15
	22	+ */
23	23	if (!defined('IS_VALID_PHPMYFAQ')) {
24	24	$protocol = 'http';
25	25	if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {

thorsten / phpMyFAQ

GitHub Access Token became invalid

Push — 2.9 ( 5ab43f...869669 )

Status

Category

Spacing +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +21 added lines, -21 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +17 added lines, -17 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +5 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +19 added lines, -19 removed lines patch added patch discarded remove patch

Braces +12 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +18 added lines, -18 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +20 added lines, -20 removed lines patch added patch discarded remove patch