Inspection of "Merge pull request #1363 from manjeshpv/patch-1" - thorsten/phpMyFAQ - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 266fe5...d77780 )

by Thorsten

created 2017-09-23 15:11 UTC

Status

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -65,7 +65,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
 
 //faqattachment
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
 id int(11) NOT NULL,
 record_id int(11) NOT NULL,
 record_lang varchar(5) NOT NULL,
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
 
 //faqattachment file
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
 virtual_hash char(32) NOT NULL,
 contents blob NOT NULL,
 PRIMARY KEY (virtual_hash)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (group_id, right_id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
 
 //faqinstances
-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
 id INT(11) NOT NULL,
 url VARCHAR(255) NOT NULL,
 instance VARCHAR(255) NOT NULL,
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
 
 //faqinstances_config
-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances_config (
+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances_config (
 instance_id INT(11) NOT NULL,
 config_name VARCHAR(255) NOT NULL default '',
 config_value VARCHAR(255) DEFAULT NULL,

Please login to merge, or discard this patch.

phpmyfaq/setup/assets/sql/sqlite3.sql.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -64,7 +64,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id))";
 
 //faqattachment
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
 id INTEGER NOT NULL,
 record_id INTEGER NOT NULL,
 record_lang VARCHAR(5) NOT NULL,
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id))";
 
 //faqattachment file
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
 virtual_hash CHAR(32) NOT NULL,
 contents BLOB NOT NULL,
 PRIMARY KEY (virtual_hash))";
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
 )";
 
 //faqinstances
-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
 id INT(11) NOT NULL,
 url VARCHAR(255) NOT NULL,
 instance VARCHAR(255) NOT NULL,

Please login to merge, or discard this patch.

phpmyfaq/setup/assets/sql/sqlsrv.sql.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id))";
 
 //faqattachment
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
 id INTEGER NOT NULL,
 record_id INTEGER NOT NULL,
 record_lang VARCHAR(5) NOT NULL,
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id))";
 
 //faqattachment file
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
 virtual_hash CHAR(32) NOT NULL,
 contents TEXT NOT NULL,
 PRIMARY KEY (virtual_hash))";
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
 )";
 
 //faqinstances
-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
 id INT NOT NULL,
 url VARCHAR(255) NOT NULL,
 instance VARCHAR(255) NOT NULL,

Please login to merge, or discard this patch.

phpmyfaq/setup/assets/sql/mysqli.sql.php 1 patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -65,7 +65,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
 
 //faqattachment
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
 id int(11) NOT NULL,
 record_id int(11) NOT NULL,
 record_lang varchar(5) NOT NULL,
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
 
 //faqattachment file
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
 virtual_hash char(32) NOT NULL,
 contents blob NOT NULL,
 PRIMARY KEY (virtual_hash)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (group_id, right_id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
 
 //faqinstances
-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
 id INT(11) NOT NULL,
 url VARCHAR(255) NOT NULL,
 instance VARCHAR(255) NOT NULL,
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
 
 //faqinstances_config
-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances_config (
+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances_config (
 instance_id INT(11) NOT NULL,
 config_name VARCHAR(255) NOT NULL default '',
 config_value VARCHAR(255) DEFAULT NULL,

Please login to merge, or discard this patch.

phpmyfaq/setup/assets/sql/pgsql.sql.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -240,7 +240,7 @@  discard block
 block discarded – undo
 )";
 
 //faqinstances
-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
 id SERIAL NOT NULL,
 url VARCHAR(255) NOT NULL,
 instance VARCHAR(255) NOT NULL,
@@ -378,7 +378,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id))";
 
 //faqattachment
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
 id SERIAL NOT NULL,
 record_id int4 NOT NULL,
 record_lang varchar(5) NOT NULL,
@@ -392,7 +392,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id))";
 
 //faqattachment file
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
 virtual_hash char(32) NOT NULL,
 contents bytea,
 PRIMARY KEY (virtual_hash))";

Please login to merge, or discard this patch.

phpmyfaq/setup/assets/sql/mssql.sql.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -72,7 +72,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id))";
 
 //faqattachment
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
 id INTEGER NOT NULL,
 record_id INTEGER NOT NULL,
 record_lang VARCHAR(5) NOT NULL,
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
 PRIMARY KEY (id))";
 
 //faqattachment file
-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
 virtual_hash CHAR(32) NOT NULL,
 contents TEXT NOT NULL,
 PRIMARY KEY (virtual_hash))";
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
 )";
 
 //faqinstances
-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
 id INT NOT NULL,
 url VARCHAR(255) NOT NULL,
 instance VARCHAR(255) NOT NULL,

Please login to merge, or discard this patch.

phpmyfaq/password.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -19,10 +19,10 @@
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 

Please login to merge, or discard this patch.

phpmyfaq/config/constants_ldap.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -19,7 +19,7 @@  discard block
 block discarded – undo
  */
 
 // Datamapping - in this example for an ADS
-$PMF_LDAP['ldap_mapping'] = array (
+$PMF_LDAP['ldap_mapping'] = array(
     'name'     => 'cn',
     'username' => 'samAccountName',
     'mail'     => 'mail'
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
 
 // LDAP-options to set
 // refer to the documentation of ldap_set_option() for information on available options
-$PMF_LDAP["ldap_options"] = array (
+$PMF_LDAP["ldap_options"] = array(
     'LDAP_OPT_PROTOCOL_VERSION' => 3,
     'LDAP_OPT_REFERRALS'        => 0
 );

Please login to merge, or discard this patch.

phpmyfaq/open.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -19,10 +19,10 @@  discard block
 block discarded – undo
 
 if (!defined('IS_VALID_PHPMYFAQ')) {
     $protocol = 'http';
-    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
+    if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
         $protocol = 'https';
     }
-    header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
+    header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
     exit();
 }
 
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
     // @todo handle the exception
 }
 
-$tpl->parse (
+$tpl->parse(
     'writeContent',
     array(
         'msgOpenQuestions'   => $PMF_LANG['msgOpenQuestions'],

Please login to merge, or discard this patch.

GitHub Access Token became invalid

Push — master ( 266fe5...d77780 )

Status

Category

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
66	66
67	67	//faqattachment
68		-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
	68	+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
69	69	id int(11) NOT NULL,
70	70	record_id int(11) NOT NULL,
71	71	record_lang varchar(5) NOT NULL,
		@@ -79,7 +79,7 @@ discard block
		block discarded – undo
79	79	PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
80	80
81	81	//faqattachment file
82		-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
	82	+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
83	83	virtual_hash char(32) NOT NULL,
84	84	contents blob NOT NULL,
85	85	PRIMARY KEY (virtual_hash)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
		@@ -238,7 +238,7 @@ discard block
		block discarded – undo
238	238	PRIMARY KEY (group_id, right_id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
239	239
240	240	//faqinstances
241		-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
	241	+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
242	242	id INT(11) NOT NULL,
243	243	url VARCHAR(255) NOT NULL,
244	244	instance VARCHAR(255) NOT NULL,
		@@ -248,7 +248,7 @@ discard block
		block discarded – undo
248	248	PRIMARY KEY (id)) DEFAULT CHARACTER SET utf8 COLLATE utf8_general_ci";
249	249
250	250	//faqinstances_config
251		-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances_config (
	251	+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances_config (
252	252	instance_id INT(11) NOT NULL,
253	253	config_name VARCHAR(255) NOT NULL default '',
254	254	config_value VARCHAR(255) DEFAULT NULL,

		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	PRIMARY KEY (id))";
65	65
66	66	//faqattachment
67		-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
	67	+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
68	68	id INTEGER NOT NULL,
69	69	record_id INTEGER NOT NULL,
70	70	record_lang VARCHAR(5) NOT NULL,
		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78	PRIMARY KEY (id))";
79	79
80	80	//faqattachment file
81		-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
	81	+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
82	82	virtual_hash CHAR(32) NOT NULL,
83	83	contents BLOB NOT NULL,
84	84	PRIMARY KEY (virtual_hash))";
		@@ -240,7 +240,7 @@ discard block
		block discarded – undo
240	240	)";
241	241
242	242	//faqinstances
243		-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
	243	+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
244	244	id INT(11) NOT NULL,
245	245	url VARCHAR(255) NOT NULL,
246	246	instance VARCHAR(255) NOT NULL,

		@@ -72,7 +72,7 @@ discard block
		block discarded – undo
72	72	PRIMARY KEY (id))";
73	73
74	74	//faqattachment
75		-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment (
	75	+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment (
76	76	id INTEGER NOT NULL,
77	77	record_id INTEGER NOT NULL,
78	78	record_lang VARCHAR(5) NOT NULL,
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	PRIMARY KEY (id))";
87	87
88	88	//faqattachment file
89		-$query[] = "CREATE TABLE " . $sqltblpre . "faqattachment_file (
	89	+$query[] = "CREATE TABLE ".$sqltblpre."faqattachment_file (
90	90	virtual_hash CHAR(32) NOT NULL,
91	91	contents TEXT NOT NULL,
92	92	PRIMARY KEY (virtual_hash))";
		@@ -243,7 +243,7 @@ discard block
		block discarded – undo
243	243	)";
244	244
245	245	//faqinstances
246		-$query[] = "CREATE TABLE " . $sqltblpre . "faqinstances (
	246	+$query[] = "CREATE TABLE ".$sqltblpre."faqinstances (
247	247	id INT NOT NULL,
248	248	url VARCHAR(255) NOT NULL,
249	249	instance VARCHAR(255) NOT NULL,

		@@ -19,10 +19,10 @@
		block discarded – undo
19	19
20	20	if (!defined('IS_VALID_PHPMYFAQ')) {
21	21	$protocol = 'http';
22		- if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
	22	+ if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
23	23	$protocol = 'https';
24	24	}
25		- header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
	25	+ header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
26	26	exit();
27	27	}
28	28

		@@ -19,7 +19,7 @@ discard block
		block discarded – undo
19	19	*/
20	20
21	21	// Datamapping - in this example for an ADS
22		-$PMF_LDAP['ldap_mapping'] = array (
	22	+$PMF_LDAP['ldap_mapping'] = array(
23	23	'name' => 'cn',
24	24	'username' => 'samAccountName',
25	25	'mail' => 'mail'
		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32
33	33	// LDAP-options to set
34	34	// refer to the documentation of ldap_set_option() for information on available options
35		-$PMF_LDAP["ldap_options"] = array (
	35	+$PMF_LDAP["ldap_options"] = array(
36	36	'LDAP_OPT_PROTOCOL_VERSION' => 3,
37	37	'LDAP_OPT_REFERRALS' => 0
38	38	);

		@@ -19,10 +19,10 @@ discard block
		block discarded – undo
19	19
20	20	if (!defined('IS_VALID_PHPMYFAQ')) {
21	21	$protocol = 'http';
22		- if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON'){
	22	+ if (isset($_SERVER['HTTPS']) && strtoupper($_SERVER['HTTPS']) === 'ON') {
23	23	$protocol = 'https';
24	24	}
25		- header('Location: ' . $protocol . '://' . $_SERVER['HTTP_HOST'] . dirname($_SERVER['SCRIPT_NAME']));
	25	+ header('Location: '.$protocol.'://'.$_SERVER['HTTP_HOST'].dirname($_SERVER['SCRIPT_NAME']));
26	26	exit();
27	27	}
28	28
		@@ -32,7 +32,7 @@ discard block
		block discarded – undo
32	32	// @todo handle the exception
33	33	}
34	34
35		-$tpl->parse (
	35	+$tpl->parse(
36	36	'writeContent',
37	37	array(
38	38	'msgOpenQuestions' => $PMF_LANG['msgOpenQuestions'],

thorsten / phpMyFAQ

GitHub Access Token became invalid

Push — master ( 266fe5...d77780 )

Status

Category

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch