PMF_Perm_Medium::refuseAllGroupRights() - Code Metrics - Inspection of "Notes on installing behind a proxy" - thorsten/phpMyFAQ - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#1192)

unknown
created 2016-06-30 02:04 UTC
PMF_Perm_Medium::refuseAllGroupRights() A

↳ Parent: PMF_Perm_Medium
Complexity

Conditions	4
Paths	3
Size

Total Lines	20
Code Lines	10
Duplication

Lines	20
Ratio	100 %
Importance

Changes
Metric	Value
cc	4
eloc	10
nc	3
nop	1
dl	20
loc	20
rs	9.2
c	0
b	0
f	0
<?php
/**
 * The medium permission class provides group rights.
 *
 * PHP Version 5.4
 *
 * This Source Code Form is subject to the terms of the Mozilla Public License,
 * v. 2.0. If a copy of the MPL was not distributed with this file, You can
 * obtain one at http://mozilla.org/MPL/2.0/.
 *
 * @category  phpMyFAQ 
 * @package   Perm
 * @author    Lars Tiedemann <[email protected]>
 * @copyright 2005-2014 phpMyFAQ Team
 * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
 * @link      http://www.phpmyfaq.de
 * @since     2005-09-17
 */

if (!defined('IS_VALID_PHPMYFAQ')) {
    exit();
}

/**
 * PMF_Perm_Medium
 *
 * @category  phpMyFAQ 
 * @package   Perm
 * @author    Lars Tiedemann <[email protected]>
 * @copyright 2005-2014 phpMyFAQ Team
 * @license   http://www.mozilla.org/MPL/2.0/ Mozilla Public License Version 2.0
 * @link      http://www.phpmyfaq.de
 * @since     2005-09-17
 */
class PMF_Perm_Medium extends PMF_Perm_Basic
{
    /**
     * Default data for new groups.
     *
     * @var array
     */
    public $defaultGroupData = array(
        'name'        => 'DEFAULT_GROUP',
        'description' => 'Short group description.',
        'auto_join'   => false
    );

    /**
     * Constructor
     *
     * @param PMF_Configuration $config
     *
     * @return PMF_Perm_Medium
     */
    public function __construct(PMF_Configuration $config)
    {
        parent::__construct($config);
    }

    /**
     * Returns true if the group specified by $groupId owns the
     * right given by $rightId, otherwise false.
     *
     * @param integer $groupId Group ID
     * @param integer $rightId Right ID
     * 
     * @return bool
     */
    public function checkGroupRight($groupId, $rightId)
    {
        // check input
        if ($rightId <= 0 || $groupId <= 0 || !is_numeric($rightId) || !is_numeric($groupId)) {
            return false;
        }
        
        // check right
        $select = sprintf("
            SELECT
                fr.right_id AS right_id
            FROM
                %sfaqright fr,
                %sfaqgroup_right fgr,
                %sfaqgroup fg
            WHERE
                fr.right_id = %d AND
                fr.right_id = fgr.right_id AND
                fg.group_id = fgr.group_id AND
                fg.group_id = %d",
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            $rightId,
            $groupId
        );
        
        $res = $this->config->getDb()->query($select);
        if ($this->config->getDb()->numRows($res) == 1) {
            return true;
        }
        return false;
    }

    /**
     * Returns an array that contains the right-IDs of all
     * group-rights the group $groupId owns.
     *
     * @param integer $groupId Group ID
     * 
     * @return array
     */
    public function getGroupRights($groupId)

    {
        if ($groupId <= 0 || !is_numeric($groupId)) {
            return false;
        }
        // check right
        $select = sprintf("
            SELECT
                fr.right_id AS right_id
            FROM
                %sfaqright fr,
                %sfaqgroup_right fgr,
                %sfaqgroup fg
            WHERE
                fg.group_id = %d AND
                fg.group_id = fgr.group_id AND
                fr.right_id = fgr.right_id",
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            $groupId
        );
        
        $res    = $this->config->getDb()->query($select);
        $result = [];
        while ($row = $this->config->getDb()->fetchArray($res)) {
            $result[] = $row['right_id'];
        }
        return $result;
    }

    /**
     * Returns true, if the user given by $userId owns the right
     * specified by $right. It does not matter if the user owns this
     * right as a user-right or because of a group-membership.
     * The parameter $right may be a right-ID (recommended for
     * performance) or a right-name.
     *
     * @param integer $userId Group ID
     * @param mixed   $right  Rights
     *
     * @return boolean
     */
    public function checkRight($userId, $right)
    {
        // get right id
        if (!is_numeric($right) && is_string($right)) {
            $right = $this->getRightId($right);
        }
        
        // check user right and group right
        if ($this->checkUserGroupRight($userId, $right) || $this->checkUserRight($userId, $right)) {
            return true;
        }
        return false;
    }

    /**
     * Grants the group given by $groupId the right specified by
     * $rightId.
     *
     * @param integer $groupId Group ID
     * @param integer $rightId Right ID
     * 
     * @return boolean
     */
    public function grantGroupRight($groupId, $rightId)
    {
        // check input
        if ($rightId <= 0 || $groupId <= 0 || !is_numeric($rightId) || !is_numeric($groupId)) {
            return false;
        }
        
        // is right for users?
        $right_data = $this->getRightData($rightId);
        if (!$right_data['for_groups']) {
            return false;
        }
        
        // grant right
        $insert = sprintf("
            INSERT INTO
                %sfaqgroup_right
            (group_id, right_id)
                VALUES
            (%d, %d)",
            PMF_Db::getTablePrefix(),
            $groupId,
            $rightId
        );
            
        $res = $this->config->getDb()->query($insert);
        if (!$res) {
            return false;
        }
        return true;
    }

    /**
     * Refuses the group given by $groupId the right specified by
     * $rightId.
     *
     * @param  integer $groupId Group ID
     * @param  integer $rightId Right ID
     * @return boolean
     */
    public function refuseGroupRight($groupId, $rightId)
    {
        // check input
        if ($rightId <= 0 || $groupId <= 0 || !is_numeric($rightId) || !is_numeric($groupId)) {
            return false;
        }
        
        // grant right
        $delete = sprintf("
            DELETE FROM
                %sfaqgroup_right
            WHERE
                group_id = %d AND
                right_id = %d",
            PMF_Db::getTablePrefix(),
            $groupId,
            $rightId
        );
            
        $res = $this->config->getDb()->query($delete);
        if (!$res) {
            return false;
        }
        return true;
    }

    /**
     * Adds a new group to the database and returns the ID of the
     * new group. The associative array $groupData contains the
     * data for the new group.
     *
     * @param array $groupData Array of group data
     *
     * @return int
     */
    public function addGroup(Array $groupData)
    {
        // check if group already exists
        if ($this->getGroupId($groupData['name']) > 0) {
            return 0;
        }
        
        $nextId    = $this->config->getDb()->nextId(PMF_Db::getTablePrefix()."faqgroup", "group_id");
        $groupData = $this->checkGroupData($groupData);
        $insert     = sprintf("
            INSERT INTO
                %sfaqgroup
            (group_id, name, description, auto_join)
                VALUES
            (%d, '%s', '%s', '%s')",
            PMF_Db::getTablePrefix(),
            $nextId,
            $groupData['name'],
            $groupData['description'],
            (int)$groupData['auto_join']
        );

        $res = $this->config->getDb()->query($insert);
        if (!$res) {
            return 0;
        }
        return $nextId;
    }

    /**
     * Changes the group data of the given group.
     *
     * @param integer $groupId   Group ID
     * @param array   $groupData Array of group data
     *
     * @return boolean
     */
    public function changeGroup($groupId, Array $groupData)
    {
        $checked_data = $this->checkGroupData($groupData);
        $set          = '';
        $comma        = '';
        
        foreach ($groupData as $key => $val) {
            $set  .= $comma.$key." = '".$this->config->getDb()->escape($checked_data[$key])."'";
            $comma = ",\n                ";
        }
        
        $update = sprintf("
            UPDATE
                %sfaqgroup
            SET
                %s
            WHERE
                group_id = %d",
            PMF_Db::getTablePrefix(),
            $set,
            $groupId
        );
                
        $res = $this->config->getDb()->query($update);
        
        if (!$res) {
            return false;
        }
        return true;
    }

    /**
     * Removes the group given by $groupId from the database.
     * Returns true on success, otherwise false.
     *
     * @param integer $groupId Group ID
     *
     * @return boolean
     */
    public function deleteGroup($groupId)
    {
        if ($groupId <= 0 || !is_numeric($groupId)) {
            return false;
        }

        $delete = sprintf("
            DELETE FROM
                %sfaqgroup
            WHERE
                group_id = %d",
            PMF_Db::getTablePrefix(),
            $groupId
        );

        $res = $this->config->getDb()->query($delete);
        if (!$res) {
            return false;
        }
        
        $delete = sprintf("
            DELETE FROM
                %sfaquser_group
            WHERE
                group_id = %d",
            PMF_Db::getTablePrefix(),
            $groupId
        );

        $res = $this->config->getDb()->query($delete);
        if (!$res) {
            return false;
        }
        
        $delete = sprintf("
            DELETE FROM
                %sfaqgroup_right
            WHERE
                group_id = %d",
            PMF_Db::getTablePrefix(),
            $groupId
        );

        $res = $this->config->getDb()->query($delete);
        if (!$res) {
            return false;
        }
        
        return true;
    }

    /**
     * Returns true if the user given by $userId is a member of
     * the group specified by $groupId, otherwise false.
     *
     * @param integer $userId  User ID
     * @param integer $groupId Group ID
     *
     * @return boolean
     */
    public function isGroupMember($userId, $groupId)
    {
        if ($userId <= 0 || $groupId <= 0 || !is_numeric($userId) || !is_numeric($groupId)) {
            return false;
        }
        
        $select = sprintf("
            SELECT
                fu.user_id AS user_id
            FROM
                %sfaquser fu,
                %sfaquser_group fug,
                %sfaqgroup fg
            WHERE
                fu.user_id  = %d AND
                fu.user_id  = fug.user_id AND
                fg.group_id = fug.group_id AND
                fg.group_id = %d",
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            $userId,
            $groupId
        );
        
        $res = $this->config->getDb()->query($select);
        if ($this->config->getDb()->numRows($res) == 1) {
            return true;
        }
        return false;
    }

    /**
     * Returns an array that contains the user-IDs of all members
     * of the group $groupId.
     *
     * @param integer $groupId Group ID
     *
     * @return array
     */
    public function getGroupMembers($groupId)

    {
        if ($groupId <= 0 || !is_numeric($groupId)) {
            return false;
        }
        
        $select = sprintf("
            SELECT
                fu.user_id AS user_id
            FROM
                %sfaquser fu,
                %sfaquser_group fug,
                %sfaqgroup fg
            WHERE
                fg.group_id = %d AND
                fg.group_id = fug.group_id AND
                fu.user_id  = fug.user_id",
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            $groupId
        );
        
        $res    = $this->config->getDb()->query($select);
        $result = [];
        while ($row = $this->config->getDb()->fetchArray($res)) {
            $result[] = $row['user_id'];
        }
        return $result;
    }

    /**
     * Adds a new member $userId to the group $groupId.
     * Returns true on success, otherwise false.
     *
     * @param integer $userId  User ID
     * @param integer $groupId Group ID
     *
     * @return boolean
     */
    function addToGroup($userId, $groupId)
    {
        if ($userId <= 0 || $groupId <= 0 || !is_numeric($userId) || !is_numeric($groupId)) {
            return false;
        }
        
        if (!$this->getGroupData($groupId)) {
            return false;
        }
        
        // add user to group
        $insert = sprintf("
            INSERT INTO
                %sfaquser_group
            (user_id, group_id)
               VALUES
            (%d, %d)",
            PMF_Db::getTablePrefix(),
            $userId,
            $groupId
        );
            
        $res = $this->config->getDb()->query($insert);
        if (!$res) {
            return false;
        }
        return true;
    }

    /**
     * Removes a user $userId from the group $groupId.
     * Returns true on success, otherwise false.
     *
     * @param integer $userId  User ID
     * @param integer $groupId Group ID
     *
     * @return boolean
     */
    public function removeFromGroup($userId, $groupId)
    {
        if ($userId <= 0 || $groupId <= 0 || !is_numeric($userId) || !is_numeric($groupId)) {
            return false;
        }
        
        $delete = sprintf("
            DELETE FROM
                %sfaquser_group
            WHERE
                user_id  = %d AND
                group_id = %d",
            PMF_Db::getTablePrefix(),
            $userId,
            $groupId);
            
        $res = $this->config->getDb()->query($delete);
        if (!$res) {
            return false;
        }
        return true;
    }

    /**
     * Returns the ID of the group that has the name $name. Returns
     * 0 if the group-name cannot be found.
     *
     * @param string $name Group name
     *
     * @return int
     */
    public function getGroupId($name)
    {
        $select = sprintf("
            SELECT
                group_id
            FROM
                %sfaqgroup
            WHERE
                name = '%s'",
            PMF_Db::getTablePrefix(),
            $this->config->getDb()->escape($name)
        );
            
        $res = $this->config->getDb()->query($select);
        if ($this->config->getDb()->numRows($res) != 1) {
            return 0;
        }
        $row = $this->config->getDb()->fetchArray($res);
        return $row['group_id'];
    }

    /**
     * Returns an associative array with the group-data of the group
     * $groupId.
     *
     * @param integer $groupId Group ID
     *
     * @return array
     */
    public function getGroupData($groupId)
    {
        if ($groupId <= 0 || !is_numeric($groupId)) {
            return false;
        }
        
        $select = sprintf("
            SELECT
                group_id,
                name,
                description,
                auto_join
            FROM
                %sfaqgroup
            WHERE
                group_id = %d",
            PMF_Db::getTablePrefix(),
            $groupId
        );
            
        $res = $this->config->getDb()->query($select);
        if ($this->config->getDb()->numRows($res) != 1) {
            return [];
        }
        return $this->config->getDb()->fetchArray($res);
    }

    /**
     * Returns an array that contains the IDs of all groups in which
     * the user $userId is a member.
     *
     * @param  integer $userId User ID
     *
     * @return array
     */
    public function getUserGroups($userId)
    {
        if ($userId <= 0 || !is_numeric($userId)) {
            return array(-1);
        }
        
        $select = sprintf("
            SELECT
                fg.group_id AS group_id
            FROM
                %sfaquser fu,
                %sfaquser_group fug,
                %sfaqgroup fg
            WHERE
                fu.user_id  = %d AND
                fu.user_id  = fug.user_id AND
                fg.group_id = fug.group_id",
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            $userId
        );
        
        $res    = $this->config->getDb()->query($select);
        $result = array(-1);
        while ($row = $this->config->getDb()->fetchArray($res)) {
            $result[] = $row['group_id'];
        }
        return $result;
    }

    /**
     * Returns an array with the IDs of all groups stored in the
     * database.
     *
     * @return array
     */
    public function getAllGroups()
    {
        $select = sprintf("
            SELECT
                group_id
            FROM
                %sfaqgroup",
            PMF_Db::getTablePrefix()
        );
            
        $res    = $this->config->getDb()->query($select);
        $result = [];
        while ($row = $this->config->getDb()->fetchArray($res)) {
            $result[] = $row['group_id'];
        }

        return $result;
    }

    /**
     * Get all groups in <option> tags
     *
     * @param array $groups Selected groups
     *
     * @return string
     */
    public function getAllGroupsOptions(Array $groups)
    {
        $options   = '';
        $allGroups = $this->getAllGroups();

        foreach ($allGroups as $groupId) {
            if (-1 != $groupId) {
                $options .= sprintf('<option value="%d"%s>%s</option>',
                    $groupId,
                    (in_array($groupId, $groups) ? ' selected="selected"' : ''),
                    $this->getGroupName($groupId)
                );
            }
        }

        return $options;
    }

    /**
     * checkUserGroupRight
     *
     * Returns true if the user $userId owns the right $rightId
     * because of a group-membership, otherwise false.
     *
     * @param  integer $userId  User ID
     * @param  integer $rightId Right ID
     * @return boolean
     */
    public function checkUserGroupRight($userId, $rightId)
    {
        // check input
        if ($rightId <= 0 || $userId <= 0 || !is_numeric($rightId) || !is_numeric($userId)) {
            return false;
        }
        
        $select = sprintf("
            SELECT
                fr.right_id AS right_id
            FROM
                %sfaqright fr,
                %sfaqgroup_right fgr,
                %sfaqgroup fg,
                %sfaquser_group fug,
                %sfaquser fu
            WHERE
                fr.right_id = %d AND
                fr.right_id = fgr.right_id AND
                fg.group_id = fgr.group_id AND
                fg.group_id = fug.group_id AND
                fu.user_id  = fug.user_id AND
                fu.user_id  = %d",
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            $rightId,
            $userId
        );
        
        $res = $this->config->getDb()->query($select);
        if ($this->config->getDb()->numRows($res) == 1) {
            return true;
        }
        return false;
    }

    /**
     * Checks the given associative array $groupData. If a
     * parameter is incorrect or is missing, it will be replaced
     * by the default values in $this->defaultGroupData.
     * Returns the corrected $groupData associative array.
     *
     * @param  array $groupData Array of group data
     * @return array
     */
    public function checkGroupData(Array $groupData)
    {
        if (!isset($groupData['name']) || !is_string($groupData['name'])) {
            $groupData['name'] = $this->defaultGroupData['name'];
        }
        if (!isset($groupData['description']) || !is_string($groupData['description'])) {
            $groupData['description'] = $this->defaultGroupData['description'];
        }
        if (!isset($groupData['auto_join'])) {
            $groupData['auto_join'] = $this->defaultGroupData['auto_join'];
        }
        $groupData['auto_join'] = (int)$groupData['auto_join'];

        return $groupData;
    }

    /**
     * Returns an array that contains the right-IDs of all rights
     * the user $userId owns. User-rights and the rights the user
     * owns because of a group-membership are taken into account.
     *
     * @param  integer $userId User ID
     * @return array
     */
    public function getAllUserRights($userId)
    {
        if ($userId <= 0 || !is_numeric($userId)) {
            return false;
        }
        $userRights  = $this->getUserRights($userId);
        $groupRights = $this->getUserGroupRights($userId);

        return array_unique(array_merge($userRights, $groupRights));
    }

    /**
     * Adds the user $userId to all groups with the auto_join
     * option. By using the auto_join option, user administration
     * can be much easier. For example by setting this option only
     * for a single group called 'All Users'. The autoJoin() method
     * then has to be called every time a new user registers.
     * Returns true on success, otherwise false.
     *
     * @param  integer $userId User ID
     * @return boolean
     */
    public function autoJoin($userId)
    {
        if ($userId <= 0 || !is_numeric($userId)) {
            return false;
        }
        
        $select = sprintf("
            SELECT
                group_id
            FROM
                %sfaqgroup
            WHERE
                auto_join = 1",
            PMF_Db::getTablePrefix()
        );
            
        $res = $this->config->getDb()->query($select);
        if (!$res) {
            return false;
        }
        
        $auto_join = [];
        while ($row = $this->config->getDb()->fetchArray($res)) {
            $auto_join[] = $row['group_id'];
        }

        // add to groups
        foreach ($auto_join as $groupId) {
            $this->addToGroup($userId, $groupId);
        }
        return true;
    }

    /**
     * Removes the user $userId from all groups.
     * Returns true on success, otherwise false.
     *
     * @param  integer $userId User ID
     * @return boolean
     */
    public function removeFromAllGroups($userId)
    {
        if ($userId <= 0 || !is_numeric($userId)) {
            return false;
        }
        
        $delete = sprintf("
            DELETE FROM
                %sfaquser_group
            WHERE
                user_id  = %d",
            PMF_Db::getTablePrefix(),
            $userId);
            
        $res = $this->config->getDb()->query($delete);
        if (!$res) {
            return false;
        }
        return true;
    }

    /**
     * getUserGroupRights
     *
     * Returns an array that contains the IDs of all rights the user
     * $userId owns because of a group-membership.
     *
     * @param  integer $userId User ID
     * @return array
     */
    public function getUserGroupRights($userId)

    {
        if ($userId <= 0 || !is_numeric($userId)) {
            return false;
        }
        
        $select = sprintf("
            SELECT
                fr.right_id AS right_id
            FROM
                %sfaqright fr,
                %sfaqgroup_right fgr,
                %sfaqgroup fg,
                %sfaquser_group fug,
                %sfaquser fu
            WHERE
                fu.user_id  = %d AND
                fu.user_id  = fug.user_id AND
                fg.group_id = fug.group_id AND
                fg.group_id = fgr.group_id AND
                fr.right_id = fgr.right_id",
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            PMF_Db::getTablePrefix(),
            $userId);
        
        $res    = $this->config->getDb()->query($select);
        $result = [];
        while ($row = $this->config->getDb()->fetchArray($res)) {
            $result[] = $row['right_id'];
        }
        return $result;
    }

    /**
     * Refuses all group rights.
     * Returns true on success, otherwise false.
     *
     * @param  integer $groupId Group ID
     * @return boolean
     */
    public function refuseAllGroupRights($groupId)
    {
        if ($groupId <= 0 || !is_numeric($groupId)) {
            return false;
        }
        
        $delete = sprintf("
            DELETE FROM
                %sfaqgroup_right
            WHERE
                group_id  = %d",
            PMF_Db::getTablePrefix(),
            $groupId);
            
        $res = $this->config->getDb()->query($delete);
        if (!$res) {
            return false;
        }
        return true;
    }

    /**
     * Returns the name of the group $groupId.
     *
     * @param  integer $groupId Group ID
     * @return string
     */
    public function getGroupName($groupId)
    {
        if ($groupId <= 0 || !is_numeric($groupId)) {
            return false;
        }
        
        $select = sprintf("
            SELECT
                name
            FROM
                %sfaqgroup
            WHERE
                group_id = %d",
            PMF_Db::getTablePrefix(),
            $groupId
        );
            
        $res = $this->config->getDb()->query($select);
        if ($this->config->getDb()->numRows($res) != 1) {
            return [];
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }
        $row = $this->config->getDb()->fetchArray($res);
        return $row['name'];
    }

    /**
     * Removes all users from the group $groupId.
     * Returns true on success, otherwise false.
     *
     * @param  integer $groupId Group ID
     * @return bool
     */
    public function removeAllUsersFromGroup($groupId)
    {
        if ($groupId <= 0 or !is_numeric($groupId)) {
            return false;
        }
        
        // remove all user from group
        $delete = sprintf("
            DELETE FROM
                %sfaquser_group
            WHERE
                group_id = %d",
            PMF_Db::getTablePrefix(),
            $groupId);
            
        $res = $this->config->getDb()->query($delete);
        if (!$res) {
            return false;
        }
        return true;
    }
}
thorsten / phpMyFAQ

GitHub Access Token became invalid

Pull Request — master (#1192)

PMF_Perm_Medium::refuseAllGroupRights() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
