IssuerFactory::__construct() - Code Metrics - Inspection of "Add fromWebFinger() method to the IssuerFactory" - thomasvargiu/php-openid-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fb67eb...e62745 )

by Thomas Mauro

created 2019-07-09 21:07 UTC

IssuerFactory::__construct() A

↳ Parent: IssuerFactory

Complexity

Conditions	3
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	3.576

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	4
dl	0
loc	6
ccs	3
cts	5
cp	0.6
rs	10
c	1
b	0
f	0
cc	3
nc	1
nop	2
crap	3.576

<?php

declare(strict_types=1);

namespace TMV\OpenIdClient;

use Http\Discovery\Psr17FactoryDiscovery;
use Http\Discovery\Psr18ClientDiscovery;
use Jose\Component\KeyManagement\JKUFactory;
use TMV\OpenIdClient\Model\IssuerMetadata;
use TMV\OpenIdClient\Provider\DiscoveryMetadataProvider;
use TMV\OpenIdClient\Provider\DiscoveryMetadataProviderInterface;

class IssuerFactory
{
    /** @var DiscoveryMetadataProviderInterface */
    private $discovery;

    /** @var JKUFactory */
    private $JKUFactory;

    /**
     * IssuerFactory constructor.
     *
     * @param null|DiscoveryMetadataProviderInterface $discovery
     * @param null|JKUFactory $JKUFactory
     */
    public function __construct(?DiscoveryMetadataProviderInterface $discovery = null, ?JKUFactory $JKUFactory = null)
    {
        $this->discovery = $discovery ?: new DiscoveryMetadataProvider();
        $this->JKUFactory = $JKUFactory ?: new JKUFactory(
            Psr18ClientDiscovery::find(),
            Psr17FactoryDiscovery::findRequestFactory()
        );
    }

    public function fromUri(string $uri): IssuerInterface
    {
        $metadata = IssuerMetadata::fromClaims($this->discovery->discovery($uri));
        $jwks = $this->JKUFactory->loadFromUrl($metadata->getJwksUri());

        return new Issuer($metadata, $jwks);
    }

    public function fromWebFinger(string $resource): IssuerInterface
    {
        $metadata = IssuerMetadata::fromClaims($this->discovery->webfinger($resource));
        $jwks = $this->JKUFactory->loadFromUrl($metadata->getJwksUri());

        return new Issuer($metadata, $jwks);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace TMV\OpenIdClient;
6
7		use Http\Discovery\Psr17FactoryDiscovery;
8		use Http\Discovery\Psr18ClientDiscovery;
9		use Jose\Component\KeyManagement\JKUFactory;
10		use TMV\OpenIdClient\Model\IssuerMetadata;
11		use TMV\OpenIdClient\Provider\DiscoveryMetadataProvider;
12		use TMV\OpenIdClient\Provider\DiscoveryMetadataProviderInterface;
13
14		class IssuerFactory
15		{
16		/** @var DiscoveryMetadataProviderInterface */
17		private $discovery;
18
19		/** @var JKUFactory */
20		private $JKUFactory;
21
22		/**
23		* IssuerFactory constructor.
24		*
25		* @param null\|DiscoveryMetadataProviderInterface $discovery
26		* @param null\|JKUFactory $JKUFactory
27		*/
28	2	public function __construct(?DiscoveryMetadataProviderInterface $discovery = null, ?JKUFactory $JKUFactory = null)
29		{
30	2	$this->discovery = $discovery ?: new DiscoveryMetadataProvider();
31	2	$this->JKUFactory = $JKUFactory ?: new JKUFactory(
32		Psr18ClientDiscovery::find(),
33		Psr17FactoryDiscovery::findRequestFactory()
34		);
35	2	}
36
37	1	public function fromUri(string $uri): IssuerInterface
38		{
39	1	$metadata = IssuerMetadata::fromClaims($this->discovery->discovery($uri));
40	1	$jwks = $this->JKUFactory->loadFromUrl($metadata->getJwksUri());
41
42	1	return new Issuer($metadata, $jwks);
43		}
44
45	1	public function fromWebFinger(string $resource): IssuerInterface
46		{
47	1	$metadata = IssuerMetadata::fromClaims($this->discovery->webfinger($resource));
48	1	$jwks = $this->JKUFactory->loadFromUrl($metadata->getJwksUri());
49
50	1	return new Issuer($metadata, $jwks);
51		}
52		}
53

thomasvargiu / php-openid-client

Push — master ( fb67eb...e62745 )

IssuerFactory::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like