checkServerResponse() - Code Metrics - Inspection of "New implementation" - thomasvargiu/php-openid-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 898cc7...450add )

by Thomas Mauro

created 2019-07-08 11:59 UTC

checkServerResponse() A

↳ Parent: Project

Complexity

Conditions	5
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	5.3906

Importance

Changes

Metric	Value
eloc	4
c	0
b	0
f	0
dl	0
loc	8
ccs	3
cts	4
cp	0.75
rs	9.6111
cc	5
nc	3
nop	2
crap	5.3906

<?php

declare(strict_types=1);

namespace TMV\OpenIdClient;

use Psr\Http\Message\ResponseInterface;
use TMV\OpenIdClient\Exception\OAuth2Exception;

/**
 * @param ResponseInterface $response
 * @param int|null $expectedCode
 */
function check_server_response(ResponseInterface $response, ?int $expectedCode = null): void
{
    if (! $expectedCode && $response->getStatusCode() >= 400) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
        throw OAuth2Exception::fromResponse($response);
    }

    if ($expectedCode && $expectedCode !== $response->getStatusCode()) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
        throw OAuth2Exception::fromResponse($response);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace TMV\OpenIdClient;
6
7		use Psr\Http\Message\ResponseInterface;
8		use TMV\OpenIdClient\Exception\OAuth2Exception;
9
10		/**
11		* @param ResponseInterface $response
12		* @param int\|null $expectedCode
13		*/
14		function check_server_response(ResponseInterface $response, ?int $expectedCode = null): void
15		{
16	11	if (! $expectedCode && $response->getStatusCode() >= 400) {
		0 ignored issues – show Bug Best Practice introduced 2019-07-04 16:00 UTC by Report Bug Copy Issue Report The expression `$expectedCode` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be 0. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
17	4	throw OAuth2Exception::fromResponse($response);
18		}
19
20	7	if ($expectedCode && $expectedCode !== $response->getStatusCode()) {
		0 ignored issues – show Bug Best Practice introduced 2019-07-04 16:00 UTC by Report Bug Copy Issue Report The expression `$expectedCode` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be 0. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
21		throw OAuth2Exception::fromResponse($response);
22		}
23		}
24

thomasvargiu / php-openid-client

Push — master ( 898cc7...450add )

checkServerResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like