IssuerMetadataProvider::webfinger() - Code Metrics - Inspection of "Fixed webfinger and renamed issuer metadata provid..." - thomasvargiu/php-openid-client - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( e62745...2f64c5 )

by Thomas Mauro

created 2019-07-09 22:38 UTC

IssuerMetadataProvider::webfinger() C

↳ Parent: IssuerMetadataProvider

Complexity

Conditions	13
Paths	33

Size

Total Lines	59
Code Lines	34

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	182

Importance

Changes

Metric	Value
cc	13
eloc	34
nc	33
nop	1
dl	0
loc	59
ccs	0
cts	34
cp	0
crap	182
rs	6.6166
c	0
b	0
f	0

How to fix Long Method Complexity

<?php

declare(strict_types=1);

namespace TMV\OpenIdClient\Provider;

use Http\Discovery\Psr17FactoryDiscovery;
use Http\Discovery\Psr18ClientDiscovery;
use Psr\Http\Client\ClientExceptionInterface;
use Psr\Http\Client\ClientInterface;
use Psr\Http\Message\RequestFactoryInterface;
use Psr\Http\Message\UriFactoryInterface;
use TMV\OpenIdClient\Exception\InvalidArgumentException;
use TMV\OpenIdClient\Exception\RuntimeException;
use function TMV\OpenIdClient\normalize_webfinger;
use function TMV\OpenIdClient\parse_metadata_response;

class IssuerMetadataProvider implements IssuerMetadataProviderInterface
{
    private const OIDC_DISCOVERY = '/.well-known/openid-configuration';

    private const OAUTH2_DISCOVERY = '/.well-known/oauth-authorization-server';

    private const WEBFINGER = '/.well-known/webfinger';

    private const REL = 'http://openid.net/specs/connect/1.0/issuer';

    private const AAD_MULTITENANT_DISCOVERY = 'https://login.microsoftonline.com/common/v2.0$' . self::OIDC_DISCOVERY;

    /** @var ClientInterface */
    private $client;

    /** @var RequestFactoryInterface */
    private $requestFactory;

    /** @var UriFactoryInterface */
    private $uriFactory;

    public function __construct(
        ?ClientInterface $client = null,
        ?RequestFactoryInterface $requestFactory = null,
        ?UriFactoryInterface $uriFactory = null
    ) {
        $this->client = $client ?: Psr18ClientDiscovery::find();
        $this->requestFactory = $requestFactory ?: Psr17FactoryDiscovery::findRequestFactory();
        $this->uriFactory = $uriFactory ?: Psr17FactoryDiscovery::findUrlFactory();
    }

    public function webfinger(string $resource): array
    {
        $resource = normalize_webfinger($resource);
        $parsedUrl = \parse_url(
            false !== \strpos($resource, '@')
                ? 'https://' . \explode('@', $resource)[1]
                : $resource
        );

        if (! \is_array($parsedUrl) || ! \array_key_exists('host', $parsedUrl)) {

            throw new RuntimeException('Unable to parse resource');
        }

        $host = $parsedUrl['host'];
        if ($port = ($parsedUrl['port'] ?? null)) {
            $host .= ':' . $port;
        }

        $webFingerUrl = $this->uriFactory->createUri('https://' . $host . self::WEBFINGER)
            ->withQuery(\http_build_query(['resource' => $resource, 'rel' => self::REL]));

        $request = $this->requestFactory->createRequest('GET', $webFingerUrl)
            ->withHeader('accept', 'application/json');

        try {
            $data = parse_metadata_response($this->client->sendRequest($request));
        } catch (ClientExceptionInterface $e) {
            throw new RuntimeException('Unable to fetch provider metadata', 0, $e);
        }

        $links = $data['links'] ?? [];
        $href = null;
        foreach ($links as $link) {
            if (! \is_array($link)) {
                continue;
            }

            if (($link['rel'] ?? null) !== self::REL) {
                continue;
            }

            if (! \array_key_exists('href', $link)) {
                continue;
            }

            $href = $link['href'];
        }

        if (! \is_string($href) || 0 !== \strpos($href, 'https://')) {
            throw new InvalidArgumentException('Invalid issuer location');
        }

        $metadata = $this->discovery($href);

        if ($metadata['issuer'] !== $href) {
            throw new RuntimeException('Discovered issuer mismatch');
        }

        return $metadata;
    }

    public function discovery(string $url): array
    {
        $uri = $this->uriFactory->createUri($url);
        $uriPath = $uri->getPath() ?: '/';

        if (false !== \strpos($uriPath, '/.well-known/')) {
            return $this->fetchOpenIdConfiguration((string) $uri);
        }

        $uris = [
            $uri->withPath(\rtrim($uriPath, '/') . self::OIDC_DISCOVERY),
            $uri->withPath('/' === $uriPath
                ? self::OAUTH2_DISCOVERY
                : self::OAUTH2_DISCOVERY . $uriPath),
        ];

        foreach ($uris as $wellKnownUri) {
            try {
                return $this->fetchOpenIdConfiguration((string) $wellKnownUri);
            } catch (RuntimeException $e) {

            }
        }

        throw new RuntimeException('Unable to fetch provider metadata');
    }

    private function fetchOpenIdConfiguration(string $uri): array
    {
        $request = $this->requestFactory->createRequest('GET', $uri)
            ->withHeader('accept', 'application/json');

        try {
            $data = parse_metadata_response($this->client->sendRequest($request));
        } catch (ClientExceptionInterface $e) {
            throw new RuntimeException('Unable to fetch provider metadata', 0, $e);
        }

        if (! \array_key_exists('issuer', $data)) {
            throw new RuntimeException('Invalid metadata content, no "issuer" key found');
        }

        return $data;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace TMV\OpenIdClient\Provider;
6
7		use Http\Discovery\Psr17FactoryDiscovery;
8		use Http\Discovery\Psr18ClientDiscovery;
9		use Psr\Http\Client\ClientExceptionInterface;
10		use Psr\Http\Client\ClientInterface;
11		use Psr\Http\Message\RequestFactoryInterface;
12		use Psr\Http\Message\UriFactoryInterface;
13		use TMV\OpenIdClient\Exception\InvalidArgumentException;
14		use TMV\OpenIdClient\Exception\RuntimeException;
15		use function TMV\OpenIdClient\normalize_webfinger;
16		use function TMV\OpenIdClient\parse_metadata_response;
17
18		class IssuerMetadataProvider implements IssuerMetadataProviderInterface
19		{
20		private const OIDC_DISCOVERY = '/.well-known/openid-configuration';
21
22		private const OAUTH2_DISCOVERY = '/.well-known/oauth-authorization-server';
23
24		private const WEBFINGER = '/.well-known/webfinger';
25
26		private const REL = 'http://openid.net/specs/connect/1.0/issuer';
27
28		private const AAD_MULTITENANT_DISCOVERY = 'https://login.microsoftonline.com/common/v2.0$' . self::OIDC_DISCOVERY;
29
30		/** @var ClientInterface */
31		private $client;
32
33		/** @var RequestFactoryInterface */
34		private $requestFactory;
35
36		/** @var UriFactoryInterface */
37		private $uriFactory;
38
39	2	public function __construct(
40		?ClientInterface $client = null,
41		?RequestFactoryInterface $requestFactory = null,
42		?UriFactoryInterface $uriFactory = null
43		) {
44	2	$this->client = $client ?: Psr18ClientDiscovery::find();
45	2	$this->requestFactory = $requestFactory ?: Psr17FactoryDiscovery::findRequestFactory();
46	2	$this->uriFactory = $uriFactory ?: Psr17FactoryDiscovery::findUrlFactory();
47	2	}
48
49		public function webfinger(string $resource): array
50		{
51		$resource = normalize_webfinger($resource);
52		$parsedUrl = \parse_url(
53		false !== \strpos($resource, '@')
54		? 'https://' . \explode('@', $resource)[1]
55		: $resource
56		);
57
58		if (! \is_array($parsedUrl) \|\| ! \array_key_exists('host', $parsedUrl)) {
		0 ignored issues – show introduced 2019-07-09 22:41 UTC by Report Bug Copy Issue Report The condition `is_array($parsedUrl)` is always `true`. Loading history...
59		throw new RuntimeException('Unable to parse resource');
60		}
61
62		$host = $parsedUrl['host'];
63		if ($port = ($parsedUrl['port'] ?? null)) {
64		$host .= ':' . $port;
65		}
66
67		$webFingerUrl = $this->uriFactory->createUri('https://' . $host . self::WEBFINGER)
68		->withQuery(\http_build_query(['resource' => $resource, 'rel' => self::REL]));
69
70		$request = $this->requestFactory->createRequest('GET', $webFingerUrl)
71		->withHeader('accept', 'application/json');
72
73		try {
74		$data = parse_metadata_response($this->client->sendRequest($request));
75		} catch (ClientExceptionInterface $e) {
76		throw new RuntimeException('Unable to fetch provider metadata', 0, $e);
77		}
78
79		$links = $data['links'] ?? [];
80		$href = null;
81		foreach ($links as $link) {
82		if (! \is_array($link)) {
83		continue;
84		}
85
86		if (($link['rel'] ?? null) !== self::REL) {
87		continue;
88		}
89
90		if (! \array_key_exists('href', $link)) {
91		continue;
92		}
93
94		$href = $link['href'];
95		}
96
97		if (! \is_string($href) \|\| 0 !== \strpos($href, 'https://')) {
98		throw new InvalidArgumentException('Invalid issuer location');
99		}
100
101		$metadata = $this->discovery($href);
102
103		if ($metadata['issuer'] !== $href) {
104		throw new RuntimeException('Discovered issuer mismatch');
105		}
106
107		return $metadata;
108		}
109
110	2	public function discovery(string $url): array
111		{
112	2	$uri = $this->uriFactory->createUri($url);
113	2	$uriPath = $uri->getPath() ?: '/';
114
115	2	if (false !== \strpos($uriPath, '/.well-known/')) {
116	1	return $this->fetchOpenIdConfiguration((string) $uri);
117		}
118
119		$uris = [
120	1	$uri->withPath(\rtrim($uriPath, '/') . self::OIDC_DISCOVERY),
121	1	$uri->withPath('/' === $uriPath
122	1	? self::OAUTH2_DISCOVERY
123	1	: self::OAUTH2_DISCOVERY . $uriPath),
124		];
125
126	1	foreach ($uris as $wellKnownUri) {
127		try {
128	1	return $this->fetchOpenIdConfiguration((string) $wellKnownUri);
129		} catch (RuntimeException $e) {
		0 ignored issues – show Coding Style Comprehensibility introduced 2019-07-08 12:02 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
130		}
131		}
132
133		throw new RuntimeException('Unable to fetch provider metadata');
134		}
135
136	2	private function fetchOpenIdConfiguration(string $uri): array
137		{
138	2	$request = $this->requestFactory->createRequest('GET', $uri)
139	2	->withHeader('accept', 'application/json');
140
141		try {
142	2	$data = parse_metadata_response($this->client->sendRequest($request));
143		} catch (ClientExceptionInterface $e) {
144		throw new RuntimeException('Unable to fetch provider metadata', 0, $e);
145		}
146
147	2	if (! \array_key_exists('issuer', $data)) {
148		throw new RuntimeException('Invalid metadata content, no "issuer" key found');
149		}
150
151	2	return $data;
152		}
153		}
154

thomasvargiu / php-openid-client

Push — master ( e62745...2f64c5 )

IssuerMetadataProvider::webfinger() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like