ConsumerCallback::__invoke() - Code Metrics - Inspection of "v0.2.0" - thomasvargiu/AMQPAL - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4cd93a...e8f4ec )

by Thomas Mauro

created 2016-03-26 14:18 UTC

ConsumerCallback::__invoke() A

↳ Parent: ConsumerCallback

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0185

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	9
ccs	5
cts	6
cp	0.8333
rs	9.6666
cc	2
eloc	6
nc	2
nop	1
crap	2.0185

<?php

namespace AMQPAL\Adapter\PhpAmqpLib;

use PhpAmqpLib\Message\AMQPMessage;

class ConsumerCallback
{
    /**
     * @var callable
     */
    protected $callback;
    /**
     * @var Queue
     */
    protected $queue;
    /**
     * @var MessageMapper
     */
    protected $messageMapper;

    /**
     * ConsumerCallback constructor.
     *
     * @param callable $callback
     * @param Queue    $queue
     */
    public function __construct(callable $callback, Queue $queue)
    {
        $this->callback = $callback;
        $this->queue = $queue;
    }

    /**
     * @param AMQPMessage $message
     * @return mixed
     * @throws \OutOfBoundsException
     */
    public function __invoke(AMQPMessage $message)
    {
        $convertedMessage = $this->getMessageMapper()->toMessage($message);
        $ret = call_user_func($this->callback, $convertedMessage, $this->queue);
        if (false === $ret) {
            $this->queue->cancel($message->delivery_info['consumer_tag']);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        return $ret;
    }

    /**
     * @return MessageMapper
     */
    public function getMessageMapper()
    {
        if (!$this->messageMapper) {
            $this->messageMapper = new MessageMapper();
        }
        return $this->messageMapper;
    }

    /**
     * @param MessageMapper $messageMapper
     * @return $this
     */
    public function setMessageMapper($messageMapper)
    {
        $this->messageMapper = $messageMapper;
        return $this;
    }
}


1		<?php
2
3		namespace AMQPAL\Adapter\PhpAmqpLib;
4
5		use PhpAmqpLib\Message\AMQPMessage;
6
7		class ConsumerCallback
8		{
9		/**
10		* @var callable
11		*/
12		protected $callback;
13		/**
14		* @var Queue
15		*/
16		protected $queue;
17		/**
18		* @var MessageMapper
19		*/
20		protected $messageMapper;
21
22		/**
23		* ConsumerCallback constructor.
24		*
25		* @param callable $callback
26		* @param Queue $queue
27		*/
28	5	public function __construct(callable $callback, Queue $queue)
29		{
30	5	$this->callback = $callback;
31	5	$this->queue = $queue;
32	5	}
33
34		/**
35		* @param AMQPMessage $message
36		* @return mixed
37		* @throws \OutOfBoundsException
38		*/
39	1	public function __invoke(AMQPMessage $message)
40		{
41	1	$convertedMessage = $this->getMessageMapper()->toMessage($message);
42	1	$ret = call_user_func($this->callback, $convertedMessage, $this->queue);
43	1	if (false === $ret) {
44		$this->queue->cancel($message->delivery_info['consumer_tag']);
		0 ignored issues – show Documentation introduced 2016-03-26 14:28 UTC by Report Bug Copy Issue Report `$message->delivery_info['consumer_tag']` is of type `object<PhpAmqpLib\Channel\AMQPChannel>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45		}
46	1	return $ret;
47		}
48
49		/**
50		* @return MessageMapper
51		*/
52	2	public function getMessageMapper()
53		{
54	2	if (!$this->messageMapper) {
55	1	$this->messageMapper = new MessageMapper();
56		}
57	2	return $this->messageMapper;
58		}
59
60		/**
61		* @param MessageMapper $messageMapper
62		* @return $this
63		*/
64	5	public function setMessageMapper($messageMapper)
65		{
66	5	$this->messageMapper = $messageMapper;
67	5	return $this;
68		}
69		}
70

thomasvargiu / AMQPAL

Push — master ( 4cd93a...e8f4ec )

ConsumerCallback::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like