UriParameters::replace() - Code Metrics - Inspection of "changed scrutinizer code coverage check" - thinktomorrow/locale - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — 2.0 (72e182)

by Philippe

created 2018-02-12 08:21 UTC

UriParameters::replace() A

↳ Parent: UriParameters

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	2
dl	0
loc	9
ccs	5
cts	5
cp	1
crap	1
rs	9.6666
c	0
b	0
f	0

<?php

namespace Thinktomorrow\Locale\Parsers;

use Illuminate\Support\Arr;
use Illuminate\Support\Str;

class UriParameters
{
    /**
     * Replace route parameters.
     *
     * @param $uri
     * @param array $parameters
     * @return mixed|string
     */
    public static function replace($uri, $parameters = [])
    {
        $parameters = (array) $parameters;

        $uri = static::replaceRouteParameters($uri, $parameters);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        $uri = str_replace('//', '/', $uri);

        return $uri;
    }

    /**
     * Replace all of the wildcard parameters for a route path.
     *
     * @note: based on the Illuminate\Routing\UrlGenerator code
     *
     * @param string $path
     * @param array  $parameters
     *
     * @return string
     */
    private static function replaceRouteParameters($path, array $parameters)
    {
        $path = static::replaceNamedParameters($path, $parameters);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

        $path = preg_replace_callback('/\{.*?\}/', function ($match) use (&$parameters) {
            return (empty($parameters) && !Str::endsWith($match[0], '?}'))
                ? $match[0]
                : array_shift($parameters);
        }, $path);

        return trim(preg_replace('/\{.*?\?\}/', '', $path), '/');
    }

    /**
     * Replace all of the named parameters in the path.
     *
     * @note: based on the Illuminate\Routing\UrlGenerator code
     *
     * @param string $path
     * @param array  $parameters
     *
     * @return string
     */
    private static function replaceNamedParameters($path, &$parameters)
    {
        return preg_replace_callback('/\{(.*?)\??\}/', function ($m) use (&$parameters) {
            return isset($parameters[$m[1]]) ? Arr::pull($parameters, $m[1]) : $m[0];
        }, $path);
    }
}

1		<?php
2
3		namespace Thinktomorrow\Locale\Parsers;
4
5		use Illuminate\Support\Arr;
6		use Illuminate\Support\Str;
7
8		class UriParameters
9		{
10		/**
11		* Replace route parameters.
12		*
13		* @param $uri
14		* @param array $parameters
15		* @return mixed\|string
16		*/
17	7	public static function replace($uri, $parameters = [])
18		{
19	7	$parameters = (array) $parameters;
20
21	7	$uri = static::replaceRouteParameters($uri, $parameters);
		0 ignored issues – show Bug introduced 2018-02-12 08:23 UTC by Report Bug Copy Issue Report Since `replaceRouteParameters()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `replaceRouteParameters()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
22	7	$uri = str_replace('//', '/', $uri);
23
24	7	return $uri;
25		}
26
27		/**
28		* Replace all of the wildcard parameters for a route path.
29		*
30		* @note: based on the Illuminate\Routing\UrlGenerator code
31		*
32		* @param string $path
33		* @param array $parameters
34		*
35		* @return string
36		*/
37	7	private static function replaceRouteParameters($path, array $parameters)
38		{
39	7	$path = static::replaceNamedParameters($path, $parameters);
		0 ignored issues – show Bug introduced 2018-02-12 08:23 UTC by Report Bug Copy Issue Report Since `replaceNamedParameters()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `replaceNamedParameters()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
40
41	7	$path = preg_replace_callback('/\{.*?\}/', function ($match) use (&$parameters) {
42	4	return (empty($parameters) && !Str::endsWith($match[0], '?}'))
43	1	? $match[0]
44	4	: array_shift($parameters);
45	7	}, $path);
46
47	7	return trim(preg_replace('/\{.*?\?\}/', '', $path), '/');
48		}
49
50		/**
51		* Replace all of the named parameters in the path.
52		*
53		* @note: based on the Illuminate\Routing\UrlGenerator code
54		*
55		* @param string $path
56		* @param array $parameters
57		*
58		* @return string
59		*/
60		private static function replaceNamedParameters($path, &$parameters)
61		{
62	7	return preg_replace_callback('/\{(.*?)\??\}/', function ($m) use (&$parameters) {
63	7	return isset($parameters[$m[1]]) ? Arr::pull($parameters, $m[1]) : $m[0];
64	7	}, $path);
65		}
66		}

thinktomorrow / locale

Branch — 2.0 (72e182)

UriParameters::replace() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like