HiddenSegmentDetector::get() - Code Metrics - Inspection of "Bump phpunit/phpunit from 8.5.8 to 9.5.0" - thinktomorrow/locale - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#122)

unknown

created 2020-12-07 05:41 UTC

HiddenSegmentDetector::get() A

↳ Parent: HiddenSegmentDetector

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
cc	2
nc	2
nop	2
dl	0
loc	12
ccs	0
cts	4
cp	0
crap	6
rs	9.8666
c	0
b	0
f	0

<?php

namespace Thinktomorrow\Locale\Detectors;

use Illuminate\Http\Request;
use Thinktomorrow\Locale\Scope;
use Thinktomorrow\Locale\Values\Config;
use Thinktomorrow\Locale\Values\Locale;

class HiddenSegmentDetector implements Detector
{
    /**
     * @var Request
     */
    private $request;

    public function __construct(Request $request)

    {
        $this->request = $request;
    }

    public function get(Scope $scope, Config $config): ?Locale
    {
        // If a locale segment is found, it means locale is not hidden so we won't bother going further.
        if ($this->segment($scope)) {
            return null;
        }

        // At this point if no locale segment is given and if in config the hidden_locale is set,
        // we assume the locale is hidden.
        // TODO account for domain specific hidden (default) locales
        return $scope->defaultLocale();
    }

    public function segment(Scope $scope): ?Locale
    {
        $segment = $this->request->segment(1);

        return $scope->findLocale($segment);
    }
}


1			<?php
2
3			namespace Thinktomorrow\Locale\Detectors;
4
5			use Illuminate\Http\Request;
6			use Thinktomorrow\Locale\Scope;
7			use Thinktomorrow\Locale\Values\Config;
8			use Thinktomorrow\Locale\Values\Locale;
9
10			class HiddenSegmentDetector implements Detector
11			{
12			/**
13			* @var Request
14			*/
15			private $request;
16
17			public function __construct(Request $request)
			0 ignored issues – show Bug introduced 2018-02-12 08:23 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
18			{
19			$this->request = $request;
20			}
21
22			public function get(Scope $scope, Config $config): ?Locale
23			{
24			// If a locale segment is found, it means locale is not hidden so we won't bother going further.
25			if ($this->segment($scope)) {
26			return null;
27			}
28
29			// At this point if no locale segment is given and if in config the hidden_locale is set,
30			// we assume the locale is hidden.
31			// TODO account for domain specific hidden (default) locales
32			return $scope->defaultLocale();
33			}
34
35			public function segment(Scope $scope): ?Locale
36			{
37			$segment = $this->request->segment(1);
38
39			return $scope->findLocale($segment);
40			}
41			}
42

thinktomorrow / locale

Pull Request — master (#122)

HiddenSegmentDetector::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like