HiddenSegmentDetector::get() - Code Metrics - Inspection of "Merge pull request #7 from thinktomorrow/2.0" - thinktomorrow/locale - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0eceaa...aee3a6 )

by Ben

created 2018-04-19 07:02 UTC

HiddenSegmentDetector::get() A

↳ Parent: HiddenSegmentDetector

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	2
dl	0
loc	12
ccs	4
cts	4
cp	1
crap	2
rs	9.4285
c	0
b	0
f	0

<?php

namespace Thinktomorrow\Locale\Detectors;

use Illuminate\Http\Request;
use Thinktomorrow\Locale\Scope;
use Thinktomorrow\Locale\Values\Config;
use Thinktomorrow\Locale\Values\Locale;

class HiddenSegmentDetector implements Detector
{
    /**
     * @var Request
     */
    private $request;

    public function __construct(Request $request)

    {
        $this->request = $request;
    }

    public function get(Scope $scope, Config $config): ?Locale
    {
        // If a locale segment is found, it means locale is not hidden so we won't bother going further.
        if ($this->segment($scope)) {
            return null;
        }

        // At this point if no locale segment is given and if in config the hidden_locale is set,
        // we assume the locale is hidden.
        // TODO account for domain specific hidden (default) locales
        return $scope->defaultLocale();
    }

    public function segment(Scope $scope): ?Locale
    {
        $segment = $this->request->segment(1);

        return $scope->findLocale($segment);
    }
}


1		<?php
2
3		namespace Thinktomorrow\Locale\Detectors;
4
5		use Illuminate\Http\Request;
6		use Thinktomorrow\Locale\Scope;
7		use Thinktomorrow\Locale\Values\Config;
8		use Thinktomorrow\Locale\Values\Locale;
9
10		class HiddenSegmentDetector implements Detector
11		{
12		/**
13		* @var Request
14		*/
15		private $request;
16
17	64	public function __construct(Request $request)
		0 ignored issues – show Bug introduced 2018-02-12 08:23 UTC by Report Bug Copy Issue Report You have injected the Request via parameter `$request`. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via `getCurrentRequest()`. Loading history...
18		{
19	64	$this->request = $request;
20	64	}
21
22	64	public function get(Scope $scope, Config $config): ?Locale
23		{
24		// If a locale segment is found, it means locale is not hidden so we won't bother going further.
25	64	if ($this->segment($scope)) {
26	11	return null;
27		}
28
29		// At this point if no locale segment is given and if in config the hidden_locale is set,
30		// we assume the locale is hidden.
31		// TODO account for domain specific hidden (default) locales
32	59	return $scope->defaultLocale();
33		}
34
35	64	public function segment(Scope $scope): ?Locale
36		{
37	64	$segment = $this->request->segment(1);
38
39	64	return $scope->findLocale($segment);
40		}
41		}
42

thinktomorrow / locale

Push — master ( 0eceaa...aee3a6 )

HiddenSegmentDetector::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like