UriParameters - Code Metrics - Inspection of "Merge pull request #7 from thinktomorrow/2.0" - thinktomorrow/locale - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0eceaa...aee3a6 )

by Ben

created 2018-04-19 07:02 UTC

UriParameters A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
dl	0
loc	60
ccs	16
cts	16
cp	1
rs	10
c	0
b	0
f	0
wmc	6
lcom	0
cbo	2

3 Methods

Rating	Name	Size	Complexity
A	replace()	9	1
A	replaceRouteParameters()	12	3
A	replaceNamedParameters()	6	2

<?php

namespace Thinktomorrow\Locale\Parsers;

use Illuminate\Support\Arr;
use Illuminate\Support\Str;

class UriParameters
{
    /**
     * Replace route parameters.
     *
     * @param $uri
     * @param array $parameters
     *
     * @return mixed|string
     */
    public static function replace($uri, $parameters = [])
    {
        $parameters = (array) $parameters;

        $uri = static::replaceRouteParameters($uri, $parameters);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}
        $uri = str_replace('//', '/', $uri);

        return $uri;
    }

    /**
     * Replace all of the wildcard parameters for a route path.
     *
     * @note: taken from the Illuminate\Routing\UrlGenerator code
     *
     * @param string $path
     * @param array  $parameters
     *
     * @return string
     */
    private static function replaceRouteParameters($path, array $parameters)
    {
        $path = static::replaceNamedParameters($path, $parameters);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

        $path = preg_replace_callback('/\{.*?\}/', function ($match) use (&$parameters) {
            return (empty($parameters) && !Str::endsWith($match[0], '?}'))
                ? $match[0]
                : array_shift($parameters);
        }, $path);

        return trim(preg_replace('/\{.*?\?\}/', '', $path), '/');
    }

    /**
     * Replace all of the named parameters in the path.
     *
     * @note: taken from the Illuminate\Routing\UrlGenerator code
     *
     * @param string $path
     * @param array  $parameters
     *
     * @return string
     */
    private static function replaceNamedParameters($path, &$parameters)
    {
        return preg_replace_callback('/\{(.*?)\??\}/', function ($m) use (&$parameters) {
            return isset($parameters[$m[1]]) ? Arr::pull($parameters, $m[1]) : $m[0];
        }, $path);
    }
}


1		<?php
2
3		namespace Thinktomorrow\Locale\Parsers;
4
5		use Illuminate\Support\Arr;
6		use Illuminate\Support\Str;
7
8		class UriParameters
9		{
10		/**
11		* Replace route parameters.
12		*
13		* @param $uri
14		* @param array $parameters
15		*
16		* @return mixed\|string
17		*/
18	4	public static function replace($uri, $parameters = [])
19		{
20	4	$parameters = (array) $parameters;
21
22	4	$uri = static::replaceRouteParameters($uri, $parameters);
		0 ignored issues – show Bug introduced 2018-02-12 08:23 UTC by Report Bug Copy Issue Report Since `replaceRouteParameters()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `replaceRouteParameters()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
23	4	$uri = str_replace('//', '/', $uri);
24
25	4	return $uri;
26		}
27
28		/**
29		* Replace all of the wildcard parameters for a route path.
30		*
31		* @note: taken from the Illuminate\Routing\UrlGenerator code
32		*
33		* @param string $path
34		* @param array $parameters
35		*
36		* @return string
37		*/
38	4	private static function replaceRouteParameters($path, array $parameters)
39		{
40	4	$path = static::replaceNamedParameters($path, $parameters);
		0 ignored issues – show Bug introduced 2018-02-12 08:23 UTC by Report Bug Copy Issue Report Since `replaceNamedParameters()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `replaceNamedParameters()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
41
42	4	$path = preg_replace_callback('/\{.*?\}/', function ($match) use (&$parameters) {
43	3	return (empty($parameters) && !Str::endsWith($match[0], '?}'))
44	1	? $match[0]
45	3	: array_shift($parameters);
46	4	}, $path);
47
48	4	return trim(preg_replace('/\{.*?\?\}/', '', $path), '/');
49		}
50
51		/**
52		* Replace all of the named parameters in the path.
53		*
54		* @note: taken from the Illuminate\Routing\UrlGenerator code
55		*
56		* @param string $path
57		* @param array $parameters
58		*
59		* @return string
60		*/
61		private static function replaceNamedParameters($path, &$parameters)
62		{
63	4	return preg_replace_callback('/\{(.*?)\??\}/', function ($m) use (&$parameters) {
64	4	return isset($parameters[$m[1]]) ? Arr::pull($parameters, $m[1]) : $m[0];
65	4	}, $path);
66		}
67		}
68

thinktomorrow / locale

Push — master ( 0eceaa...aee3a6 )

UriParameters A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

3 Methods

Duplication Side-by-Side

Filter issues like