UrlParser::delocalizePath() - Code Metrics - Inspection of "Remove wip domainlogic; code coverage" - thinktomorrow/locale - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d4ac13...53915c )

by Ben

created 2016-11-28 20:17 UTC

UrlParser::delocalizePath() B

↳ Parent: UrlParser

Complexity

Conditions	5
Paths	4

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	9
CRAP Score	5

Importance

Changes

Metric	Value
cc	5
eloc	8
nc	4
nop	0
dl	0
loc	16
ccs	9
cts	9
cp	1
crap	5
rs	8.8571
c	0
b	0
f	0

<?php

namespace Thinktomorrow\Locale\Parsers;

use Thinktomorrow\Locale\Locale;

class UrlParser
{
    /**
     * @var Locale
     */
    private $locale;

    /**
     * @var array
     */
    private $parsed;

    private $schemeless = false;

    public function __construct(Locale $locale)
    {
        $this->locale = $locale;
    }

    public function set($url)
    {
        $this->parsed = parse_url($url);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}

        if(false === $this->parsed)
        {
            throw new \InvalidArgumentException('Failed to parse url. Invalid url ['.$url.'] passed as parameter.');
        }

        // If a schemeless url is passed, parse_url will ignore this and strip the first tags
        // so we keep a reminder to explicitly reassemble the 'anonymous scheme' manually
        $this->schemeless = (0 === strpos($url,'//') && isset($this->parsed['host']));

        return $this;
    }

    public function get()
    {
        $this->assertUrlExists();

        return $this->reassemble($this->parsed);
    }

    /**
     * Place locale segment in front of url path
     * e.g. /foo/bar is transformed into /en/foo/bar
     *
     * @param null $locale
     * @return string
     */
    public function localize($locale = null)
    {
        $this->localizePath($locale);

        return $this;
    }

    private function localizePath($locale = null)
    {
        $this->assertUrlExists();

        $this->parsed['path'] = str_replace('//','/',
            '/'.$this->locale->getSlug($locale).$this->delocalizePath()
        );
    }

    /**
     * @return array
     */
    private function delocalizePath()
    {
        $this->assertUrlExists();

        if (!isset($this->parsed['path'])) return null;

        $path_segments = explode('/', trim($this->parsed['path'], '/'));

        if (count($path_segments) < 1) return null;

        if ($path_segments[0] == $this->locale->getSlug($path_segments[0]) || $this->locale->isHidden($path_segments[0])) {
            unset($path_segments[0]);
        }

        return '/' . implode('/', $path_segments);
    }

    /**
     * Construct a full url with the parsed url elements
     * resulted from a parse_url() function call
     *
     * @param array $parsed
     * @return string
     */
    private function reassemble(array $parsed)
    {
        return
            ((isset($parsed['scheme'])) ? $parsed['scheme'] . '://' : ($this->schemeless ? '//' : ''))
            .((isset($parsed['user'])) ? $parsed['user'] . ((isset($parsed['pass'])) ? ':' . $parsed['pass'] : '') .'@' : '')
            .((isset($parsed['host'])) ? $parsed['host'] : '')
            .((isset($parsed['port'])) ? ':' . $parsed['port'] : '')
            .((isset($parsed['path'])) ? $parsed['path'] : '')
            .((isset($parsed['query'])) ? '?' . $parsed['query'] : '')
            .((isset($parsed['fragment'])) ? '#' . $parsed['fragment'] : '');
    }

    private function assertUrlExists()
    {
        if (!$this->parsed) {

            throw new \LogicException('Url is required. Please run UrlParser::set($url) first.');
        }
    }
}

1		<?php
2
3		namespace Thinktomorrow\Locale\Parsers;
4
5		use Thinktomorrow\Locale\Locale;
6
7		class UrlParser
8		{
9		/**
10		* @var Locale
11		*/
12		private $locale;
13
14		/**
15		* @var array
16		*/
17		private $parsed;
18
19		private $schemeless = false;
20
21	96	public function __construct(Locale $locale)
22		{
23	96	$this->locale = $locale;
24	96	}
25
26	90	public function set($url)
27		{
28	90	$this->parsed = parse_url($url);
		0 ignored issues – show Documentation Bug introduced 2016-11-27 21:03 UTC by Report Bug Copy Issue Report It seems like `parse_url($url)` can also be of type `false`. However, the property `$parsed` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
29
30	90	if(false === $this->parsed)
31	57	{
32	3	throw new \InvalidArgumentException('Failed to parse url. Invalid url ['.$url.'] passed as parameter.');
33		}
34
35		// If a schemeless url is passed, parse_url will ignore this and strip the first tags
36		// so we keep a reminder to explicitly reassemble the 'anonymous scheme' manually
37	87	$this->schemeless = (0 === strpos($url,'//') && isset($this->parsed['host']));
38
39	87	return $this;
40		}
41
42	87	public function get()
43		{
44	87	$this->assertUrlExists();
45
46	87	return $this->reassemble($this->parsed);
47		}
48
49		/**
50		* Place locale segment in front of url path
51		* e.g. /foo/bar is transformed into /en/foo/bar
52		*
53		* @param null $locale
54		* @return string
55		*/
56	87	public function localize($locale = null)
57		{
58	87	$this->localizePath($locale);
59
60	84	return $this;
61		}
62
63	87	private function localizePath($locale = null)
64		{
65	87	$this->assertUrlExists();
66
67	84	$this->parsed['path'] = str_replace('//','/',
68	84	'/'.$this->locale->getSlug($locale).$this->delocalizePath()
69	53	);
70	84	}
71
72		/**
73		* @return array
74		*/
75	84	private function delocalizePath()
76		{
77	84	$this->assertUrlExists();
78
79	84	if (!isset($this->parsed['path'])) return null;
80
81	84	$path_segments = explode('/', trim($this->parsed['path'], '/'));
82
83	84	if (count($path_segments) < 1) return null;
84
85	84	if ($path_segments[0] == $this->locale->getSlug($path_segments[0]) \|\| $this->locale->isHidden($path_segments[0])) {
86	30	unset($path_segments[0]);
87	19	}
88
89	84	return '/' . implode('/', $path_segments);
90		}
91
92		/**
93		* Construct a full url with the parsed url elements
94		* resulted from a parse_url() function call
95		*
96		* @param array $parsed
97		* @return string
98		*/
99	87	private function reassemble(array $parsed)
100		{
101		return
102	87	((isset($parsed['scheme'])) ? $parsed['scheme'] . '://' : ($this->schemeless ? '//' : ''))
103	87	.((isset($parsed['user'])) ? $parsed['user'] . ((isset($parsed['pass'])) ? ':' . $parsed['pass'] : '') .'@' : '')
104	87	.((isset($parsed['host'])) ? $parsed['host'] : '')
105	87	.((isset($parsed['port'])) ? ':' . $parsed['port'] : '')
106	87	.((isset($parsed['path'])) ? $parsed['path'] : '')
107	87	.((isset($parsed['query'])) ? '?' . $parsed['query'] : '')
108	87	.((isset($parsed['fragment'])) ? '#' . $parsed['fragment'] : '');
109		}
110
111	90	private function assertUrlExists()
112		{
113	90	if (!$this->parsed) {
		0 ignored issues – show Bug Best Practice introduced 2016-11-27 21:03 UTC by Report Bug Copy Issue Report The expression `$this->parsed` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
114	3	throw new \LogicException('Url is required. Please run UrlParser::set($url) first.');
115		}
116		}
117		}

thinktomorrow / locale

Push — master ( d4ac13...53915c )

UrlParser::delocalizePath() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like