Thinktomorrow\Locale\Detectors\QueryDetector

Complexity

Total Complexity

5

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	get()	0	12	4

<?php

namespace Thinktomorrow\Locale\Detectors;

use Illuminate\Http\Request;
use Thinktomorrow\Locale\Scope;
use Thinktomorrow\Locale\Values\Config;
use Thinktomorrow\Locale\Values\Locale;

class QueryDetector implements Detector
{
    /**
     * @var Request
     */
    private $request;

    public function __construct(Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->request = $request;
    }

    public function get(Scope $scope, Config $config): ?Locale
    {
        if (!isset($config['query_key'])) {
            return null;
        }

        if (!$queryValue = $this->request->get($config['query_key'])) {
            return null;
        }

        return ($scope->validateLocale(Locale::from($queryValue))) ? Locale::from($queryValue) : null;
    }
}