thinktomorrow / chief

app/Exceptions/ChiefExceptionHandler.php

<?php

namespace Thinktomorrow\Chief\App\Exceptions;

use Illuminate\Auth\Access\AuthorizationException;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Illuminate\Http\Exceptions\PostTooLargeException;
use Illuminate\Support\Arr;
use Illuminate\Support\Str;
use Illuminate\Validation\ValidationException;
use Throwable;

class ChiefExceptionHandler extends ExceptionHandler
{
    /**
     * A list of the exception types that should not be reported.
     *
     * @var array
     */
    protected $dontReport = [
        //
    ];

    /**
     * A list of the inputs that are never flashed for validation exceptions.
     *
     * @var array
     */
    protected $dontFlash = [
        'password',
        'password_confirmation',
    ];

    /**
     * Render an exception into an HTTP response.
     *
     * @param \Illuminate\Http\Request $request
     * @param Throwable $e
     * @return \Illuminate\Http\Response
     */
    public function render($request, Throwable $e)
    {
        if ($e instanceof AuthorizationException) {
            return $this->unauthorized($request, $e);

The expression return $this->unauthorized($request, $e) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        //        if ($request->getMethod() == 'POST' && $e instanceof PostTooLargeException) {
        //            if ($request->expectsJson()) {
        //                return response()->json([
        //                    'error' => true, // required by redactor
        //                    'message' => $e->getMessage(),
        //                ], 200);
        //            }
        //        }
        if ($this->shouldRenderChiefException($e)) {
            return $this->renderChiefException($request, $e);

The expression return $this->renderChiefException($request, $e) also could return the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return parent::render($request, $e);
    }

    private function shouldRenderChiefException(Throwable $exception): bool
    {
        return (Str::startsWith(request()->path(), 'admin/') && ! $exception instanceof AuthenticationException && ! $exception instanceof ValidationException);
    }

    protected function renderChiefException(\Illuminate\Http\Request $request, Throwable $exception)
    {
        if (! config('app.debug')) {
            if ($request->expectsJson()) {
                return response()->json(['error' => 'Something went wrong.'], 404);
            }

            return response()->view('chief::errors.custom', [], 500);
        }

        return parent::render($request, $exception);
    }


    protected function unauthorized(\Illuminate\Http\Request $request, AuthorizationException $exception)

The parameter $exception is not used and could be removed.

The parameter $request is not used and could be removed.

    {
        return redirect()->route('chief.back.dashboard')
            ->with('messages.error', 'Oeps. Het lijkt erop dat je geen toegang hebt tot dit deel van chief. Vraag even de beheerder voor meer info.');
    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Illuminate\Auth\AuthenticationException $exception
     * @return \Illuminate\Http\Response
     */
    protected function unauthenticated($request, AuthenticationException $exception)
    {
        if ($request->expectsJson() || $request->isJson()) {
            return response()->json([

The expression return response()->json(array('error' => 'Unauthenticated.', 'message' => $exception->getMessage()), 401) returns the type Illuminate\Http\JsonResponse which is incompatible with the documented return type Illuminate\Http\Response.

                'error' => 'Unauthenticated.',
                'message' => $exception->getMessage(),
            ], 401);
        }

        if (! empty($exception->guards()) && Arr::first($exception->guards()) == 'chief') {
            return redirect()->guest(route('chief.back.login'));

The expression return redirect()->guest(route('chief.back.login')) returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

        }

        return redirect()->guest(method_exists($exception, 'redirectTo') ? $exception->redirectTo() : '/');

The expression return redirect()->guest(method_exists($exception, 'redirectTo') ? $exception->redirectTo() : '/') returns the type Illuminate\Http\RedirectResponse which is incompatible with the documented return type Illuminate\Http\Response.

    }
}