Inspection of "Proof of concept for managed model" - thinktomorrow/chief - Measure and Improve Code Quality continuously with Scrutinizer

chief

Test Failed

Push — ft/managedmodel ( fe202f...0604a9 )

by Ben

created 2019-07-04 09:06 UTC

Status

All Patches
92
New
0

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch

@@ -39,7 +39,9 @@
 block discarded – undo
 
         // If this is a '/' slug, it indicates the homepage for this locale. In this case,
         // we wont be trimming the slash
-        if($slug === '/') return $slug;
+        if($slug === '/') {
+            return $slug;
+        }
 
         if ($this->startsWithBaseUrlSegment($slug)) {
             $slug = trim(substr($slug, strlen($this->baseUrlSegment)), '/');

Please login to merge, or discard this patch.

		@@ -39,7 +39,9 @@
		block discarded – undo
39	39
40	40	// If this is a '/' slug, it indicates the homepage for this locale. In this case,
41	41	// we wont be trimming the slash
42		- if($slug === '/') return $slug;
	42	+ if($slug === '/') {
	43	+ return $slug;
	44	+ }
43	45
44	46	if ($this->startsWithBaseUrlSegment($slug)) {
45	47	$slug = trim(substr($slug, strlen($this->baseUrlSegment)), '/');

thinktomorrow / chief

Push — ft/managedmodel ( fe202f...0604a9 )

Status

Category

Braces +3 added lines, -1 removed lines patch added patch discarded remove patch