Test Failed
Push — ft/managedmodel ( fe202f...0604a9 )
by Ben
40:51
created
src/Relations/AvailableChildren.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 
34 34
     public function onlyModules(): Collection
35 35
     {
36
-        return $this->collection()->reject(function ($item) {
36
+        return $this->collection()->reject(function($item) {
37 37
             if ($item instanceof Page || $item instanceof StoredSetReference) {
38 38
                 return true;
39 39
             }
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 
43 43
     public function onlyPages(): Collection
44 44
     {
45
-        return $this->collection()->filter(function ($item) {
45
+        return $this->collection()->filter(function($item) {
46 46
             if ($item instanceof Page) {
47 47
                 return true;
48 48
             }
@@ -72,12 +72,12 @@  discard block
 block discarded – undo
72 72
 
73 73
         // Merging the results of all the pages and all the modules, then filter by the config
74 74
         // This prevents us from having duplicates and also reduces the query load.
75
-        $collection = $collection->filter(function ($page) use ($available_children_types) {
75
+        $collection = $collection->filter(function($page) use ($available_children_types) {
76 76
             return in_array(get_class($page), $available_children_types);
77 77
         });
78 78
 
79 79
         // Filter out our already loaded pages and modules
80
-        $remaining_children_types = collect($available_children_types)->reject(function ($type) {
80
+        $remaining_children_types = collect($available_children_types)->reject(function($type) {
81 81
             return (new $type() instanceof Page || new $type() instanceof Module);
82 82
         });
83 83
 
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
             $collection = collect(array_merge($collection->all(), (new $type())->all()->all()));
89 89
         }
90 90
         // Filter out our parent
91
-        return $this->collection = $collection->reject(function ($item) {
91
+        return $this->collection = $collection->reject(function($item) {
92 92
             if ($item instanceof $this->parent) {
93 93
                 return $item->id == $this->parent->id;
94 94
             }
Please login to merge, or discard this patch.
src/Relations/Relation.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@
 block discarded – undo
103 103
     {
104 104
         $relations = static::where(function ($query) use ($type, $id) {
105 105
             return $query->where('parent_type', $type)
106
-                         ->where('parent_id', $id);
106
+                            ->where('parent_id', $id);
107 107
         })->orWhere(function ($query) use ($type, $id) {
108 108
             return $query->where('child_type', $type)
109 109
                 ->where('child_id', $id);
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
             ->orderBy('sort', 'ASC')
52 52
             ->get();
53 53
 
54
-        return $relations->map(function (Relation $relation) {
54
+        return $relations->map(function(Relation $relation) {
55 55
             $parent = $relation->parent;
56 56
             $parent->relation = $relation;
57 57
             return $parent;
@@ -65,14 +65,14 @@  discard block
 block discarded – undo
65 65
                             ->orderBy('sort', 'ASC')
66 66
                             ->get();
67 67
 
68
-        return $relations->map(function (Relation $relation) use ($parent_type, $parent_id) {
68
+        return $relations->map(function(Relation $relation) use ($parent_type, $parent_id) {
69 69
 
70 70
             // It could be that the child itself is soft-deleted, if this is the case, we will ignore it and move on.
71 71
             if (!$child = $relation->child) {
72 72
                 if (!$relation->child()->withTrashed()->first()) {
73 73
 //                if ((!method_exists($childInstance, 'trashed')) || ! $childInstance->onlyTrashed()->find($relation->child_id)) {
74 74
                     // If we cannot retrieve it then he collection type is possibly off, this is a database inconsistency and should be addressed
75
-                    throw new \DomainException('Corrupt relation reference. Related child ['.$relation->child_type.'@'.$relation->child_id.'] could not be retrieved for parent [' . $parent_type.'@'.$parent_id.']. Make sure the morph key can resolve to a valid class.');
75
+                    throw new \DomainException('Corrupt relation reference. Related child ['.$relation->child_type.'@'.$relation->child_id.'] could not be retrieved for parent ['.$parent_type.'@'.$parent_id.']. Make sure the morph key can resolve to a valid class.');
76 76
                 }
77 77
 
78 78
                 return null;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         })
85 85
 
86 86
         // In case of soft-deleted entries, this will be null and should be ignored. We make sure that keys are reset in case of removed child
87
-        ->reject(function ($child) {
87
+        ->reject(function($child) {
88 88
             return is_null($child);
89 89
         })
90 90
         ->values();
@@ -101,10 +101,10 @@  discard block
 block discarded – undo
101 101
 
102 102
     public static function deleteRelationsOf($type, $id)
103 103
     {
104
-        $relations = static::where(function ($query) use ($type, $id) {
104
+        $relations = static::where(function($query) use ($type, $id) {
105 105
             return $query->where('parent_type', $type)
106 106
                          ->where('parent_id', $id);
107
-        })->orWhere(function ($query) use ($type, $id) {
107
+        })->orWhere(function($query) use ($type, $id) {
108 108
             return $query->where('child_type', $type)
109 109
                 ->where('child_id', $id);
110 110
         })->get();
Please login to merge, or discard this patch.
src/Media/MediaType.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace Thinktomorrow\Chief\Media;
6 6
 
Please login to merge, or discard this patch.
src/Settings/SettingsManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     {
13 13
         $this->fetch();
14 14
 
15
-        if (! isset($this->values[$key])) {
15
+        if (!isset($this->values[$key])) {
16 16
             return $default;
17 17
         }
18 18
         
Please login to merge, or discard this patch.
src/Settings/SettingsServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     public function register()
15 15
     {
16
-        $this->app->singleton(SettingsManager::class, function ($app) {
16
+        $this->app->singleton(SettingsManager::class, function($app) {
17 17
             return new SettingsManager();
18 18
         });
19 19
     }
Please login to merge, or discard this patch.
src/Settings/Setting.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
     private function defaultField()
46 46
     {
47 47
         return InputField::make($this->key)
48
-                    ->label(ucfirst(str_replace(['-','_','.'], ' ', $this->key)));
48
+                    ->label(ucfirst(str_replace(['-', '_', '.'], ' ', $this->key)));
49 49
     }
50 50
 
51 51
     public static function refreshFieldsFromConfig()
Please login to merge, or discard this patch.
src/FlatReferences/FlatReferencePresenter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@  discard block
 block discarded – undo
8 8
 {
9 9
     public static function toSelectValues(Collection $collection): Collection
10 10
     {
11
-        return $collection->map(function (ProvidesFlatReference $item) {
11
+        return $collection->map(function(ProvidesFlatReference $item) {
12 12
             return [
13 13
                 'id'    => $item->flatReference()->get(),
14 14
                 'label' => $item->flatReferenceLabel(),
@@ -21,10 +21,10 @@  discard block
 block discarded – undo
21 21
     {
22 22
         $grouped = [];
23 23
 
24
-        static::toSelectValues($collection)->each(function ($item) use (&$grouped) {
24
+        static::toSelectValues($collection)->each(function($item) use (&$grouped) {
25 25
             if (isset($grouped[$item['group']])) {
26 26
                 $grouped[$item['group']]['values'][] = $item;
27
-            } else {
27
+            }else {
28 28
                 $grouped[$item['group']] = ['group' => $item['group'], 'values' => [$item]];
29 29
             }
30 30
         });
Please login to merge, or discard this patch.
src/FlatReferences/FlatReferenceCollection.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,16 +21,16 @@
 block discarded – undo
21 21
             $referenceStrings = [];
22 22
         }
23 23
 
24
-        return (new Collection($referenceStrings))->reject(function ($referenceString) {
24
+        return (new Collection($referenceStrings))->reject(function($referenceString) {
25 25
             return is_null($referenceString);
26
-        })->map(function ($referenceString) {
26
+        })->map(function($referenceString) {
27 27
             return FlatReferenceFactory::fromString($referenceString)->instance();
28 28
         });
29 29
     }
30 30
 
31 31
     public function toFlatReferences(): Collection
32 32
     {
33
-        return (new Collection($this->all()))->map(function (ProvidesFlatReference $item) {
33
+        return (new Collection($this->all()))->map(function(ProvidesFlatReference $item) {
34 34
             return $item->flatReference()->get();
35 35
         });
36 36
     }
Please login to merge, or discard this patch.
src/FlatReferences/FlatReferenceFactory.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
     public static function fromString(string $reference): FlatReference
8 8
     {
9 9
         if (false == strpos($reference, '@')) {
10
-            throw new \InvalidArgumentException('Invalid reference composition. A flat reference should honour schema <class>@<id>. [' . $reference . '] was passed instead.');
10
+            throw new \InvalidArgumentException('Invalid reference composition. A flat reference should honour schema <class>@<id>. ['.$reference.'] was passed instead.');
11 11
         }
12 12
 
13 13
         list($className, $id) = explode('@', $reference);
@@ -15,8 +15,8 @@  discard block
 block discarded – undo
15 15
         $instance = app($className);
16 16
         $instance->{$instance->getKeyName()} = $id;
17 17
 
18
-        if (! method_exists($instance, 'flatReference')) {
19
-            throw new \InvalidArgumentException('Instance created from model reference [' . $reference . '] was expected to have a method of flatReference() but is has not.');
18
+        if (!method_exists($instance, 'flatReference')) {
19
+            throw new \InvalidArgumentException('Instance created from model reference ['.$reference.'] was expected to have a method of flatReference() but is has not.');
20 20
         }
21 21
 
22 22
         return $instance->flatReference();
Please login to merge, or discard this patch.