Completed
Pull Request — master (#414)
by Philippe
32:33 queued 15:43
created
src/Fields/Fields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
                 continue;
67 67
             }
68 68
 
69
-            $method = 'get' . ucfirst($key);
69
+            $method = 'get'.ucfirst($key);
70 70
 
71 71
             // Reject from list if value does not match expected one
72 72
             if ($value && $value == $field->$method()) {
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
     public function offsetSet($offset, $value)
125 125
     {
126 126
         if (!$value instanceof Field) {
127
-            throw new \InvalidArgumentException('Passed value must be of type ' . Field::class);
127
+            throw new \InvalidArgumentException('Passed value must be of type '.Field::class);
128 128
         }
129 129
 
130 130
         $this->fields[$offset] = $value;
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
 
155 155
     private function validateFields(array $fields)
156 156
     {
157
-        array_map(function (Field $field) {
157
+        array_map(function(Field $field) {
158 158
         }, $fields);
159 159
     }
160 160
 
Please login to merge, or discard this patch.
src/FlatReferences/FlatReference.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
 
40 40
     public function get(): string
41 41
     {
42
-        return $this->className . '@' . $this->id;
42
+        return $this->className.'@'.$this->id;
43 43
     }
44 44
 
45 45
     public function equals($other): bool
Please login to merge, or discard this patch.
src/FlatReferences/FlatReferenceFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
7 7
     public static function fromString(string $reference): FlatReference
8 8
     {
9 9
         if (false == strpos($reference, '@')) {
10
-            throw new \InvalidArgumentException('Invalid reference composition. A flat reference should honour schema <class>@<id>. [' . $reference . '] was passed instead.');
10
+            throw new \InvalidArgumentException('Invalid reference composition. A flat reference should honour schema <class>@<id>. ['.$reference.'] was passed instead.');
11 11
         }
12 12
 
13 13
         list($className, $id) = explode('@', $reference);
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
         $instance->{$instance->getKeyName()} = $id;
17 17
 
18 18
         if (!method_exists($instance, 'flatReference')) {
19
-            throw new \InvalidArgumentException('Instance created from model reference [' . $reference . '] was expected to have a method of flatReference() but is has not.');
19
+            throw new \InvalidArgumentException('Instance created from model reference ['.$reference.'] was expected to have a method of flatReference() but is has not.');
20 20
         }
21 21
 
22 22
         return $instance->flatReference();
Please login to merge, or discard this patch.
src/Sets/Set.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 
50 50
         // If no view has been created for this page collection, we try once again to fetch the content value if any. This will silently fail
51 51
         // if no content value is present. We don't consider the 'content' attribute to be a default as we do for module.
52
-        return $this->map(function ($item) {
52
+        return $this->map(function($item) {
53 53
             return ($this->viewParent && $item instanceof ViewableContract)
54 54
                 ? $item->setViewParent($this->viewParent)->renderView()
55 55
                 : ($item->content ?? '');
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
     {
83 83
         $currentPage = $currentPage ?? request()->get('page', 1);
84 84
         $path = request()->path();
85
-        $items = array_slice($this->all(), ($currentPage - 1) * $perPage);
85
+        $items = array_slice($this->all(), ($currentPage-1) * $perPage);
86 86
 
87 87
         return (new \Illuminate\Pagination\Paginator($items, $perPage ?? $this->paginateSetting('perPage', '12'), $currentPage))->setPath($path);
88 88
     }
@@ -98,8 +98,8 @@  discard block
 block discarded – undo
98 98
     public function paginate($perPage = null, $currentPage = null): Paginator
99 99
     {
100 100
         $currentPage = $currentPage ?? request()->get('page', 1);
101
-        $path = '/' . request()->path();
102
-        $items = array_slice($this->all(), ($currentPage - 1) * $perPage, $perPage);
101
+        $path = '/'.request()->path();
102
+        $items = array_slice($this->all(), ($currentPage-1) * $perPage, $perPage);
103 103
 
104 104
         return (new \Illuminate\Pagination\LengthAwarePaginator($items, $this->paginateSetting('total', $this->count()), $perPage ?? $this->paginateSetting('perPage', '12'), $currentPage))->setPath($path);
105 105
     }
Please login to merge, or discard this patch.
src/Sets/SetReference.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     {
37 37
         // Constraints
38 38
         if (!isset($values['action'])) {
39
-            throw new \InvalidArgumentException('Set reference array is missing required values for the "action" keys. Given: ' . print_r($values, true));
39
+            throw new \InvalidArgumentException('Set reference array is missing required values for the "action" keys. Given: '.print_r($values, true));
40 40
         }
41 41
 
42 42
         return new static(
@@ -51,14 +51,14 @@  discard block
 block discarded – undo
51 51
     {
52 52
         $sets = config('thinktomorrow.chief.sets', []);
53 53
 
54
-        return collect($sets)->map(function ($set, $key) {
54
+        return collect($sets)->map(function($set, $key) {
55 55
             return SetReference::fromArray($key, $set);
56 56
         });
57 57
     }
58 58
 
59 59
     public static function find($key): ?SetReference
60 60
     {
61
-        return static::all()->filter(function ($ref) use ($key) {
61
+        return static::all()->filter(function($ref) use ($key) {
62 62
             return $ref->key() == $key;
63 63
         })->first();
64 64
     }
@@ -150,11 +150,11 @@  discard block
 block discarded – undo
150 150
     private static function validateAction($class, $method)
151 151
     {
152 152
         if (!class_exists($class)) {
153
-            throw new \InvalidArgumentException('The class [' . $class . '] isn\'t a valid class reference or does not exist in the chief-settings.sets config entry.');
153
+            throw new \InvalidArgumentException('The class ['.$class.'] isn\'t a valid class reference or does not exist in the chief-settings.sets config entry.');
154 154
         }
155 155
 
156 156
         if (!method_exists($class, $method)) {
157
-            throw new \InvalidArgumentException('The method [' . $method . '] does not exist on the class [' . $class . ']. Make sure you provide a valid method to the action value in the chief-settings.sets config entry.');
157
+            throw new \InvalidArgumentException('The method ['.$method.'] does not exist on the class ['.$class.']. Make sure you provide a valid method to the action value in the chief-settings.sets config entry.');
158 158
         }
159 159
     }
160 160
 
Please login to merge, or discard this patch.
src/Sets/StoredSetReference.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,12 +35,12 @@
 block discarded – undo
35 35
 
36 36
     public function toReference(): SetReference
37 37
     {
38
-        $reference = SetReference::all()->first(function ($setReference) {
38
+        $reference = SetReference::all()->first(function($setReference) {
39 39
             return $setReference->key() == $this->key;
40 40
         });
41 41
 
42 42
         if (!$reference) {
43
-            throw new \Exception('No query set found by key [' . $this->key . ']. Make sure that this ' . $this->key . ' set is added to the chief.sets config array.');
43
+            throw new \Exception('No query set found by key ['.$this->key.']. Make sure that this '.$this->key.' set is added to the chief.sets config array.');
44 44
         }
45 45
 
46 46
         return $reference;
Please login to merge, or discard this patch.
src/Authorization/Permission.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -26,15 +26,15 @@
 block discarded – undo
26 26
     {
27 27
         $abilities = ['view', 'create', 'update', 'delete'];
28 28
 
29
-        return array_map(function ($val) use ($scope) {
30
-            return $val . '-' . $scope;
29
+        return array_map(function($val) use ($scope) {
30
+            return $val.'-'.$scope;
31 31
         }, $abilities);
32 32
     }
33 33
 
34 34
     public static function getPermissionsForIndex()
35 35
     {
36 36
         $permissions = $temp = [];
37
-        self::all()->each(function ($permission) use (&$permissions, &$temp) {
37
+        self::all()->each(function($permission) use (&$permissions, &$temp) {
38 38
             $model = explode("_", $permission->name, 2)[1];
39 39
             $temp[$model][$permission->id] = explode("_", $permission->name, 2)[0];
40 40
             $permissions = $temp;
Please login to merge, or discard this patch.
src/Pages/PageManager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -85,9 +85,9 @@  discard block
 block discarded – undo
85 85
             $this->pageBuilderField(),
86 86
             InputField::make('title')->translatable($this->model->availableLocales())
87 87
                 ->validation('required-fallback-locale|max:200', [], [
88
-                    'trans.' . config('app.fallback_locale', 'nl') . '.title' => 'title',
88
+                    'trans.'.config('app.fallback_locale', 'nl').'.title' => 'title',
89 89
                 ])
90
-                ->label('De titel van je ' . $this->model->labelSingular ?? 'pagina')
90
+                ->label('De titel van je '.$this->model->labelSingular ?? 'pagina')
91 91
                 ->description('Dit is de titel die zal worden getoond in de overzichten en modules.'),
92 92
             InputField::make('seo_title')
93 93
                 ->translatable($this->model->availableLocales())
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
     public function fieldArrangement($key = null): FieldArrangement
128 128
     {
129 129
         if ($key == 'create') {
130
-            return new FieldArrangement($this->fieldsWithAssistantFields()->filterBy(function ($field) {
130
+            return new FieldArrangement($this->fieldsWithAssistantFields()->filterBy(function($field) {
131 131
                 return in_array($field->getKey(), ['title']);
132 132
             }));
133 133
         }
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
             if (is_array_empty($translation)) {
212 212
 
213 213
                 // Nullify all values
214
-                $trans[$locale] = array_map(function ($value) {
214
+                $trans[$locale] = array_map(function($value) {
215 215
                     return null;
216 216
                 }, $translation);
217 217
                 continue;
Please login to merge, or discard this patch.
src/Pages/Page.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
             return static::$managedModelKey;
98 98
         }
99 99
 
100
-        throw new \Exception('Missing required static property \'managedModelKey\' on ' . static::class . '.');
100
+        throw new \Exception('Missing required static property \'managedModelKey\' on '.static::class.'.');
101 101
     }
102 102
 
103 103
     /**
@@ -137,9 +137,9 @@  discard block
 block discarded – undo
137 137
     public function flatReferenceLabel(): string
138 138
     {
139 139
         if ($this->exists) {
140
-            $status = !$this->isPublished() ? ' [' . $this->statusAsPlainLabel() . ']' : null;
140
+            $status = !$this->isPublished() ? ' ['.$this->statusAsPlainLabel().']' : null;
141 141
 
142
-            return $this->title ? $this->title . $status : '';
142
+            return $this->title ? $this->title.$status : '';
143 143
         }
144 144
 
145 145
         return '';
@@ -150,7 +150,7 @@  discard block
 block discarded – undo
150 150
         $classKey = get_class($this);
151 151
         if (property_exists($this, 'labelSingular')) {
152 152
             $labelSingular = $this->labelSingular;
153
-        } else {
153
+        }else {
154 154
             $labelSingular = Str::singular($classKey);
155 155
         }
156 156
 
@@ -190,7 +190,7 @@  discard block
 block discarded – undo
190 190
             $locale = app()->getLocale();
191 191
         }
192 192
         try {
193
-            $memoizedKey = $this->getMorphClass() . '-' . $this->id . '-' . $locale;
193
+            $memoizedKey = $this->getMorphClass().'-'.$this->id.'-'.$locale;
194 194
 
195 195
             if (isset(static::$cachedUrls[$memoizedKey])) {
196 196
                 return static::$cachedUrls[$memoizedKey];
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
     /** @inheritdoc */
215 215
     public function previewUrl(string $locale = null): string
216 216
     {
217
-        return $this->url($locale) . '?preview-mode';
217
+        return $this->url($locale).'?preview-mode';
218 218
     }
219 219
 
220 220
 
@@ -253,11 +253,11 @@  discard block
 block discarded – undo
253 253
     public function statusAsLabel()
254 254
     {
255 255
         if ($this->isPublished()) {
256
-            return '<a href="' . $this->url() . '" target="_blank"><em>online</em></a>';
256
+            return '<a href="'.$this->url().'" target="_blank"><em>online</em></a>';
257 257
         }
258 258
 
259 259
         if ($this->isDraft()) {
260
-            return '<a href="' . $this->previewUrl() . '" target="_blank" class="text-error"><em>offline</em></a>';
260
+            return '<a href="'.$this->previewUrl().'" target="_blank" class="text-error"><em>offline</em></a>';
261 261
         }
262 262
 
263 263
         if ($this->isArchived()) {
Please login to merge, or discard this patch.