Completed
Pull Request — master (#414)
by Philippe
32:33 queued 15:43
created
src/PageBuilder/PresentSections.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
             $this->addModelToCollection($i, $child);
82 82
         }
83 83
 
84
-        return $this->sets->values()->map(function (ViewableContract $child) {
84
+        return $this->sets->values()->map(function(ViewableContract $child) {
85 85
             return ($this->withSnippets && method_exists($child, 'withSnippets'))
86 86
                 ? $child->withSnippets()->setViewParent($this->parent)->renderView()
87 87
                 : $child->setViewParent($this->parent)->renderView();
Please login to merge, or discard this patch.
src/PageBuilder/UpdateSections.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
                 continue;
189 189
             }
190 190
 
191
-            $child = $children->first(function ($c) use ($reference) {
191
+            $child = $children->first(function($c) use ($reference) {
192 192
                 return $c->flatReference()->get() == $reference;
193 193
             });
194 194
 
@@ -239,7 +239,7 @@  discard block
 block discarded – undo
239 239
     private function stripTagsBlacklist($value, $blacklist = [])
240 240
     {
241 241
         foreach ($blacklist as $tag) {
242
-            $value = preg_replace('/<\/?' . $tag . '(.|\s)*?>/', '', $value);
242
+            $value = preg_replace('/<\/?'.$tag.'(.|\s)*?>/', '', $value);
243 243
         }
244 244
 
245 245
         return $value;
Please login to merge, or discard this patch.
src/Filters/Filters.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -47,8 +47,8 @@  discard block
 block discarded – undo
47 47
     {
48 48
         $requestInput = request()->all();
49 49
 
50
-        return array_reduce($this->all(), function ($carry, Filter $filter) use ($requestInput) {
51
-            return $carry . $filter->render($requestInput);
50
+        return array_reduce($this->all(), function($carry, Filter $filter) use ($requestInput) {
51
+            return $carry.$filter->render($requestInput);
52 52
         }, '');
53 53
     }
54 54
 
@@ -64,14 +64,14 @@  discard block
 block discarded – undo
64 64
 
65 65
     public function keys(): array
66 66
     {
67
-        return array_map(function (Filter $filter) {
67
+        return array_map(function(Filter $filter) {
68 68
             return $filter->key();
69 69
         }, $this->filters);
70 70
     }
71 71
 
72 72
     private function validateFilters(array $filters)
73 73
     {
74
-        array_map(function (Filter $filter) {
74
+        array_map(function(Filter $filter) {
75 75
         }, $filters);
76 76
     }
77 77
 
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     public function offsetSet($offset, $value)
98 98
     {
99 99
         if (!$value instanceof Filter) {
100
-            throw new \InvalidArgumentException('Passed value must be of type ' . Filter::class);
100
+            throw new \InvalidArgumentException('Passed value must be of type '.Filter::class);
101 101
         }
102 102
 
103 103
         $this->filters[$offset] = $value;
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 
116 116
     private function sanitizeFilters(array $filters)
117 117
     {
118
-        return array_map(function ($filter) {
118
+        return array_map(function($filter) {
119 119
             if (is_string($filter) && class_exists($filter)) {
120 120
                 return $filter::init();
121 121
             }
Please login to merge, or discard this patch.
src/Filters/Filter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@  discard block
 block discarded – undo
48 48
 
49 49
     public function render(array $requestInput = []): string
50 50
     {
51
-        $path = $this->viewpath ?? 'chief::back._filters.' . $this->type;
51
+        $path = $this->viewpath ?? 'chief::back._filters.'.$this->type;
52 52
         $this->default($requestInput[$this->name] ?? null);
53 53
 
54 54
         return view($path, ['filter' => $this])->render();
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         }
63 63
 
64 64
         if (!in_array($name, ['name', 'label', 'description', 'query', 'viewpath', 'default'])) {
65
-            throw new \InvalidArgumentException('Cannot set value by [' . $name . '].');
65
+            throw new \InvalidArgumentException('Cannot set value by ['.$name.'].');
66 66
         }
67 67
 
68 68
         $this->values[$name] = $arguments[0];
Please login to merge, or discard this patch.
src/Snippets/SnippetCollection.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             }
37 37
         }
38 38
 
39
-        return static::$loadedSnippets = new self($files->map(function (SplFileInfo $file) {
39
+        return static::$loadedSnippets = new self($files->map(function(SplFileInfo $file) {
40 40
             $path = $file->getRealPath();
41 41
 
42 42
             if (0 === strpos($path, resource_path('views')) && false !== strpos($file->getBasename(), '.blade.php')) {
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     {
55 55
         $loadedSnippets = static::load();
56 56
 
57
-        return $loadedSnippets->first(function (Snippet $snippet) use ($key) {
57
+        return $loadedSnippets->first(function(Snippet $snippet) use ($key) {
58 58
             return $snippet->key() == $key;
59 59
         });
60 60
     }
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 
86 86
     public function toClips(): array
87 87
     {
88
-        return $this->map(function ($snippet) {
88
+        return $this->map(function($snippet) {
89 89
             return [$snippet->label(), $snippet->placeholder()];
90 90
         })->toArray();
91 91
     }
Please login to merge, or discard this patch.
src/Menu/MenuItem.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
             if ($item->ofType(static::TYPE_INTERNAL) && $page = $item->page) {
104 104
                 if ($page->isArchived()) {
105 105
                     unset($items[$k]);
106
-                } else {
106
+                }else {
107 107
                     $item->url = self::composePageUrl($item, $page);
108 108
                     $item->page_label = $page->menuLabel();
109 109
                     $item->hidden_in_menu = $page->hidden_in_menu;
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
             'id'             => $node->id,
153 153
             'type'           => $node->type,
154 154
             'label'          => $node->label,
155
-            'page_label'     => $node->page_label,                       // Extra info when dealing with internal links
155
+            'page_label'     => $node->page_label, // Extra info when dealing with internal links
156 156
             'url'            => $node->url,
157 157
             'order'          => $node->order,
158 158
             'page_id'        => $node->page_id,
Please login to merge, or discard this patch.
app/Providers/ChiefServiceProvider.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -26,8 +26,8 @@  discard block
 block discarded – undo
26 26
     {
27 27
         $this->registerChiefGuard();
28 28
 
29
-        $this->app['view']->addNamespace('squanto', __DIR__ . '/../../resources/views/vendor/squanto');
30
-        $this->app['view']->addNamespace('squanto', base_path() . '/resources/views/vendor/thinktomorrow/chief/vendor/squanto');
29
+        $this->app['view']->addNamespace('squanto', __DIR__.'/../../resources/views/vendor/squanto');
30
+        $this->app['view']->addNamespace('squanto', base_path().'/resources/views/vendor/thinktomorrow/chief/vendor/squanto');
31 31
 
32 32
         (new MacrosServiceProvider($this->app))->boot();
33 33
         (new AuthServiceProvider($this->app))->boot();
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
             $this->app->bind('command.chief:admin', CreateAdmin::class);
79 79
             $this->app->bind('command.chief:developer', CreateDeveloper::class);
80 80
             $this->app->bind('command.chief:settings', SeedSettings::class);
81
-            $this->app->bind('command.chief:page', function ($app) {
81
+            $this->app->bind('command.chief:page', function($app) {
82 82
                 return new GeneratePage($app['files'], [
83 83
                     'base_path' => base_path()
84 84
                 ]);
@@ -90,11 +90,11 @@  discard block
 block discarded – undo
90 90
 
91 91
         // Custom validator for requiring on translations only the fallback locale
92 92
         // this is called in the validation as required-fallback-locale
93
-        Validator::extend('requiredFallbackLocale', function ($attribute, $value, $parameters, $validator) {
93
+        Validator::extend('requiredFallbackLocale', function($attribute, $value, $parameters, $validator) {
94 94
             $fallbackLocale = config('app.fallback_locale');
95 95
 
96 96
             if (false !== strpos($attribute, 'trans.'.$fallbackLocale.'.')) {
97
-                return !! trim($value);
97
+                return !!trim($value);
98 98
             }
99 99
 
100 100
             return true;
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
         $this->setupEnvironmentProviders();
110 110
 
111 111
         // Manager register is globally available
112
-        $this->app->singleton(Register::class, function () {
112
+        $this->app->singleton(Register::class, function() {
113 113
             return new Register();
114 114
         });
115 115
 
Please login to merge, or discard this patch.
app/Http/Controllers/Back/Assistants/ArchiveController.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
 
37 37
         $manager->assistant('archive')->archive();
38 38
 
39
-        return redirect()->back()->with('messages.success', $manager->details()->title .' is gearchiveerd.');
39
+        return redirect()->back()->with('messages.success', $manager->details()->title.' is gearchiveerd.');
40 40
     }
41 41
 
42 42
     public function unarchive($key, $id)
@@ -45,6 +45,6 @@  discard block
 block discarded – undo
45 45
 
46 46
         $manager->assistant('archive')->unarchive();
47 47
 
48
-        return redirect()->to($manager->route('index'))->with('messages.success', $manager->details()->title .' is hersteld.');
48
+        return redirect()->to($manager->route('index'))->with('messages.success', $manager->details()->title.' is hersteld.');
49 49
     }
50 50
 }
Please login to merge, or discard this patch.
app/Http/Controllers/Back/PublishController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@
 block discarded – undo
29 29
 
30 30
         $manager->publish();
31 31
         
32
-        return redirect()->back()->with('messages.success', $manager->details()->title .' is gepubliceerd. <a href="' . $manager->previewUrl() . '" target="_blank">Bekijk de pagina online</a>.');
32
+        return redirect()->back()->with('messages.success', $manager->details()->title.' is gepubliceerd. <a href="'.$manager->previewUrl().'" target="_blank">Bekijk de pagina online</a>.');
33 33
     }
34 34
 
35 35
     public function draft(Request $request, $key, $id)
Please login to merge, or discard this patch.