Completed
Pull Request — master (#441)
by Philippe
47:26 queued 07:44
created
src/Fields/Types/FileField.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
     {
22 22
         return (new static(new FieldType(FieldType::FILE), $key))
23 23
             ->locales([config('app.fallback_locale', 'nl')])
24
-            ->valueResolver(function ($model = null, $locale = null, FileField $field) {
24
+            ->valueResolver(function($model = null, $locale = null, FileField $field) {
25 25
                 return $field->getMedia($model, $locale);
26 26
             });
27 27
     }
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         $files = [];
36 36
         $locale = $locale ?? app()->getLocale();
37 37
 
38
-        $assets = $model->assetRelation->where('pivot.type', $this->getKey())->filter(function ($asset) use ($locale) {
38
+        $assets = $model->assetRelation->where('pivot.type', $this->getKey())->filter(function($asset) use ($locale) {
39 39
             return $asset->pivot->locale == $locale;
40 40
         })->sortBy('pivot.order');
41 41
 
Please login to merge, or discard this patch.
src/Fields/Fields.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
                 continue;
93 93
             }
94 94
 
95
-            $method = 'get' . ucfirst($key);
95
+            $method = 'get'.ucfirst($key);
96 96
 
97 97
             // Reject from list if value does not match expected one
98 98
             if ($value && $value == $field->$method()) {
@@ -108,30 +108,30 @@  discard block
 block discarded – undo
108 108
 
109 109
     public function render(): string
110 110
     {
111
-        return array_reduce($this->fields, function (string $carry, Field $field) {
112
-            return $carry . $field->render();
111
+        return array_reduce($this->fields, function(string $carry, Field $field) {
112
+            return $carry.$field->render();
113 113
         }, '');
114 114
     }
115 115
 
116 116
     public function keyed($key): Fields
117 117
     {
118
-        $keys = (array) $key;
118
+        $keys = (array)$key;
119 119
 
120
-        return new static(array_filter($this->fields, function (Field $field) use ($keys) {
120
+        return new static(array_filter($this->fields, function(Field $field) use ($keys) {
121 121
             return in_array($field->getKey(), $keys);
122 122
         }));
123 123
     }
124 124
 
125 125
     public function tagged($tag): Fields
126 126
     {
127
-        return new static(array_filter($this->fields, function (Field $field) use ($tag) {
127
+        return new static(array_filter($this->fields, function(Field $field) use ($tag) {
128 128
             return $field->tagged($tag);
129 129
         }));
130 130
     }
131 131
 
132 132
     public function untagged(): Fields
133 133
     {
134
-        return new static(array_filter($this->fields, function (Field $field) {
134
+        return new static(array_filter($this->fields, function(Field $field) {
135 135
             return $field->untagged();
136 136
         }));
137 137
     }
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
173 173
     public function offsetGet($offset)
174 174
     {
175 175
         if (!isset($this->fields[$offset])) {
176
-            throw new \RuntimeException('No field found by key [' . $offset . ']');
176
+            throw new \RuntimeException('No field found by key ['.$offset.']');
177 177
         }
178 178
 
179 179
         return $this->fields[$offset];
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
182 182
     public function offsetSet($offset, $value)
183 183
     {
184 184
         if (!$value instanceof Field) {
185
-            throw new \InvalidArgumentException('Passed value must be of type ' . Field::class);
185
+            throw new \InvalidArgumentException('Passed value must be of type '.Field::class);
186 186
         }
187 187
 
188 188
         $this->fields[$offset] = $value;
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
 
213 213
     private function validateFields(array $fields)
214 214
     {
215
-        array_map(function (Field $field) {
215
+        array_map(function(Field $field) {
216 216
         }, $fields);
217 217
     }
218 218
 
Please login to merge, or discard this patch.
src/Fields/FieldRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
 
27 27
         if ($reference->hasFragmentKey()) {
28 28
             if (!$field instanceof FragmentField) {
29
-                throw new \RuntimeException('Field ' . $field->getKey() . ' was expected to be a fragmentfield but its not.');
29
+                throw new \RuntimeException('Field '.$field->getKey().' was expected to be a fragmentfield but its not.');
30 30
             }
31 31
 
32 32
             $firstFragment = $field->getFragments()[0];
Please login to merge, or discard this patch.
src/Fields/Types/FieldType.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -6,19 +6,19 @@
 block discarded – undo
6 6
 
7 7
 class FieldType
8 8
 {
9
-    const INPUT = 'input';   // oneliner text (input)
10
-    const TEXT = 'text';    // Plain text (textarea)
9
+    const INPUT = 'input'; // oneliner text (input)
10
+    const TEXT = 'text'; // Plain text (textarea)
11 11
     const NUMBER = 'number'; // number
12 12
     const RANGE = 'range'; // range slider
13
-    const DATE = 'date';    // Timestamp input
14
-    const PHONENUMBER = 'phonenumber';    // Timestamp input
15
-    const HTML = 'html';    // Html text (wysiwyg)
16
-    const SELECT = 'select';  // Select options
17
-    const FILE = 'file';  // regular file
18
-    const IMAGE = 'image';  // image (slim uploader)
19
-    const RADIO = 'radio';  // radio select
20
-    const CHECKBOX = 'checkbox';  // checkbox select
21
-    const PAGEBUILDER = 'pagebuilder';  // the most special field there is...
13
+    const DATE = 'date'; // Timestamp input
14
+    const PHONENUMBER = 'phonenumber'; // Timestamp input
15
+    const HTML = 'html'; // Html text (wysiwyg)
16
+    const SELECT = 'select'; // Select options
17
+    const FILE = 'file'; // regular file
18
+    const IMAGE = 'image'; // image (slim uploader)
19
+    const RADIO = 'radio'; // radio select
20
+    const CHECKBOX = 'checkbox'; // checkbox select
21
+    const PAGEBUILDER = 'pagebuilder'; // the most special field there is...
22 22
     const FRAGMENT = 'fragment';
23 23
     const PAGE = 'page'; // select a page (also a special field)
24 24
 
Please login to merge, or discard this patch.
src/Urls/UrlHelper.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
 
90 90
     public static function modelsByType(array $types, Model $ignoredModel = null, bool $online = true)
91 91
     {
92
-        $models = chiefMemoize('all-online-models', function () use ($types, $online) {
92
+        $models = chiefMemoize('all-online-models', function() use ($types, $online) {
93 93
             $builder = UrlRecord::whereNull('redirect_id')
94 94
                 ->select('model_type', 'model_id')
95 95
                 ->groupBy('model_type', 'model_id');
@@ -98,11 +98,11 @@  discard block
 block discarded – undo
98 98
                 $builder->whereIn('model_type', $types);
99 99
             }
100 100
 
101
-            return $builder->get()->mapToGroups(function ($record) {
101
+            return $builder->get()->mapToGroups(function($record) {
102 102
                 return [$record->model_type => $record->model_id];
103
-            })->map(function ($record, $key) {
103
+            })->map(function($record, $key) {
104 104
                 return Morphables::instance($key)->find($record->toArray());
105
-            })->map->reject(function ($model) use ($online) {
105
+            })->map->reject(function($model) use ($online) {
106 106
                 if ($online) {
107 107
                     return is_null($model) || !$model->isPublished();
108 108
                 } // Invalid references to archived or removed models where url record still exists.
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
         });
113 113
 
114 114
         if ($ignoredModel) {
115
-            $models = $models->reject(function ($model) use ($ignoredModel) {
115
+            $models = $models->reject(function($model) use ($ignoredModel) {
116 116
                 return (get_class($model) === get_class($ignoredModel) && $model->id === $ignoredModel->id);
117 117
             });
118 118
         }
Please login to merge, or discard this patch.
src/Pages/Page.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
             return static::$managedModelKey;
102 102
         }
103 103
 
104
-        throw new \Exception('Missing required static property \'managedModelKey\' on ' . static::class . '.');
104
+        throw new \Exception('Missing required static property \'managedModelKey\' on '.static::class.'.');
105 105
     }
106 106
 
107 107
     /**
@@ -141,9 +141,9 @@  discard block
 block discarded – undo
141 141
     public function flatReferenceLabel(): string
142 142
     {
143 143
         if ($this->exists) {
144
-            $status = !$this->isPublished() ? ' [' . $this->statusAsPlainLabel() . ']' : null;
144
+            $status = !$this->isPublished() ? ' ['.$this->statusAsPlainLabel().']' : null;
145 145
 
146
-            return $this->title ? $this->title . $status : '';
146
+            return $this->title ? $this->title.$status : '';
147 147
         }
148 148
 
149 149
         return '';
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
         $classKey = get_class($this);
155 155
         if (property_exists($this, 'labelSingular')) {
156 156
             $labelSingular = $this->labelSingular;
157
-        } else {
157
+        }else {
158 158
             $labelSingular = Str::singular($classKey);
159 159
         }
160 160
 
@@ -194,7 +194,7 @@  discard block
 block discarded – undo
194 194
             $locale = app()->getLocale();
195 195
         }
196 196
         try {
197
-            $memoizedKey = $this->getMorphClass() . '-' . $this->id . '-' . $locale;
197
+            $memoizedKey = $this->getMorphClass().'-'.$this->id.'-'.$locale;
198 198
 
199 199
             if (isset(static::$cachedUrls[$memoizedKey])) {
200 200
                 return static::$cachedUrls[$memoizedKey];
@@ -218,11 +218,11 @@  discard block
 block discarded – undo
218 218
     /** @inheritdoc */
219 219
     public function previewUrl(string $locale = null): string
220 220
     {
221
-        if($this->isPublished()) {
221
+        if ($this->isPublished()) {
222 222
             return $this->url($locale);
223 223
         }
224 224
 
225
-        return $this->url($locale) . '?preview-mode';
225
+        return $this->url($locale).'?preview-mode';
226 226
     }
227 227
 
228 228
 
@@ -261,11 +261,11 @@  discard block
 block discarded – undo
261 261
     public function statusAsLabel()
262 262
     {
263 263
         if ($this->isPublished()) {
264
-            return '<a href="' . $this->url() . '" target="_blank"><em>online</em></a>';
264
+            return '<a href="'.$this->url().'" target="_blank"><em>online</em></a>';
265 265
         }
266 266
 
267 267
         if ($this->isDraft()) {
268
-            return '<a href="' . $this->previewUrl() . '" target="_blank" class="text-error"><em>offline</em></a>';
268
+            return '<a href="'.$this->previewUrl().'" target="_blank" class="text-error"><em>offline</em></a>';
269 269
         }
270 270
 
271 271
         if ($this->isArchived()) {
Please login to merge, or discard this patch.