Completed
Pull Request — ft/fields-refactor (#231)
by Ben
110:28 queued 99:28
created
src/Management/Assistants/PublishAssistant.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 
72 72
     public function findAll(): Collection
73 73
     {
74
-        return $this->model->published()->get()->map(function ($model) {
74
+        return $this->model->published()->get()->map(function($model) {
75 75
             return $this->managers->findByModel($model);
76 76
         });
77 77
     }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
     public function guard($verb): Assistant
95 95
     {
96
-        if (! $this->can($verb)) {
96
+        if (!$this->can($verb)) {
97 97
             NotAllowedManagerRoute::notAllowedVerb($verb, $this->manager);
98 98
         }
99 99
 
@@ -117,10 +117,10 @@  discard block
 block discarded – undo
117 117
             $class = 'text-warning';
118 118
         }
119 119
 
120
-        $statusAsLabel = '<span class="font-bold '. $class .'"><em>' . $label . '</em></span>';
120
+        $statusAsLabel = '<span class="font-bold '.$class.'"><em>'.$label.'</em></span>';
121 121
 
122 122
         if (!$plain && $this->hasPreviewUrl()) {
123
-            $statusAsLabel =  '<a href="'.$this->previewUrl().'" target="_blank">'. $statusAsLabel .'</a>';
123
+            $statusAsLabel = '<a href="'.$this->previewUrl().'" target="_blank">'.$statusAsLabel.'</a>';
124 124
         }
125 125
 
126 126
         return $statusAsLabel;
Please login to merge, or discard this patch.
src/Management/Assistants/UrlAssistant.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,10 +25,10 @@  discard block
 block discarded – undo
25 25
 
26 26
     public function manager(Manager $manager)
27 27
     {
28
-        $this->manager  = $manager;
28
+        $this->manager = $manager;
29 29
 
30
-        if (! $manager->model() instanceof ProvidesUrl) {
31
-            throw new \Exception('UrlAssistant requires the model interfaced by ' . ProvidesUrl::class . '.');
30
+        if (!$manager->model() instanceof ProvidesUrl) {
31
+            throw new \Exception('UrlAssistant requires the model interfaced by '.ProvidesUrl::class.'.');
32 32
         }
33 33
 
34 34
         $this->model = $manager->model();
@@ -56,14 +56,14 @@  discard block
 block discarded – undo
56 56
             InputField::make('url-slugs')
57 57
                 ->validation(
58 58
                     [
59
-                        'url-slugs' => ['array', 'min:1', new UniqueUrlSlugRule(($this->model && $this->model->exists) ? $this->model : null),],
59
+                        'url-slugs' => ['array', 'min:1', new UniqueUrlSlugRule(($this->model && $this->model->exists) ? $this->model : null), ],
60 60
                     ],
61 61
                     [],
62 62
                     [
63 63
                         'url-slugs.*' => 'taalspecifieke link',
64 64
                     ])
65 65
                 ->view('chief::back._fields.url-slugs')
66
-                ->viewData(['fields' => UrlSlugFields::fromModel($this->model) ]),
66
+                ->viewData(['fields' => UrlSlugFields::fromModel($this->model)]),
67 67
         ]);
68 68
     }
69 69
 
@@ -73,9 +73,9 @@  discard block
 block discarded – undo
73 73
 
74 74
         // Push update to homepage setting value
75 75
         // TODO: we should just fetch the homepages and push that instead...
76
-        UrlRecord::getByModel($this->model)->reject(function ($record) {
76
+        UrlRecord::getByModel($this->model)->reject(function($record) {
77 77
             return ($record->isRedirect() || !$record->isHomepage());
78
-        })->each(function ($record) {
78
+        })->each(function($record) {
79 79
             app(ChangeHomepage::class)->onUrlChanged($record);
80 80
         });
81 81
     }
Please login to merge, or discard this patch.
src/Pages/Page.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             return static::$managedModelKey;
85 85
         }
86 86
 
87
-        throw new \Exception('Missing required static property \'managedModelKey\' on ' . static::class. '.');
87
+        throw new \Exception('Missing required static property \'managedModelKey\' on '.static::class.'.');
88 88
     }
89 89
 
90 90
     /**
@@ -124,9 +124,9 @@  discard block
 block discarded – undo
124 124
     public function flatReferenceLabel(): string
125 125
     {
126 126
         if ($this->exists) {
127
-            $status = ! $this->isPublished() ? ' [' . $this->statusAsPlainLabel().']' : null;
127
+            $status = !$this->isPublished() ? ' ['.$this->statusAsPlainLabel().']' : null;
128 128
 
129
-            return $this->title ? $this->title . $status : '';
129
+            return $this->title ? $this->title.$status : '';
130 130
         }
131 131
 
132 132
         return '';
Please login to merge, or discard this patch.