Completed
Pull Request — ft/added-admin-pagination (#291)
by Philippe
39:17 queued 32:21
created
src/Urls/Application/SaveUrlSlugs.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     private function saveRecord(string $locale, ?string $slug)
57 57
     {
58 58
         // Existing ones for this locale?
59
-        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function ($record) use ($locale) {
59
+        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function($record) use ($locale) {
60 60
             return (
61 61
                 $record->locale == $locale &&
62 62
                 !$record->isRedirect()
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
         // If slug entry is left empty, all existing records will be deleted
67 67
         if (!$slug) {
68
-            $nonRedirectsWithSameLocale->each(function ($existingRecord) {
68
+            $nonRedirectsWithSameLocale->each(function($existingRecord) {
69 69
                 $existingRecord->delete();
70 70
             });
71 71
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         }
82 82
 
83 83
         // Only replace the existing records that differ from the current passed slugs
84
-        $nonRedirectsWithSameLocale->each(function ($existingRecord) use ($slug) {
84
+        $nonRedirectsWithSameLocale->each(function($existingRecord) use ($slug) {
85 85
             if ($existingRecord->slug != $slug) {
86 86
                 $existingRecord->replaceAndRedirect(['slug' => $slug]);
87 87
             }
@@ -126,12 +126,12 @@  discard block
 block discarded – undo
126 126
      */
127 127
     private function deleteIdenticalRedirects($existingRecords, $locale, $slug): void
128 128
     {
129
-        $existingRecords->filter(function ($record) use ($locale) {
129
+        $existingRecords->filter(function($record) use ($locale) {
130 130
             return (
131 131
                 $record->locale == $locale &&
132 132
                 $record->isRedirect()
133 133
             );
134
-        })->each(function ($existingRecord) use ($slug) {
134
+        })->each(function($existingRecord) use ($slug) {
135 135
             if ($existingRecord->slug == $slug) {
136 136
                 $existingRecord->delete();
137 137
             }
@@ -146,11 +146,11 @@  discard block
 block discarded – undo
146 146
 
147 147
         // The old homepage url should be removed since this is no longer in effect.
148 148
         // In case of any redirect to this old homepage, the last used redirect is now back in effect.
149
-        $existingRecords->reject(function ($existingRecord) {
149
+        $existingRecords->reject(function($existingRecord) {
150 150
             return (
151 151
                 $existingRecord->model_type == $this->model->getMorphClass() &&
152 152
                 $existingRecord->model_id == $this->model->id);
153
-        })->each(function ($existingRecord) {
153
+        })->each(function($existingRecord) {
154 154
 
155 155
             // TODO: if there is a redirect to this page, we'll take this one as the new url
156 156
             $existingRecord->delete();
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     private function prependBaseUrlSegment(string $slug, $locale): string
166 166
     {
167
-        $slugWithBaseSegment = $this->model->baseUrlSegment($locale) . '/' . $slug;
167
+        $slugWithBaseSegment = $this->model->baseUrlSegment($locale).'/'.$slug;
168 168
         $slugWithBaseSegment = trim($slugWithBaseSegment, '/');
169 169
 
170 170
         // If slug with base segment is empty string, it means that the passed slug was probably a "/" character.
Please login to merge, or discard this patch.
src/Urls/UrlSlugField.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
             'baseUrlSegment' => $this->baseUrlSegment,
82 82
             'hint' => null, // Hint placeholder to show url hint when it already exists
83 83
             'is_homepage' => ($this->value() === '/'),
84
-            'show' => !!$this->value(),// show input field or not
84
+            'show' => !!$this->value(), // show input field or not
85 85
         ]);
86 86
     }
87 87
 }
Please login to merge, or discard this patch.
src/Management/Assistants/PublishAssistant.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 
72 72
     public function findAll(): Collection
73 73
     {
74
-        return $this->model->published()->get()->map(function ($model) {
74
+        return $this->model->published()->get()->map(function($model) {
75 75
             return $this->managers->findByModel($model);
76 76
         });
77 77
     }
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
 
94 94
     public function guard($verb): Assistant
95 95
     {
96
-        if (! $this->can($verb)) {
96
+        if (!$this->can($verb)) {
97 97
             NotAllowedManagerRoute::notAllowedVerb($verb, $this->manager);
98 98
         }
99 99
 
@@ -117,10 +117,10 @@  discard block
 block discarded – undo
117 117
             $class = 'text-warning';
118 118
         }
119 119
 
120
-        $statusAsLabel = '<span class="font-bold '. $class .'"><em>' . $label . '</em></span>';
120
+        $statusAsLabel = '<span class="font-bold '.$class.'"><em>'.$label.'</em></span>';
121 121
 
122 122
         if (!$plain && $this->hasPreviewUrl()) {
123
-            $statusAsLabel =  '<a href="'.$this->previewUrl().'" target="_blank">'. $statusAsLabel .'</a>';
123
+            $statusAsLabel = '<a href="'.$this->previewUrl().'" target="_blank">'.$statusAsLabel.'</a>';
124 124
         }
125 125
 
126 126
         return $statusAsLabel;
Please login to merge, or discard this patch.
src/Management/Assistants/UrlAssistant.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -25,10 +25,10 @@  discard block
 block discarded – undo
25 25
 
26 26
     public function manager(Manager $manager)
27 27
     {
28
-        $this->manager  = $manager;
28
+        $this->manager = $manager;
29 29
 
30
-        if (! $manager->model() instanceof ProvidesUrl) {
31
-            throw new \Exception('UrlAssistant requires the model interfaced by ' . ProvidesUrl::class . '.');
30
+        if (!$manager->model() instanceof ProvidesUrl) {
31
+            throw new \Exception('UrlAssistant requires the model interfaced by '.ProvidesUrl::class.'.');
32 32
         }
33 33
 
34 34
         $this->model = $manager->model();
@@ -56,14 +56,14 @@  discard block
 block discarded – undo
56 56
             InputField::make('url-slugs')
57 57
                 ->validation(
58 58
                     [
59
-                        'url-slugs' => ['array', 'min:1', new UniqueUrlSlugRule(($this->model && $this->model->exists) ? $this->model : null),],
59
+                        'url-slugs' => ['array', 'min:1', new UniqueUrlSlugRule(($this->model && $this->model->exists) ? $this->model : null), ],
60 60
                     ],
61 61
                     [],
62 62
                     [
63 63
                         'url-slugs.*' => 'taalspecifieke link',
64 64
                     ])
65 65
                 ->view('chief::back._fields.url-slugs')
66
-                ->viewData(['fields' => UrlSlugFields::fromModel($this->model) ]),
66
+                ->viewData(['fields' => UrlSlugFields::fromModel($this->model)]),
67 67
         ]);
68 68
     }
69 69
 
@@ -73,9 +73,9 @@  discard block
 block discarded – undo
73 73
 
74 74
         // Push update to homepage setting value
75 75
         // TODO: we should just fetch the homepages and push that instead...
76
-        UrlRecord::getByModel($this->model)->reject(function ($record) {
76
+        UrlRecord::getByModel($this->model)->reject(function($record) {
77 77
             return ($record->isRedirect() || !$record->isHomepage());
78
-        })->each(function ($record) {
78
+        })->each(function($record) {
79 79
             app(ChangeHomepage::class)->onUrlChanged($record);
80 80
         });
81 81
     }
Please login to merge, or discard this patch.
src/Pages/Page.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             return static::$managedModelKey;
85 85
         }
86 86
 
87
-        throw new \Exception('Missing required static property \'managedModelKey\' on ' . static::class. '.');
87
+        throw new \Exception('Missing required static property \'managedModelKey\' on '.static::class.'.');
88 88
     }
89 89
 
90 90
     /**
@@ -124,9 +124,9 @@  discard block
 block discarded – undo
124 124
     public function flatReferenceLabel(): string
125 125
     {
126 126
         if ($this->exists) {
127
-            $status = ! $this->isPublished() ? ' [' . $this->statusAsPlainLabel().']' : null;
127
+            $status = !$this->isPublished() ? ' ['.$this->statusAsPlainLabel().']' : null;
128 128
 
129
-            return $this->title ? $this->title . $status : '';
129
+            return $this->title ? $this->title.$status : '';
130 130
         }
131 131
 
132 132
         return '';
Please login to merge, or discard this patch.
src/Concerns/Viewable/ViewPath.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      */
35 35
     public function get(): string
36 36
     {
37
-        $basePath = $this->viewBasePath ? $this->viewBasePath . '.' : '';
37
+        $basePath = $this->viewBasePath ? $this->viewBasePath.'.' : '';
38 38
         $guessedParentViewName = $this->parent ? $this->parent->viewKey() : '';
39 39
         $guessedViewName = $this->viewable->viewKey();
40 40
 
@@ -53,14 +53,14 @@  discard block
 block discarded – undo
53 53
         }
54 54
 
55 55
         foreach ($viewPaths as $viewPath) {
56
-            if (! view()->exists($viewPath)) {
56
+            if (!view()->exists($viewPath)) {
57 57
                 continue;
58 58
             }
59 59
 
60 60
             return $viewPath;
61 61
         }
62 62
 
63
-        if (! view()->exists($basePath.'show')) {
63
+        if (!view()->exists($basePath.'show')) {
64 64
             throw new NotFoundView('Viewfile not found for ['.get_class($this->viewable).']. Make sure the view ['.$basePath.$guessedViewName.'] or the default view ['.$basePath.'show] exists.');
65 65
         }
66 66
     }
Please login to merge, or discard this patch.
src/Nav/Nav.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
 
20 20
     public static function fromKeys($keys)
21 21
     {
22
-        $keys = (array) $keys;
22
+        $keys = (array)$keys;
23 23
         $collection = collect();
24 24
 
25 25
         /** @var Managers */
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 
34 34
     public static function fromTags($tags)
35 35
     {
36
-        $tags = (array) $tags;
36
+        $tags = (array)$tags;
37 37
         $collection = collect();
38 38
 
39 39
         /** @var Managers */
@@ -52,9 +52,9 @@  discard block
 block discarded – undo
52 52
 
53 53
     private static function fromManagers(Collection $collection)
54 54
     {
55
-        return new static(...$collection->reject(function ($manager) {
55
+        return new static(...$collection->reject(function($manager) {
56 56
             return !$manager->can('index');
57
-        })->map(function ($manager) {
57
+        })->map(function($manager) {
58 58
             return new NavItem($manager->details()->plural, $manager->route('index'), [
59 59
                 'key' => $manager->details()->key,
60 60
                 'tags' => app(Register::class)->filterByKey($manager->details()->key)->first()->tags()
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
 
65 65
     public function rejectKeys($keys)
66 66
     {
67
-        $keys = (array) $keys;
67
+        $keys = (array)$keys;
68 68
 
69 69
         foreach ($this->items as $k => $item) {
70 70
             if (in_array($item->details('key', ''), $keys)) {
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
 
78 78
     public function rejectTags($tags)
79 79
     {
80
-        $tags = (array) $tags;
80
+        $tags = (array)$tags;
81 81
 
82 82
         foreach ($this->items as $k => $item) {
83 83
             if (count(array_intersect($item->details('tags', []), $tags)) > 0) {
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
         $output = '';
120 120
 
121 121
         foreach ($this->items as $item) {
122
-            $output .= '<a class="' . (isActiveUrl($item->url()) ? 'active' : '') . '" href="'.$item->url().'">';
122
+            $output .= '<a class="'.(isActiveUrl($item->url()) ? 'active' : '').'" href="'.$item->url().'">';
123 123
             $output .= $title ?? ucfirst($item->title());
124 124
             $output .= '</a>';
125 125
         }
@@ -146,14 +146,14 @@  discard block
 block discarded – undo
146 146
 
147 147
         $items = '';
148 148
         foreach ($this->items as $item) {
149
-            $items .= '<a class="' . (isActiveUrl($item->url()) ? 'active' : '') . '" href="'.$item->url().'">';
149
+            $items .= '<a class="'.(isActiveUrl($item->url()) ? 'active' : '').'" href="'.$item->url().'">';
150 150
             $items .= ucfirst($item->title());
151 151
             $items .= '</a>';
152 152
         }
153 153
 
154 154
         // Surround within vue dropdown
155 155
         $output = '<dropdown>';
156
-        $output .= '<span class="center-y nav-item" slot="trigger" slot-scope="{ toggle, isActive }" @click="toggle">'. ($title ?? 'Collecties') .'</span>';
156
+        $output .= '<span class="center-y nav-item" slot="trigger" slot-scope="{ toggle, isActive }" @click="toggle">'.($title ?? 'Collecties').'</span>';
157 157
         $output .= '<div v-cloak class="dropdown-box inset-s">';
158 158
         $output .= $items;
159 159
         $output .= '</div>';
Please login to merge, or discard this patch.
src/Settings/Application/ChangeHomepage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
     {
54 54
         foreach ($flatReferences as $locale => $flatReferenceString) {
55 55
             if (!$flatReferenceString) {
56
-                throw new \InvalidArgumentException('Homepage setting value cannot be empty. Value for locale ' . $locale . ' is missing.');
56
+                throw new \InvalidArgumentException('Homepage setting value cannot be empty. Value for locale '.$locale.' is missing.');
57 57
             }
58 58
         }
59 59
     }
Please login to merge, or discard this patch.
src/Fields/LocalizedFieldValidationRules.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@  discard block
 block discarded – undo
27 27
                 // prepend the name with the expected trans.<locale>. string
28 28
                 $localizedAttr = (false !== strpos($attr, ':locale'))
29 29
                     ? str_replace(':locale', $locale, $attr)
30
-                    : 'trans.' . $locale . '.' . $attr;
30
+                    : 'trans.'.$locale.'.'.$attr;
31 31
 
32 32
                 $localizedAttr = $this->replaceBracketsByDots($localizedAttr);
33 33
 
@@ -49,13 +49,13 @@  discard block
 block discarded – undo
49 49
      */
50 50
     public function influenceByPayload(array $data)
51 51
     {
52
-        if (! isset($data['trans'])) {
52
+        if (!isset($data['trans'])) {
53 53
             return $this;
54 54
         }
55 55
 
56 56
         // Remove locales that are considered empty in the request payload
57 57
         foreach ($data['trans'] as $locale => $values) {
58
-            if ($locale == $this->defaultLocale || ! is_array_empty($values)) {
58
+            if ($locale == $this->defaultLocale || !is_array_empty($values)) {
59 59
                 continue;
60 60
             }
61 61
 
Please login to merge, or discard this patch.