Completed
Pull Request — ft/added-admin-pagination (#291)
by Philippe
39:17 queued 32:21
created
src/HealthMonitor/Checks/HomepageAccessibleCheck.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace Thinktomorrow\Chief\HealthMonitor\Checks;
6 6
 
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
 
16 16
     private function get_http_response_code(string $url)
17 17
     {
18
-        if ($url =='') {
18
+        if ($url == '') {
19 19
             return false;
20 20
         }
21 21
 
@@ -33,6 +33,6 @@  discard block
 block discarded – undo
33 33
 
34 34
     public function message(): string
35 35
     {
36
-        return 'Het lijkt erop dat de homepagina niet meer bereikbaar is. <a href="'. route('chief.back.settings.edit') .'" class="text-secondary-800 underline hover:text-white">Kies een nieuwe</a>.';
36
+        return 'Het lijkt erop dat de homepagina niet meer bereikbaar is. <a href="'.route('chief.back.settings.edit').'" class="text-secondary-800 underline hover:text-white">Kies een nieuwe</a>.';
37 37
     }
38 38
 }
Please login to merge, or discard this patch.
src/Common/helpers.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
         $empty = true;
75 75
 
76 76
         foreach ($values as $value) {
77
-            if (! $value || !trim($value)) {
77
+            if (!$value || !trim($value)) {
78 78
                 continue;
79 79
             }
80 80
             $empty = false;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     }
85 85
 }
86 86
 
87
-if (! function_exists('contract')) {
87
+if (!function_exists('contract')) {
88 88
     function contract($instance, $contract)
89 89
     {
90 90
         return $instance instanceof $contract;
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
             $text = cleanupHTML($text, $clean);
114 114
         }
115 115
         $teaser = substr($text, 0, $max);
116
-        return strlen($text) <= $max ? $teaser : $teaser . $ending;
116
+        return strlen($text) <= $max ? $teaser : $teaser.$ending;
117 117
     }
118 118
 }
119 119
 
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
          * htmlPurifier converts characters to their encode equivalents. This is something
172 172
          * that we need to reverse after the htmlPurifier cleanup.
173 173
          */
174
-        $value  = str_replace('&amp;', '&', $value);
174
+        $value = str_replace('&amp;', '&', $value);
175 175
 
176 176
         return $value;
177 177
     }
@@ -239,16 +239,16 @@  discard block
 block discarded – undo
239 239
             'scheme', 'host', 'port', 'path', 'query', 'fragment'
240 240
         ], null), $parsed_url, $overrides);
241 241
 
242
-        $scheme = $parsed_url['scheme'] ? $parsed_url['scheme'] . '://' : null;
243
-        $port = $parsed_url['port'] ? ':' . $parsed_url['port'] : null;
244
-        $fragment = $parsed_url['fragment'] ? '#' . $parsed_url['fragment'] : null;
242
+        $scheme = $parsed_url['scheme'] ? $parsed_url['scheme'].'://' : null;
243
+        $port = $parsed_url['port'] ? ':'.$parsed_url['port'] : null;
244
+        $fragment = $parsed_url['fragment'] ? '#'.$parsed_url['fragment'] : null;
245 245
 
246
-        $baseurl = $scheme . $parsed_url['host'] . $port . $parsed_url['path'];
246
+        $baseurl = $scheme.$parsed_url['host'].$port.$parsed_url['path'];
247 247
         $current_query = [];
248 248
 
249 249
         $_query = explode('&', $parsed_url['query']);
250 250
 
251
-        array_map(function ($v) use (&$current_query) {
251
+        array_map(function($v) use (&$current_query) {
252 252
             if (!$v) {
253 253
                 return;
254 254
             }
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 
267 267
         $query = urldecode(http_build_query(array_merge($current_query, $query_params)));
268 268
 
269
-        return $baseurl . '?' . $query . $fragment;
269
+        return $baseurl.'?'.$query.$fragment;
270 270
     }
271 271
 }
272 272
 
@@ -275,9 +275,9 @@  discard block
 block discarded – undo
275 275
     {
276 276
         $trace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS, 1);
277 277
         if (php_sapi_name() == 'cli') {
278
-            print_r("\e[1;30m dumped at: " . str_replace(base_path(), '', $trace[0]['file']). ", line: " . $trace[0]['line'] . "\e[40m\n");
279
-        } else {
280
-            print_r("[dumped at: " . str_replace(base_path(), '', $trace[0]['file']). ", line: " . $trace[0]['line'] . "]\n");
278
+            print_r("\e[1;30m dumped at: ".str_replace(base_path(), '', $trace[0]['file']).", line: ".$trace[0]['line']."\e[40m\n");
279
+        }else {
280
+            print_r("[dumped at: ".str_replace(base_path(), '', $trace[0]['file']).", line: ".$trace[0]['line']."]\n");
281 281
         }
282 282
         return dd($var, ...$moreVars);
283 283
     }
Please login to merge, or discard this patch.
src/Fields/Types/Field.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace Thinktomorrow\Chief\Fields\Types;
6 6
 
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
     public function optional(): bool
68 68
     {
69
-        return ! $this->required();
69
+        return !$this->required();
70 70
     }
71 71
 
72 72
     public function name(string $name = null)
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
         }
196 196
 
197 197
         if (!in_array($name, ['label', 'key', 'description', 'column', 'name', 'prepend', 'append'])) {
198
-            throw new \InvalidArgumentException('Cannot set value by ['. $name .'].');
198
+            throw new \InvalidArgumentException('Cannot set value by ['.$name.'].');
199 199
         }
200 200
 
201 201
         $this->values[$name] = $arguments[0];
Please login to merge, or discard this patch.
src/Fields/Types/MediaField.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,6 +1,6 @@  discard block
 block discarded – undo
1 1
 <?php
2 2
 
3
-declare(strict_types = 1);
3
+declare(strict_types=1);
4 4
 
5 5
 namespace Thinktomorrow\Chief\Fields\Types;
6 6
 
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
             return $this;
41 41
         }
42 42
 
43
-        return 'files['. ($this->values['name'] ?? $this->key()).']';
43
+        return 'files['.($this->values['name'] ?? $this->key()).']';
44 44
     }
45 45
 
46 46
     public function getFieldValue(Model $model, $locale = null)
Please login to merge, or discard this patch.
src/Urls/MemoizedUrlRecord.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
     public static function getByModel(Model $model)
46 46
     {
47
-        return chiefMemoize('url-records-get-by-model', function ($model) {
47
+        return chiefMemoize('url-records-get-by-model', function($model) {
48 48
             return parent::getByModel($model);
49 49
         }, [$model]);
50 50
     }
Please login to merge, or discard this patch.
src/Urls/ChiefResponse.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -44,11 +44,11 @@  discard block
 block discarded – undo
44 44
                 throw new \DomainException('Corrupt target model for this url request. Model by reference ['.$urlRecord->model_type.'@'.$urlRecord->model_id.'] has probably been archived or deleted.');
45 45
             }
46 46
 
47
-            if (method_exists($model, 'isPublished') && ! $model->isPublished()) {
47
+            if (method_exists($model, 'isPublished') && !$model->isPublished()) {
48 48
 
49 49
                 /** When admin is logged in and this request is in preview mode, we allow the view */
50
-                if (! PreviewMode::fromRequest()->check()) {
51
-                    throw new NotFoundHttpException('Model found for request ['. $slug .'] but it is not published.');
50
+                if (!PreviewMode::fromRequest()->check()) {
51
+                    throw new NotFoundHttpException('Model found for request ['.$slug.'] but it is not published.');
52 52
                 }
53 53
             }
54 54
 
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             }
60 60
         }
61 61
 
62
-        throw new NotFoundHttpException('No url or model found for request ['. $slug .'] for locale ['.$locale.'].');
62
+        throw new NotFoundHttpException('No url or model found for request ['.$slug.'] for locale ['.$locale.'].');
63 63
     }
64 64
 
65 65
     private static function createRedirect(string $url)
Please login to merge, or discard this patch.
src/Urls/UrlHelper.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
      */
40 40
     private static function onlineModels(bool $onlySingles = false, Model $ignoredModel = null): Collection
41 41
     {
42
-        $models = chiefMemoize('all-online-models', function () use ($onlySingles) {
42
+        $models = chiefMemoize('all-online-models', function() use ($onlySingles) {
43 43
             $builder = UrlRecord::whereNull('redirect_id')
44 44
                 ->select('model_type', 'model_id')
45 45
                 ->groupBy('model_type', 'model_id');
@@ -48,17 +48,17 @@  discard block
 block discarded – undo
48 48
                 $builder->where('model_type', 'singles');
49 49
             }
50 50
 
51
-            return $builder->get()->mapToGroups(function ($record) {
51
+            return $builder->get()->mapToGroups(function($record) {
52 52
                 return [$record->model_type => $record->model_id];
53
-            })->map(function ($record, $key) {
53
+            })->map(function($record, $key) {
54 54
                 return Morphables::instance($key)->find($record->toArray());
55
-            })->map->reject(function ($model) {
55
+            })->map->reject(function($model) {
56 56
                 return is_null($model) || !$model->isPublished(); // Invalid references to archived or removed models where url record still exists.
57 57
             })->flatten();
58 58
         }, [$onlySingles]);
59 59
 
60 60
         if ($ignoredModel) {
61
-            $models = $models->reject(function ($model) use ($ignoredModel) {
61
+            $models = $models->reject(function($model) use ($ignoredModel) {
62 62
                 return (get_class($model) === get_class($ignoredModel) && $model->id === $ignoredModel->id);
63 63
             });
64 64
         }
Please login to merge, or discard this patch.
src/Management/AbstractManager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
             return $this->indexPagination($builder);
83 83
         }
84 84
         
85
-        return $builder->get()->map(function ($model) {
85
+        return $builder->get()->map(function($model) {
86 86
             return (new static($this->registration))->manage($model);
87 87
         });
88 88
     }
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     {
111 111
         $paginator = $builder->paginate($this->pageCount);
112 112
 
113
-        $modifiedCollection = $builder->paginate($this->pageCount)->getCollection()->transform(function ($model) {
113
+        $modifiedCollection = $builder->paginate($this->pageCount)->getCollection()->transform(function($model) {
114 114
             return (new static($this->registration))->manage($model);
115 115
         });
116 116
 
@@ -180,7 +180,7 @@  discard block
 block discarded – undo
180 180
 
181 181
     public function guard($verb): Manager
182 182
     {
183
-        if (! $this->can($verb)) {
183
+        if (!$this->can($verb)) {
184 184
             NotAllowedManagerRoute::notAllowedVerb($verb, $this);
185 185
         }
186 186
 
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
         $fields = $this->fields();
204 204
 
205 205
         foreach ($this->assistants() as $assistant) {
206
-            if (! method_exists($assistant, 'fields')) {
206
+            if (!method_exists($assistant, 'fields')) {
207 207
                 continue;
208 208
             }
209 209
 
Please login to merge, or discard this patch.