HomepageAccessibleCheck::get_http_response_code() - Code Metrics - Inspection of "Move healthmonitor to system directory" - thinktomorrow/chief - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 0.5 ( 992a0c...ce220b )

by Ben

created 2020-04-06 15:18 UTC

HomepageAccessibleCheck::get_http_response_code() A

↳ Parent: HomepageAccessibleCheck

Complexity

Conditions	2
Paths	2

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	8
dl	0
loc	17
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

declare(strict_types=1);

namespace Thinktomorrow\Chief\System\HealthMonitor\Checks;

use Thinktomorrow\Chief\Settings\Homepage;
use Thinktomorrow\Chief\System\HealthMonitor\Notifiers\AlertBarNotifier;

class HomepageAccessibleCheck implements HealthCheck
{
    public function check(): bool
    {
        return $this->get_http_response_code(Homepage::url()) == 200;
    }

    private function get_http_response_code(string $url)
    {
        if ($url == '') {
            return false;
        }

        // Avoid ssl errors: SSL operation failed with code 1
        stream_context_set_default([
            'ssl' => [
                'verify_peer'      => false,
                'verify_peer_name' => false,
            ],
        ]);

        $headers = get_headers($url);

        return substr($headers[0], 9, 3);
    }

    public function message(): string
    {
        return 'Het lijkt erop dat de homepagina niet meer bereikbaar is. <a href="' . route('chief.back.settings.edit') . '" class="text-secondary-800 underline hover:text-white">Kies een nieuwe</a>.';
    }

    public function notifiers(): array
    {
        return [
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            AlertBarNotifier::class,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Thinktomorrow\Chief\System\HealthMonitor\Checks;
6
7			use Thinktomorrow\Chief\Settings\Homepage;
8			use Thinktomorrow\Chief\System\HealthMonitor\Notifiers\AlertBarNotifier;
9
10			class HomepageAccessibleCheck implements HealthCheck
11			{
12			public function check(): bool
13			{
14			return $this->get_http_response_code(Homepage::url()) == 200;
15			}
16
17			private function get_http_response_code(string $url)
18			{
19			if ($url == '') {
20			return false;
21			}
22
23			// Avoid ssl errors: SSL operation failed with code 1
24			stream_context_set_default([
25			'ssl' => [
26			'verify_peer' => false,
27			'verify_peer_name' => false,
28			],
29			]);
30
31			$headers = get_headers($url);
32
33			return substr($headers[0], 9, 3);
34			}
35
36			public function message(): string
37			{
38			return 'Het lijkt erop dat de homepagina niet meer bereikbaar is. <a href="' . route('chief.back.settings.edit') . '" class="text-secondary-800 underline hover:text-white">Kies een nieuwe</a>.';
39			}
40
41			public function notifiers(): array
42			{
43			return [
			0 ignored issues – show Bug Best Practice introduced 2020-04-06 15:25 UTC by Report Bug Copy Issue Report The expression `return array(Thinktomorr...lertBarNotifier::class)` returns the type `array<integer,string>` which is incompatible with the return type mandated by `Thinktomorrow\Chief\Syst...ealthCheck::notifiers()` of `Thinktomorrow\Chief\Syst...or\Notifiers\Notifier[]`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
44			AlertBarNotifier::class,
45			];
46			}
47			}
48

thinktomorrow / chief

Push — 0.5 ( 992a0c...ce220b )

HomepageAccessibleCheck::get_http_response_code() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like