Thinktomorrow\Chief\Settings\Setting

Complexity

Total Complexity

8

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Test Coverage

Coverage

94.44%

Importance

Changes	1
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	defaultField()	0	4	1
A	fieldsFromConfig()	0	7	2
A	refreshFieldsFromConfig()	0	3	1
A	getFieldAttribute()	0	18	4

<?php

namespace Thinktomorrow\Chief\Settings;

use Illuminate\Database\Eloquent\Model;
use Thinktomorrow\Chief\Fields\Types\InputField;

class Setting extends Model
{
    public $table = 'settings';
    public $timestamps = false;
    public $guarded = [];

    private static $fieldsFromConfig;

    public function getFieldAttribute()
    {
        $fields = $this->fieldsFromConfig();

        // TODO: a fieldgroup should be used here to filter / find by key
        foreach ($fields as $field) {
            if (is_callable($field)) {
                $field = call_user_func($field);
            }

            if ($field->key != $this->key) {
                continue;
            }

            return $field;
        }

        return $this->defaultField();
    }

    private static function fieldsFromConfig()
    {
        if (static::$fieldsFromConfig) {

Since $fieldsFromConfig is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $fieldsFromConfig to at least protected.

            return static::$fieldsFromConfig;
        }

        return static::$fieldsFromConfig = config('thinktomorrow.chief.settingFields', []);
    }

    private function defaultField()
    {
        return InputField::make($this->key)
                    ->label(ucfirst(str_replace(['-','_','.'], ' ', $this->key)));

The method label() does not exist on Thinktomorrow\Chief\Fields\Types\InputField. Since you implemented __call, consider adding a @method annotation.

    }

    public static function refreshFieldsFromConfig()
    {
        static::$fieldsFromConfig = null;

Since $fieldsFromConfig is declared private, accessing it with static will lead to errors in possible sub-classes; you can either use self, or increase the visibility of $fieldsFromConfig to at least protected.

    }
}