Passed
Pull Request — master (#223)
by Ben
145:27 queued 95:06
created
src/Fields/Fields.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -123,8 +123,8 @@  discard block
 block discarded – undo
123 123
 
124 124
     public function offsetSet($offset, $value)
125 125
     {
126
-        if (! $value instanceof Field) {
127
-            throw new \InvalidArgumentException('Passed value must be of type ' . Field::class);
126
+        if (!$value instanceof Field) {
127
+            throw new \InvalidArgumentException('Passed value must be of type '.Field::class);
128 128
         }
129 129
 
130 130
         $this->fields[$offset] = $value;
@@ -153,7 +153,7 @@  discard block
 block discarded – undo
153 153
 
154 154
     private function validateFields(array $fields)
155 155
     {
156
-        array_map(function (Field $field) {
156
+        array_map(function(Field $field) {
157 157
         }, $fields);
158 158
     }
159 159
 
Please login to merge, or discard this patch.
src/Modules/ModuleManager.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -63,15 +63,15 @@  discard block
 block discarded – undo
63 63
     {
64 64
         $permission = 'update-page';
65 65
 
66
-        if (in_array($verb, ['index','show'])) {
66
+        if (in_array($verb, ['index', 'show'])) {
67 67
             $permission = 'view-page';
68
-        } elseif (in_array($verb, ['create','store'])) {
68
+        } elseif (in_array($verb, ['create', 'store'])) {
69 69
             $permission = 'create-page';
70 70
         } elseif (in_array($verb, ['delete'])) {
71 71
             $permission = 'delete-page';
72 72
         }
73 73
 
74
-        if (! auth()->guard('chief')->user()->hasPermissionTo($permission)) {
74
+        if (!auth()->guard('chief')->user()->hasPermissionTo($permission)) {
75 75
             throw NotAllowedManagerRoute::notAllowedPermission($permission, $this);
76 76
         }
77 77
     }
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
     public function saveFields(Request $request)
104 104
     {
105 105
         // Store the morph_key upon creation
106
-        if (! $this->model->morph_key) {
106
+        if (!$this->model->morph_key) {
107 107
             $this->model->morph_key = $this->model->morphKey();
108 108
         }
109 109
 
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
             if (is_array_empty($translation)) {
143 143
 
144 144
                 // Nullify all values
145
-                $trans[$locale] = array_map(function ($value) {
145
+                $trans[$locale] = array_map(function($value) {
146 146
                     return null;
147 147
                 }, $translation);
148 148
                 continue;
Please login to merge, or discard this patch.
src/Management/AbstractManager.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -73,11 +73,11 @@  discard block
 block discarded – undo
73 73
             $this->filters()->apply($builder);
74 74
 
75 75
             $results = $builder->get();
76
-        } else {
76
+        }else {
77 77
             $results = $model::all();
78 78
         }
79 79
 
80
-        return $results->map(function ($model) {
80
+        return $results->map(function($model) {
81 81
             return (new static($this->registration))->manage($model);
82 82
         });
83 83
     }
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 
146 146
     public function guard($verb): Manager
147 147
     {
148
-        if (! $this->can($verb)) {
148
+        if (!$this->can($verb)) {
149 149
             NotAllowedManagerRoute::notAllowedVerb($verb, $this);
150 150
         }
151 151
 
@@ -168,7 +168,7 @@  discard block
 block discarded – undo
168 168
         $fields = $this->fields();
169 169
 
170 170
         foreach ($this->assistants() as $assistant) {
171
-            if (! method_exists($assistant, 'fields')) {
171
+            if (!method_exists($assistant, 'fields')) {
172 172
                 continue;
173 173
             }
174 174
 
Please login to merge, or discard this patch.
src/Fields/SavingFields.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
             // Media fields are treated separately
28 28
             if ($field->ofType(FieldType::MEDIA, FieldType::DOCUMENT)) {
29
-                if (! isset($this->saveMethods['_files'])) {
29
+                if (!isset($this->saveMethods['_files'])) {
30 30
                     $this->saveMethods['_files'] = ['field' => new Fields([$field]), 'method' => 'uploadMedia'];
31 31
                     continue;
32 32
                 }
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
             }
37 37
 
38 38
             // Custom set methods - default is the generic setField() method.
39
-            $methodName = 'set'. ucfirst(Str::camel($field->key())) . 'Field';
39
+            $methodName = 'set'.ucfirst(Str::camel($field->key())).'Field';
40 40
             (method_exists($this, $methodName))
41 41
                 ? $this->$methodName($field, $request)
42 42
                 : $this->setField($field, $request);
@@ -53,7 +53,7 @@  discard block
 block discarded – undo
53 53
 
54 54
     protected function detectCustomSaveMethods(Field $field): bool
55 55
     {
56
-        $saveMethodName = 'save'. ucfirst(Str::camel($field->key())) . 'Field';
56
+        $saveMethodName = 'save'.ucfirst(Str::camel($field->key())).'Field';
57 57
 
58 58
         // Custom save method on assistant
59 59
         foreach ($this->assistants() as $assistant) {
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 
96 96
             // Make our media fields able to be translatable as well...
97 97
             if ($field->ofType(FieldType::MEDIA, FieldType::DOCUMENT)) {
98
-                throw new \Exception('Cannot process the ' . $field->key . ' media field. Currently no support for translatable media files. We should fix this!');
98
+                throw new \Exception('Cannot process the '.$field->key.' media field. Currently no support for translatable media files. We should fix this!');
99 99
             }
100 100
 
101 101
             // Okay so this is a bit odd but since all translations are expected to be inside the trans
Please login to merge, or discard this patch.
src/Settings/SettingsServiceProvider.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     public function register()
15 15
     {
16
-        $this->app->singleton(Settings::class, function ($app) {
16
+        $this->app->singleton(Settings::class, function($app) {
17 17
             return new Settings();
18 18
         });
19 19
     }
Please login to merge, or discard this patch.
src/Urls/UrlSlugFields.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 
19 19
     public static function redirectsFromModel(ProvidesUrl $model)
20 20
     {
21
-        $records = MemoizedUrlRecord::getByModel($model)->reject(function ($record) {
21
+        $records = MemoizedUrlRecord::getByModel($model)->reject(function($record) {
22 22
             return !$record->isRedirect();
23 23
         })->sortByDesc('created_at');
24 24
 
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
             $fields[$key] = UrlSlugField::make($key)
30 30
                 ->setUrlRecord($record)
31 31
                 ->setBaseUrlSegment($model->baseUrlSegment($record->locale))
32
-                ->prepend($model->resolveUrl($record->locale, $model->baseUrlSegment($record->locale)) .'/');
32
+                ->prepend($model->resolveUrl($record->locale, $model->baseUrlSegment($record->locale)).'/');
33 33
         }
34 34
 
35 35
         return $fields;
@@ -61,10 +61,10 @@  discard block
 block discarded – undo
61 61
         $fields = new static([]);
62 62
 
63 63
         foreach ($locales as $locale) {
64
-            $fields['url-slugs.' . $locale] = UrlSlugField::make('url-slugs.' . $locale)
64
+            $fields['url-slugs.'.$locale] = UrlSlugField::make('url-slugs.'.$locale)
65 65
                                                 ->setBaseUrlSegment($model->baseUrlSegment($locale))
66
-                                                ->prepend($model->resolveUrl($locale, $model->baseUrlSegment($locale)) .'/')
67
-                                                ->name('url-slugs[' . $locale . ']')
66
+                                                ->prepend($model->resolveUrl($locale, $model->baseUrlSegment($locale)).'/')
67
+                                                ->name('url-slugs['.$locale.']')
68 68
                                                 ->label($locale);
69 69
         }
70 70
 
@@ -77,7 +77,7 @@  discard block
 block discarded – undo
77 77
      */
78 78
     private static function fillWithExistingValues(ProvidesUrl $model, self $fields): void
79 79
     {
80
-        $records = UrlRecord::getByModel($model)->reject(function ($record) {
80
+        $records = UrlRecord::getByModel($model)->reject(function($record) {
81 81
             return $record->isRedirect();
82 82
         })->sortBy('locale');
83 83
 
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
             $fields['url-slugs.'.$record->locale]
90 90
                 ->setUrlRecord($record)
91 91
                 ->setBaseUrlSegment($model->baseUrlSegment($record->locale))
92
-                ->prepend($model->resolveUrl($record->locale, $model->baseUrlSegment($record->locale)) .'/');
92
+                ->prepend($model->resolveUrl($record->locale, $model->baseUrlSegment($record->locale)).'/');
93 93
         }
94 94
     }
95 95
 }
Please login to merge, or discard this patch.
src/Modules/Module.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
             return static::$managedModelKey;
68 68
         }
69 69
 
70
-        throw new \Exception('Missing required static property \'managedModelKey\' on ' . static::class. '.');
70
+        throw new \Exception('Missing required static property \'managedModelKey\' on '.static::class.'.');
71 71
     }
72 72
 
73 73
     /**
Please login to merge, or discard this patch.
src/Common/Helpers/Memoize.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     {
38 38
         foreach ($parameters as $key => $value) {
39 39
             if ($value instanceof Model) {
40
-                $parameters[$key] = get_class($value) . '@' . $value->id;
40
+                $parameters[$key] = get_class($value).'@'.$value->id;
41 41
             }
42 42
         }
43 43
 
Please login to merge, or discard this patch.
src/Urls/Application/SaveUrlSlugs.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     private function saveRecord(string $locale, ?string $slug)
57 57
     {
58 58
         // Existing ones for this locale?
59
-        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function ($record) use ($locale) {
59
+        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function($record) use ($locale) {
60 60
             return (
61 61
                 $record->locale == $locale &&
62 62
                 !$record->isRedirect()
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
 
66 66
         // If slug entry is left empty, all existing records will be deleted
67 67
         if (!$slug) {
68
-            $nonRedirectsWithSameLocale->each(function ($existingRecord) {
68
+            $nonRedirectsWithSameLocale->each(function($existingRecord) {
69 69
                 $existingRecord->delete();
70 70
             });
71 71
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
         }
82 82
 
83 83
         // Only replace the existing records that differ from the current passed slugs
84
-        $nonRedirectsWithSameLocale->each(function ($existingRecord) use ($slug) {
84
+        $nonRedirectsWithSameLocale->each(function($existingRecord) use ($slug) {
85 85
             if ($existingRecord->slug != $slug) {
86 86
                 $existingRecord->replaceAndRedirect(['slug' => $slug]);
87 87
             }
@@ -126,12 +126,12 @@  discard block
 block discarded – undo
126 126
      */
127 127
     private function deleteIdenticalRedirects($existingRecords, $locale, $slug): void
128 128
     {
129
-        $existingRecords->filter(function ($record) use ($locale) {
129
+        $existingRecords->filter(function($record) use ($locale) {
130 130
             return (
131 131
                 $record->locale == $locale &&
132 132
                 $record->isRedirect()
133 133
             );
134
-        })->each(function ($existingRecord) use ($slug) {
134
+        })->each(function($existingRecord) use ($slug) {
135 135
             if ($existingRecord->slug == $slug) {
136 136
                 $existingRecord->delete();
137 137
             }
@@ -146,11 +146,11 @@  discard block
 block discarded – undo
146 146
 
147 147
         // The old homepage url should be removed since this is no longer in effect.
148 148
         // In case of any redirect to this old homepage, the last used redirect is now back in effect.
149
-        $existingRecords->reject(function ($existingRecord) {
149
+        $existingRecords->reject(function($existingRecord) {
150 150
             return (
151 151
                 $existingRecord->model_type == $this->model->getMorphClass() &&
152 152
                 $existingRecord->model_id == $this->model->id);
153
-        })->each(function ($existingRecord) {
153
+        })->each(function($existingRecord) {
154 154
 
155 155
             // TODO: if there is a redirect to this page, we'll take this one as the new url
156 156
             $existingRecord->delete();
@@ -164,7 +164,7 @@  discard block
 block discarded – undo
164 164
      */
165 165
     private function prependBaseUrlSegment(string $slug, $locale): string
166 166
     {
167
-        $slugWithBaseSegment = $this->model->baseUrlSegment($locale) . '/' . $slug;
167
+        $slugWithBaseSegment = $this->model->baseUrlSegment($locale).'/'.$slug;
168 168
         $slugWithBaseSegment = trim($slugWithBaseSegment, '/');
169 169
 
170 170
         // If slug with base segment is empty string, it means that the passed slug was probably a "/" character.
Please login to merge, or discard this patch.