Thinktomorrow\Chief\Authorization\Console\GenerateRoleCommand

Complexity

Total Complexity

8

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Test Coverage

Coverage

95.45%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	handle()	0	7	1
A	getNameArgument()	0	3	1
B	assignPermissionsToRole()	0	29	6

<?php
namespace Thinktomorrow\Chief\Authorization\Console;

use Thinktomorrow\Chief\Authorization\Role;
use Thinktomorrow\Chief\Authorization\Permission;
use Illuminate\Console\Command;

class GenerateRoleCommand extends Command
{
    protected $signature = 'chief:role 
                                {name : the role name e.g. admin, editor.}
                                {--permissions= : the permissions to give to this role. Assign multiple permissions by comma separated values. }';

    protected $description = 'Generate a new role';

    public function handle()
    {
        $roleName = $this->getNameArgument();

        $role = Role::findOrCreate($roleName, 'chief');

        $this->assignPermissionsToRole($role);
    }

    private function getNameArgument()
    {
        return strtolower(str_singular($this->argument('name')));

It seems like $this->argument('name') can also be of type array; however, parameter $value of str_singular() does only seem to accept string, maybe add an additional type check?

    }

    private function assignPermissionsToRole(Role $role)
    {
        if (!$this->option('permissions')) {
            return;
        }

        $permissionNames = explode(',', $this->option('permissions'));

        $cleanPermissionNames = [];
        foreach ($permissionNames as $k => $permissionName) {
            $permissionName = trim($permissionName);

            // Generate all permissions if only scope is passed
            if (false === strpos($permissionName, '-')) {
                $cleanPermissionNames = array_merge($cleanPermissionNames, Permission::generate($permissionName));
            } else {
                // Trim the value
                $cleanPermissionNames[] = $permissionName;
            }
        }

        foreach ($cleanPermissionNames as $cleanPermissionName) {
            if ($role->hasPermissionTo($cleanPermissionName)) {
                continue;
            }
            $role->givePermissionTo($cleanPermissionName);
        }

        $this->info('Role ' . $role->name . ' was assigned the permissions: ' . implode(',', $cleanPermissionNames));

The property name does not exist on Thinktomorrow\Chief\Authorization\Role. Since you implemented __get, consider adding a @property annotation.

    }
}