Thinktomorrow\Chief\Modules\ModuleManager

Complexity

Total Complexity

25

Size/Duplication

Total Lines	149
Duplicated Lines	0 %

Test Coverage

Coverage

89.33%

Importance

Changes	1
Bugs	1	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	saveCreateFields()	0	8	3
A	delete()	0	9	2
A	details()	0	7	2
A	updateRequest()	0	17	3
A	storeRequest()	0	12	3
A	route()	0	32	4
A	can()	0	8	2
A	fields()	0	12	1
A	authorize()	0	14	5

<?php

declare(strict_types=1);

namespace Thinktomorrow\Chief\Modules;

use Illuminate\Http\Request;
use Thinktomorrow\Chief\Concerns\Morphable\MorphableContract;
use Thinktomorrow\Chief\Fields\Fields;
use Thinktomorrow\Chief\Fields\Types\HtmlField;
use Thinktomorrow\Chief\Fields\Types\InputField;
use Thinktomorrow\Chief\Management\AbstractManager;
use Thinktomorrow\Chief\Management\Details\Details;
use Thinktomorrow\Chief\Management\Exceptions\DeleteAborted;
use Thinktomorrow\Chief\Management\Exceptions\NotAllowedManagerRoute;
use Thinktomorrow\Chief\Management\Manager;
use Thinktomorrow\Chief\Management\Managers;
use Thinktomorrow\Chief\Modules\Application\DeleteModule;

class ModuleManager extends AbstractManager implements Manager
{
    public function details(): Details
    {
        $modelDetails = parent::details();
        $modelDetails = $modelDetails->set('plural', $this->model->isPageSpecific() ? 'eigen modules' : 'vaste modules');
        $modelDetails = $modelDetails->set('title', $this->model->slug);

        return $modelDetails;
    }

    public function route($verb): ?string
    {

        /**
         * Page specific modules are expected to be found and managed in the context of a certain page.
         * Therefore the index of these modules is at the modules tab of this page model.
         */
        if ($verb == 'index' && $this->model->isPageSpecific()) {
            return app(Managers::class)->findByModel($this->model->page)->route('edit') . '#eigen-modules';
        }

        $routes = [
            'index'  => route('chief.back.modules.index', [$this->registration->key()]),

The method key() does not exist on Thinktomorrow\Chief\Management\Register.

            'create' => route('chief.back.managers.create', [$this->registration->key()]),
            'store'  => route('chief.back.managers.store', [$this->registration->key()]),
        ];

        if (array_key_exists($verb, $routes)) {
            return $routes[$verb] ?? null;
        }

        $routes = array_merge($routes, [
            'edit'   => route('chief.back.managers.edit', [$this->registration->key(), $this->existingModel()->id]),

Accessing id on the interface Thinktomorrow\Chief\Management\ManagedModel suggest that you code against a concrete implementation. How about adding an instanceof check?

            'update' => route('chief.back.managers.update', [$this->registration->key(), $this->existingModel()->id]),
            'delete' => route('chief.back.managers.delete', [$this->registration->key(), $this->existingModel()->id]),
            'upload' => route('chief.back.managers.media.upload', [
                $this->registration->key(),
                $this->existingModel()->id,
            ]),
        ]);

        return $routes[$verb] ?? null;
    }

    public function can($verb): bool
    {
        try {
            $this->authorize($verb);

            return parent::can($verb);
        } catch (NotAllowedManagerRoute $e) {
            return false;
        }
    }

    private function authorize($verb)
    {
        $permission = 'update-page';

        if (in_array($verb, ['index', 'show'])) {
            $permission = 'view-page';
        } elseif (in_array($verb, ['create', 'store'])) {
            $permission = 'create-page';
        } elseif (in_array($verb, ['delete'])) {
            $permission = 'delete-page';
        }

        if (!auth()->guard('chief')->user()->hasPermissionTo($permission)) {

The method hasPermissionTo() does not exist on Illuminate\Contracts\Auth\Authenticatable. It seems like you code against a sub-type of Illuminate\Contracts\Auth\Authenticatable such as Illuminate\Foundation\Auth\User.

            throw NotAllowedManagerRoute::notAllowedPermission($permission, $this);
        }
    }

    /**
     * The set of fields that should be manageable for a certain model.
     *
     * Additionally, you should:
     * 1. Make sure to setup the proper migrations and
     * 2. For a translatable field you should add this field to the $translatedAttributes property of the model as well.
     *
     * @return Fields
     */
    public function fields(): Fields
    {
        return new Fields([
            InputField::make('slug')
                ->label('Interne benaming')
                ->validation('required', ['slug' => 'Interne titel is verplicht']),
            InputField::make('title')

The function Thinktomorrow\Chief\Fields\Types\AbstractField::translatable() has been deprecated: use locales(array $locales) instead

                ->translatable($this->model->availableLocales())
                ->label('titel'),
            HtmlField::make('content')

The function Thinktomorrow\Chief\Fields\Types\AbstractField::translatable() has been deprecated: use locales(array $locales) instead

                ->translatable($this->model->availableLocales())
                ->label('inhoud'),
        ]);
    }

    public function saveCreateFields(Request $request): void
    {
        // Store the morph_key upon creation
        if ($this->model instanceof MorphableContract && !$this->model->morph_key) {

Accessing morph_key on the interface Thinktomorrow\Chief\Concerns\Morphable\MorphableContract suggest that you code against a concrete implementation. How about adding an instanceof check?

            $this->model->morph_key = $this->model->morphKey();
        }

        parent::saveCreateFields($request);
    }

    public function delete()
    {
        $this->guard('delete');

        if (request()->get('deleteconfirmation') !== 'DELETE') {
            throw new DeleteAborted();
        }

        app(DeleteModule::class)->handle($this->model->id);
    }

    public function storeRequest(Request $request): Request
    {
        $trans = [];
        foreach ($request->input('trans', []) as $locale => $translation) {
            if (is_array_empty($translation)) {
                continue;
            }

            $trans[$locale] = $translation;
        }

        return $request->merge(['trans' => $trans]);
    }

    public function updateRequest(Request $request): Request
    {
        $trans = [];
        foreach ($request->input('trans', []) as $locale => $translation) {
            if (is_array_empty($translation)) {

                // Nullify all values
                $trans[$locale] = array_map(function ($value) {
                    return null;
                }, $translation);
                continue;
            }

            $trans[$locale] = $translation;
        }

        return $request->merge(['trans' => $trans]);
    }
}