Thinktomorrow\Chief\Management\Assistants\AssistedManager

Complexity

Total Complexity

9

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	isAssistedBy()	0	3	1
A	getAssistantClass()	0	13	4
A	assistant()	0	10	2
A	assistants()	0	9	2

<?php


namespace Thinktomorrow\Chief\Management\Assistants;

use Thinktomorrow\Chief\Management\Exceptions\MissingAssistant;

trait AssistedManager
{
    protected $assistants = [];

    /**
     * Check if this manager is assisted by a certain assistant
     *
     * @param string $assistant
     * @return bool
     */
    public function isAssistedBy(string $assistant): bool
    {
        return !! $this->getAssistantClass($assistant);
    }

    public function assistants(): array
    {
        $assistants = [];

        foreach ($this->assistants as $assistant) {
            $assistants[] = $this->assistant($assistant);
        }

        return $assistants;
    }

    /**
     * Instantiate the assistant
     *
     * @param string $assistant
     * @return Assistant
     * @throws \Exception
     */
    public function assistant(string $assistant): Assistant
    {
        if (! $this->isAssistedBy($assistant)) {
            throw new MissingAssistant('No assistant [' . $assistant . '] present on manager ' . get_class($this));
        }

        $instance = app($this->getAssistantClass($assistant));
        $instance->manager($this);

The method manager() does not exist on Illuminate\Contracts\Foundation\Application.

        return $instance;

The expression return $instance could return the type Illuminate\Contracts\Foundation\Application which is incompatible with the type-hinted return Thinktomorrow\Chief\Management\Assistants\Assistant. Consider adding an additional type-check to rule them out.

    }

    private function getAssistantClass($assistant): ?string
    {
        if (in_array($assistant, $this->assistants)) {
            return $assistant;
        }

        foreach ($this->assistants as $class) {
            if ($assistant == $class::key()) {
                return $class;
            }
        }

        return null;
    }
}