Thinktomorrow\Chief\Mediagallery\Application\RemovalAction::handle()

Complexity

Conditions	4
Paths	4

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes

0

<?php
    public function handle(Request $request)
    {
        // Strict protection enabled: we won't remove assets who are still being used...
        $assetIds = collect($request->input('asset_ids', []))->reject(function($assetId){
            return DB::table('asset_pivots')
                ->where('asset_id', $assetId)
                ->where('unused', 0)
                ->exists();
        })->toArray();

        if($assetIds)

The expression $assetIds of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        {
                foreach($assetIds as $k => $assetId) {
                    try{
                        $this->deleteAsset->remove($assetId);
                    } catch(FileNotAccessibleException $e) {
                        unset($assetIds[$k]); // So our count of removed assets is correct in the log.
                    }
                }

                Audit::activity()->log('removed ' . count($assetIds) . ' assets from the mediagallery.');

                return true;
        }

        return false;
    }