Test Failed
Push — fix/media-validation ( 3351fe )
by Ben
09:34
created
src/Urls/MemoizedUrlRecord.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
 
45 45
     public static function getByModel(Model $model)
46 46
     {
47
-        return chiefMemoize('url-records-get-by-model', function ($model) {
47
+        return chiefMemoize('url-records-get-by-model', function($model) {
48 48
             return parent::getByModel($model);
49 49
         }, [$model]);
50 50
     }
Please login to merge, or discard this patch.
src/Urls/ChiefResponse.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -44,11 +44,11 @@  discard block
 block discarded – undo
44 44
                 throw new \DomainException('Corrupt target model for this url request. Model by reference ['.$urlRecord->model_type.'@'.$urlRecord->model_id.'] has probably been archived or deleted.');
45 45
             }
46 46
 
47
-            if (method_exists($model, 'isPublished') && ! $model->isPublished()) {
47
+            if (method_exists($model, 'isPublished') && !$model->isPublished()) {
48 48
 
49 49
                 /** When admin is logged in and this request is in preview mode, we allow the view */
50
-                if (! PreviewMode::fromRequest()->check()) {
51
-                    throw new NotFoundHttpException('Model found for request ['. $slug .'] but it is not published.');
50
+                if (!PreviewMode::fromRequest()->check()) {
51
+                    throw new NotFoundHttpException('Model found for request ['.$slug.'] but it is not published.');
52 52
                 }
53 53
             }
54 54
 
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
             }
60 60
         }
61 61
 
62
-        throw new NotFoundHttpException('No url or model found for request ['. $slug .'] for locale ['.$locale.'].');
62
+        throw new NotFoundHttpException('No url or model found for request ['.$slug.'] for locale ['.$locale.'].');
63 63
     }
64 64
 
65 65
     private static function createRedirect(string $url)
Please login to merge, or discard this patch.
src/Management/ManagesPagebuilder.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@  discard block
 block discarded – undo
49 49
 
50 50
         $availableChildren = AvailableChildren::forParent($model);
51 51
 
52
-        $modules = $availableChildren->onlyModules()->reject(function ($module) use ($model) {
52
+        $modules = $availableChildren->onlyModules()->reject(function($module) use ($model) {
53 53
             return $module->page_id != null && $module->page_id != $model->id;
54 54
         });
55 55
 
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
         $available_sets = FlatReferencePresenter::toGroupedSelectValues($availableChildren->onlySets())->toArray();
59 59
 
60 60
         // Current sections
61
-        $sections = $model->children()->map(function ($section, $index) {
61
+        $sections = $model->children()->map(function($section, $index) {
62 62
             if ($section instanceof TranslatableContract) {
63 63
                 $section->injectTranslationForForm();
64 64
             }
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
      */
93 93
     private function findEditUrl($model): ?string
94 94
     {
95
-        if (! $model instanceof ManagedModel) {
95
+        if (!$model instanceof ManagedModel) {
96 96
             return null;
97 97
         }
98 98
 
Please login to merge, or discard this patch.
src/Modules/Application/DeleteModule.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 
22 22
             // Mark the slug as deleted to avoid any conflict with newly created modules with the same slug.
23 23
             $module->update([
24
-                'slug' => $module->slug . $this->appendDeleteMarker(),
24
+                'slug' => $module->slug.$this->appendDeleteMarker(),
25 25
             ]);
26 26
 
27 27
             $module->delete();
@@ -35,6 +35,6 @@  discard block
 block discarded – undo
35 35
 
36 36
     private function appendDeleteMarker(): string
37 37
     {
38
-        return '_DELETED_' . time();
38
+        return '_DELETED_'.time();
39 39
     }
40 40
 }
Please login to merge, or discard this patch.
src/Modules/Module.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
67 67
             return static::$managedModelKey;
68 68
         }
69 69
 
70
-        throw new \Exception('Missing required static property \'managedModelKey\' on ' . static::class. '.');
70
+        throw new \Exception('Missing required static property \'managedModelKey\' on '.static::class.'.');
71 71
     }
72 72
 
73 73
     /**
@@ -76,9 +76,9 @@  discard block
 block discarded – undo
76 76
      */
77 77
     public static function availableForCreation(): Collection
78 78
     {
79
-        $managers = app(Managers::class)->findByTag('module')->filter(function ($manager) {
79
+        $managers = app(Managers::class)->findByTag('module')->filter(function($manager) {
80 80
             return $manager->can('create');
81
-        })->map(function ($manager) {
81
+        })->map(function($manager) {
82 82
             return $manager->details();
83 83
         });
84 84
 
Please login to merge, or discard this patch.
src/Management/Nomadic.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -8,7 +8,7 @@
 block discarded – undo
8 8
 {
9 9
     public function nomadicCan($verb)
10 10
     {
11
-        if (in_array($verb, ['create', 'store', 'delete']) && ! auth()->guard('chief')->user()->hasRole('developer')) {
11
+        if (in_array($verb, ['create', 'store', 'delete']) && !auth()->guard('chief')->user()->hasRole('developer')) {
12 12
             throw NotAllowedManagerRoute::notAllowedVerb($verb, $this);
13 13
         }
14 14
 
Please login to merge, or discard this patch.
src/Management/Managers.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $registrations = collect($this->register->filterByTag($tag)->all());
52 52
 
53
-        return $registrations->map(function ($registration) {
53
+        return $registrations->map(function($registration) {
54 54
             return $this->instance($registration);
55 55
         });
56 56
     }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     {
66 66
         $registrations = collect($this->register->filterByTag($tag)->all());
67 67
 
68
-        return $registrations->map(function ($registration) {
68
+        return $registrations->map(function($registration) {
69 69
             return $this->instance($registration)->details();
70 70
         });
71 71
     }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         //return array with group name and values
77 77
         $grouped = [];
78 78
 
79
-        $managers = $managers->map(function (Manager $item) {
79
+        $managers = $managers->map(function(Manager $item) {
80 80
             return [
81 81
                 'id'    => $item->details()->id,
82 82
                 'group' => $item->details()->plural,
@@ -90,14 +90,14 @@  discard block
 block discarded – undo
90 90
     {
91 91
         $registrations = collect($this->register->all());
92 92
 
93
-        return $registrations->map(function ($registration) {
93
+        return $registrations->map(function($registration) {
94 94
             return $this->instance($registration);
95 95
         });
96 96
     }
97 97
 
98 98
     public function anyRegisteredByTag($tag)
99 99
     {
100
-        return ! empty($this->register->filterByTag($tag)->all());
100
+        return !empty($this->register->filterByTag($tag)->all());
101 101
     }
102 102
 
103 103
     /**
Please login to merge, or discard this patch.
src/Urls/Application/SaveUrlSlugs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     private function saveRecord(string $locale, ?string $slug)
58 58
     {
59 59
         // Existing ones for this locale?
60
-        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function ($record) use ($locale) {
60
+        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function($record) use ($locale) {
61 61
             return (
62 62
                 $record->locale == $locale &&
63 63
                 !$record->isRedirect()
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         // If slug entry is left empty, all existing records will be deleted
68 68
         if (!$slug) {
69
-            $nonRedirectsWithSameLocale->each(function ($existingRecord) {
69
+            $nonRedirectsWithSameLocale->each(function($existingRecord) {
70 70
                 $existingRecord->delete();
71 71
             });
72 72
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         }
83 83
 
84 84
         // Only replace the existing records that differ from the current passed slugs
85
-        $nonRedirectsWithSameLocale->each(function ($existingRecord) use ($slug) {
85
+        $nonRedirectsWithSameLocale->each(function($existingRecord) use ($slug) {
86 86
             if ($existingRecord->slug != $slug) {
87 87
                 $existingRecord->replaceAndRedirect(['slug' => $slug]);
88 88
             }
@@ -127,12 +127,12 @@  discard block
 block discarded – undo
127 127
      */
128 128
     private function deleteIdenticalRedirects($existingRecords, $locale, $slug): void
129 129
     {
130
-        $existingRecords->filter(function ($record) use ($locale) {
130
+        $existingRecords->filter(function($record) use ($locale) {
131 131
             return (
132 132
                 $record->locale == $locale &&
133 133
                 $record->isRedirect()
134 134
             );
135
-        })->each(function ($existingRecord) use ($slug) {
135
+        })->each(function($existingRecord) use ($slug) {
136 136
             if ($existingRecord->slug == $slug) {
137 137
                 $existingRecord->delete();
138 138
             }
@@ -147,11 +147,11 @@  discard block
 block discarded – undo
147 147
 
148 148
         // The old homepage url should be removed since this is no longer in effect.
149 149
         // In case of any redirect to this old homepage, the last used redirect is now back in effect.
150
-        $existingRecords->reject(function ($existingRecord) {
150
+        $existingRecords->reject(function($existingRecord) {
151 151
             return (
152 152
                 $existingRecord->model_type == $this->model->getMorphClass() &&
153 153
                 $existingRecord->model_id == $this->model->id);
154
-        })->each(function ($existingRecord) {
154
+        })->each(function($existingRecord) {
155 155
 
156 156
             // TODO: if there is a redirect to this page, we'll take this one as the new url
157 157
             $existingRecord->delete();
Please login to merge, or discard this patch.
src/Urls/ProvidesUrl/BaseUrlSegment.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
      */
15 15
     public static function prepend(ProvidesUrl $model, string $slug, $locale): string
16 16
     {
17
-        $slugWithBaseSegment = $model->baseUrlSegment($locale) . '/' . $slug;
17
+        $slugWithBaseSegment = $model->baseUrlSegment($locale).'/'.$slug;
18 18
         $slugWithBaseSegment = trim($slugWithBaseSegment, '/');
19 19
 
20 20
         // If slug with base segment is empty string, it means that the passed slug was probably a "/" character.
Please login to merge, or discard this patch.