Thinktomorrow\Chief\Fields\ValidationRules\ValidatesExistingAssetAttributes

Complexity

Total Complexity

15

Size/Duplication

Total Lines	73
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	existingAsset()	0	3	1
A	validateAssetDimensions()	0	12	2
A	lowlevelDimensionsCheck()	0	10	3
A	validateAssetMimetypes()	0	4	2
A	isValidJson()	0	9	2
A	validateAssetMax()	0	6	1
A	refersToExistingAsset()	0	6	3
A	validateAssetMin()	0	6	1

<?php
declare(strict_types=1);

namespace Thinktomorrow\Chief\Fields\ValidationRules;

use Thinktomorrow\AssetLibrary\Asset;

trait ValidatesExistingAssetAttributes
{
    protected function refersToExistingAsset($value): bool
    {
        // Faster check to see if there is an asset id passed or not.
        if(is_string($value) && $this->isValidJson($value)) return false;

        return !is_null($this->existingAsset($value));
    }

    protected function existingAsset($value): ?Asset
    {
        return Asset::where('id', $value)->first();
    }

    private function isValidJson($string): bool
    {
        try {
            json_decode($string);
        } catch (\Exception $e) {
            return false;
        }

        return (json_last_error() == JSON_ERROR_NONE);
    }

    protected function validateAssetDimensions(Asset $asset, $parameters)
    {
        $filepath = $asset->media->first()->getPath();

The property media does not seem to exist on Thinktomorrow\AssetLibrary\Asset. Are you sure there is no database migration missing?

        if (! $sizeDetails = @getimagesize($filepath)) {
            return false;
        }

        $this->requireParameterCount(1, $parameters, 'dimensions');

It seems like requireParameterCount() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        [$width, $height] = $sizeDetails;

        return $this->lowlevelDimensionsCheck($width, $height, $parameters);
    }

    /** Taken from the Laravel ValidatedAttributes::validateDimensions */
    private function lowlevelDimensionsCheck($width, $height, $parameters): bool
    {
        $parameters = $this->parseNamedParameters($parameters);

It seems like parseNamedParameters() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($this->failsBasicDimensionChecks($parameters, $width, $height) ||

It seems like failsBasicDimensionChecks() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->failsRatioCheck($parameters, $width, $height)) {

It seems like failsRatioCheck() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return false;
        }

        return true;
    }

    protected function validateAssetMimetypes(Asset $asset, $parameters)
    {
        return (in_array($asset->getMimeType(), $parameters) ||
            in_array(explode('/', $asset->getMimeType())[0].'/*', $parameters));
    }

    protected function validateAssetMax(Asset $asset, $parameters)
    {
        // Asset size in bytes
        $assetSize = $asset->media->first()->size;

The property media does not seem to exist on Thinktomorrow\AssetLibrary\Asset. Are you sure there is no database migration missing?

        return ($assetSize / 1024) <= $parameters[0];
    }

    protected function validateAssetMin(Asset $asset, $parameters)
    {
        // Asset size in bytes
        $assetSize = $asset->media->first()->size;

The property media does not seem to exist on Thinktomorrow\AssetLibrary\Asset. Are you sure there is no database migration missing?

        return ($assetSize / 1024) >= $parameters[0];
    }
}