Passed
Push — analysis-d0javj ( beb222 )
by Philippe
76:14 queued 64:26
created
src/Management/Managers.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     {
51 51
         $registrations = collect($this->register->filterByTag($tag)->all());
52 52
 
53
-        return $registrations->map(function ($registration) {
53
+        return $registrations->map(function($registration) {
54 54
             return $this->instance($registration);
55 55
         });
56 56
     }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
     {
66 66
         $registrations = collect($this->register->filterByTag($tag)->all());
67 67
 
68
-        return $registrations->map(function ($registration) {
68
+        return $registrations->map(function($registration) {
69 69
             return $this->instance($registration)->details();
70 70
         });
71 71
     }
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
         //return array with group name and values
77 77
         $grouped = [];
78 78
 
79
-        $managers = $managers->map(function (Manager $item) {
79
+        $managers = $managers->map(function(Manager $item) {
80 80
             return [
81 81
                 'id'    => $item->details()->id,
82 82
                 'group' => $item->details()->plural,
@@ -90,14 +90,14 @@  discard block
 block discarded – undo
90 90
     {
91 91
         $registrations = collect($this->register->all());
92 92
 
93
-        return $registrations->map(function ($registration) {
93
+        return $registrations->map(function($registration) {
94 94
             return $this->instance($registration);
95 95
         });
96 96
     }
97 97
 
98 98
     public function anyRegisteredByTag($tag)
99 99
     {
100
-        return ! empty($this->register->filterByTag($tag)->all());
100
+        return !empty($this->register->filterByTag($tag)->all());
101 101
     }
102 102
 
103 103
     /**
Please login to merge, or discard this patch.
src/Urls/Application/SaveUrlSlugs.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
     private function saveRecord(string $locale, ?string $slug)
58 58
     {
59 59
         // Existing ones for this locale?
60
-        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function ($record) use ($locale) {
60
+        $nonRedirectsWithSameLocale = $this->existingRecords->filter(function($record) use ($locale) {
61 61
             return (
62 62
                 $record->locale == $locale &&
63 63
                 !$record->isRedirect()
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         // If slug entry is left empty, all existing records will be deleted
68 68
         if (!$slug) {
69
-            $nonRedirectsWithSameLocale->each(function ($existingRecord) {
69
+            $nonRedirectsWithSameLocale->each(function($existingRecord) {
70 70
                 $existingRecord->delete();
71 71
             });
72 72
 
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
         }
83 83
 
84 84
         // Only replace the existing records that differ from the current passed slugs
85
-        $nonRedirectsWithSameLocale->each(function ($existingRecord) use ($slug) {
85
+        $nonRedirectsWithSameLocale->each(function($existingRecord) use ($slug) {
86 86
             if ($existingRecord->slug != $slug) {
87 87
                 $existingRecord->replaceAndRedirect(['slug' => $slug]);
88 88
             }
@@ -127,12 +127,12 @@  discard block
 block discarded – undo
127 127
      */
128 128
     private function deleteIdenticalRedirects($existingRecords, $locale, $slug): void
129 129
     {
130
-        $existingRecords->filter(function ($record) use ($locale) {
130
+        $existingRecords->filter(function($record) use ($locale) {
131 131
             return (
132 132
                 $record->locale == $locale &&
133 133
                 $record->isRedirect()
134 134
             );
135
-        })->each(function ($existingRecord) use ($slug) {
135
+        })->each(function($existingRecord) use ($slug) {
136 136
             if ($existingRecord->slug == $slug) {
137 137
                 $existingRecord->delete();
138 138
             }
@@ -147,11 +147,11 @@  discard block
 block discarded – undo
147 147
 
148 148
         // The old homepage url should be removed since this is no longer in effect.
149 149
         // In case of any redirect to this old homepage, the last used redirect is now back in effect.
150
-        $existingRecords->reject(function ($existingRecord) {
150
+        $existingRecords->reject(function($existingRecord) {
151 151
             return (
152 152
                 $existingRecord->model_type == $this->model->getMorphClass() &&
153 153
                 $existingRecord->model_id == $this->model->id);
154
-        })->each(function ($existingRecord) {
154
+        })->each(function($existingRecord) {
155 155
 
156 156
             // TODO: if there is a redirect to this page, we'll take this one as the new url
157 157
             $existingRecord->delete();
Please login to merge, or discard this patch.
src/Urls/ProvidesUrl/BaseUrlSegment.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -14,7 +14,7 @@
 block discarded – undo
14 14
      */
15 15
     public static function prepend(ProvidesUrl $model, string $slug, $locale): string
16 16
     {
17
-        $slugWithBaseSegment = $model->baseUrlSegment($locale) . '/' . $slug;
17
+        $slugWithBaseSegment = $model->baseUrlSegment($locale).'/'.$slug;
18 18
         $slugWithBaseSegment = trim($slugWithBaseSegment, '/');
19 19
 
20 20
         // If slug with base segment is empty string, it means that the passed slug was probably a "/" character.
Please login to merge, or discard this patch.
src/Common/helpers.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@  discard block
 block discarded – undo
74 74
         $empty = true;
75 75
 
76 76
         foreach ($values as $value) {
77
-            if (! $value || !trim($value)) {
77
+            if (!$value || !trim($value)) {
78 78
                 continue;
79 79
             }
80 80
             $empty = false;
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     }
85 85
 }
86 86
 
87
-if (! function_exists('contract')) {
87
+if (!function_exists('contract')) {
88 88
     function contract($instance, $contract)
89 89
     {
90 90
         return $instance instanceof $contract;
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
             $text = cleanupHTML($text, $clean);
114 114
         }
115 115
         $teaser = substr($text, 0, $max);
116
-        return strlen($text) <= $max ? $teaser : $teaser . $ending;
116
+        return strlen($text) <= $max ? $teaser : $teaser.$ending;
117 117
     }
118 118
 }
119 119
 
@@ -171,7 +171,7 @@  discard block
 block discarded – undo
171 171
          * htmlPurifier converts characters to their encode equivalents. This is something
172 172
          * that we need to reverse after the htmlPurifier cleanup.
173 173
          */
174
-        $value  = str_replace('&amp;', '&', $value);
174
+        $value = str_replace('&amp;', '&', $value);
175 175
 
176 176
         return $value;
177 177
     }
@@ -239,16 +239,16 @@  discard block
 block discarded – undo
239 239
             'scheme', 'host', 'port', 'path', 'query', 'fragment'
240 240
         ], null), $parsed_url, $overrides);
241 241
 
242
-        $scheme = $parsed_url['scheme'] ? $parsed_url['scheme'] . '://' : null;
243
-        $port = $parsed_url['port'] ? ':' . $parsed_url['port'] : null;
244
-        $fragment = $parsed_url['fragment'] ? '#' . $parsed_url['fragment'] : null;
242
+        $scheme = $parsed_url['scheme'] ? $parsed_url['scheme'].'://' : null;
243
+        $port = $parsed_url['port'] ? ':'.$parsed_url['port'] : null;
244
+        $fragment = $parsed_url['fragment'] ? '#'.$parsed_url['fragment'] : null;
245 245
 
246
-        $baseurl = $scheme . $parsed_url['host'] . $port . $parsed_url['path'];
246
+        $baseurl = $scheme.$parsed_url['host'].$port.$parsed_url['path'];
247 247
         $current_query = [];
248 248
 
249 249
         $_query = explode('&', $parsed_url['query']);
250 250
 
251
-        array_map(function ($v) use (&$current_query) {
251
+        array_map(function($v) use (&$current_query) {
252 252
             if (!$v) {
253 253
                 return;
254 254
             }
@@ -266,7 +266,7 @@  discard block
 block discarded – undo
266 266
 
267 267
         $query = urldecode(http_build_query(array_merge($current_query, $query_params)));
268 268
 
269
-        return $baseurl . '?' . $query . $fragment;
269
+        return $baseurl.'?'.$query.$fragment;
270 270
     }
271 271
 }
272 272
 
Please login to merge, or discard this patch.
src/Pages/Page.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
             return static::$managedModelKey;
85 85
         }
86 86
 
87
-        throw new \Exception('Missing required static property \'managedModelKey\' on ' . static::class. '.');
87
+        throw new \Exception('Missing required static property \'managedModelKey\' on '.static::class.'.');
88 88
     }
89 89
 
90 90
     /**
@@ -124,9 +124,9 @@  discard block
 block discarded – undo
124 124
     public function flatReferenceLabel(): string
125 125
     {
126 126
         if ($this->exists) {
127
-            $status = ! $this->isPublished() ? ' [' . $this->statusAsPlainLabel().']' : null;
127
+            $status = !$this->isPublished() ? ' ['.$this->statusAsPlainLabel().']' : null;
128 128
 
129
-            return $this->title ? $this->title . $status : '';
129
+            return $this->title ? $this->title.$status : '';
130 130
         }
131 131
 
132 132
         return '';
@@ -136,8 +136,8 @@  discard block
 block discarded – undo
136 136
     {
137 137
         $classKey = get_class($this);
138 138
         if (property_exists($this, 'labelSingular')) {
139
-            $labelSingular =  $this->labelSingular;
140
-        } else {
139
+            $labelSingular = $this->labelSingular;
140
+        }else {
141 141
             $labelSingular = Str::singular($classKey);
142 142
         }
143 143
 
Please login to merge, or discard this patch.
src/Sets/Set.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
 
52 52
         // If no view has been created for this page collection, we try once again to fetch the content value if any. This will silently fail
53 53
         // if no content value is present. We don't consider the 'content' attribute to be a default as we do for module.
54
-        return $this->map(function ($item) {
54
+        return $this->map(function($item) {
55 55
             return ($this->viewParent && $item instanceof ViewableContract)
56 56
                 ? $item->setViewParent($this->viewParent)->renderView()
57 57
                 : ($item->content ?? '');
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
     {
85 85
         $currentPage = $currentPage ?? request()->get('page', 1);
86 86
         $path = request()->path();
87
-        $items = array_slice($this->all(), ($currentPage - 1) * $perPage);
87
+        $items = array_slice($this->all(), ($currentPage-1) * $perPage);
88 88
 
89 89
         return (new \Illuminate\Pagination\Paginator($items, $perPage ?? $this->paginateSetting('perPage', '12'), $currentPage))->setPath($path);
90 90
     }
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
101 101
     {
102 102
         $currentPage = $currentPage ?? request()->get('page', 1);
103 103
         $path = '/'.request()->path();
104
-        $items = array_slice($this->all(), ($currentPage - 1) * $perPage, $perPage);
104
+        $items = array_slice($this->all(), ($currentPage-1) * $perPage, $perPage);
105 105
 
106 106
         return (new \Illuminate\Pagination\LengthAwarePaginator($items, $this->paginateSetting('total', $this->count()), $perPage ?? $this->paginateSetting('perPage', '12'), $currentPage))->setPath($path);
107 107
     }
Please login to merge, or discard this patch.
src/Sets/SetReference.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
     {
40 40
         // Constraints
41 41
         if (!isset($values['action'])) {
42
-            throw new \InvalidArgumentException('Set reference array is missing required values for the "action" keys. Given: ' . print_r($values, true));
42
+            throw new \InvalidArgumentException('Set reference array is missing required values for the "action" keys. Given: '.print_r($values, true));
43 43
         }
44 44
 
45 45
         return new static(
@@ -54,14 +54,14 @@  discard block
 block discarded – undo
54 54
     {
55 55
         $sets = config('thinktomorrow.chief.sets', []);
56 56
 
57
-        return collect($sets)->map(function ($set, $key) {
57
+        return collect($sets)->map(function($set, $key) {
58 58
             return SetReference::fromArray($key, $set);
59 59
         });
60 60
     }
61 61
 
62 62
     public static function find($key): ?SetReference
63 63
     {
64
-        return static::all()->filter(function ($ref) use ($key) {
64
+        return static::all()->filter(function($ref) use ($key) {
65 65
             return $ref->key() == $key;
66 66
         })->first();
67 67
     }
@@ -78,13 +78,13 @@  discard block
 block discarded – undo
78 78
 
79 79
         $this->validateAction($class, $method);
80 80
 
81
-        $result = call_user_func_array([app($class),$method], $this->parameters($class, $method, $parent));
81
+        $result = call_user_func_array([app($class), $method], $this->parameters($class, $method, $parent));
82 82
 
83
-        if (! $result instanceof Set && $result instanceof Collection) {
83
+        if (!$result instanceof Set && $result instanceof Collection) {
84 84
             return new Set($result->all(), $this->key);
85 85
         }
86 86
 
87
-        if (! $result instanceof Set && $result instanceof Paginator) {
87
+        if (!$result instanceof Set && $result instanceof Paginator) {
88 88
             return new Set($result->all(), $this->key, [
89 89
                 'paginate' => [
90 90
                     'total' => $result->total(),
@@ -152,7 +152,7 @@  discard block
 block discarded – undo
152 152
 
153 153
     private static function validateAction($class, $method)
154 154
     {
155
-        if (! class_exists($class)) {
155
+        if (!class_exists($class)) {
156 156
             throw new \InvalidArgumentException('The class ['.$class.'] isn\'t a valid class reference or does not exist in the chief-settings.sets config entry.');
157 157
         }
158 158
 
Please login to merge, or discard this patch.
src/Urls/UrlHelper.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@  discard block
 block discarded – undo
39 39
      */
40 40
     public static function onlineModels(bool $onlySingles = false, Model $ignoredModel = null): Collection
41 41
     {
42
-        $models = chiefMemoize('all-online-models', function () use ($onlySingles) {
42
+        $models = chiefMemoize('all-online-models', function() use ($onlySingles) {
43 43
             $builder = UrlRecord::whereNull('redirect_id')
44 44
                 ->select('model_type', 'model_id')
45 45
                 ->groupBy('model_type', 'model_id');
@@ -48,17 +48,17 @@  discard block
 block discarded – undo
48 48
                 $builder->where('model_type', 'singles');
49 49
             }
50 50
 
51
-            return $builder->get()->mapToGroups(function ($record) {
51
+            return $builder->get()->mapToGroups(function($record) {
52 52
                 return [$record->model_type => $record->model_id];
53
-            })->map(function ($record, $key) {
53
+            })->map(function($record, $key) {
54 54
                 return Morphables::instance($key)->find($record->toArray());
55
-            })->map->reject(function ($model) {
55
+            })->map->reject(function($model) {
56 56
                 return is_null($model) || !$model->isPublished(); // Invalid references to archived or removed models where url record still exists.
57 57
             })->flatten();
58 58
         }, [$onlySingles]);
59 59
 
60 60
         if ($ignoredModel) {
61
-            $models = $models->reject(function ($model) use ($ignoredModel) {
61
+            $models = $models->reject(function($model) use ($ignoredModel) {
62 62
                 return (get_class($model) === get_class($ignoredModel) && $model->id === $ignoredModel->id);
63 63
             });
64 64
         }
Please login to merge, or discard this patch.
src/Management/Assistants/ManagesAssistants.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
     public function assistant(string $assistantKey): Assistant
52 52
     {
53 53
         if (!$this->isAssistedBy($assistantKey)) {
54
-            throw new MissingAssistant('No assistant [' . $assistantKey . '] registered on manager ' . static::class);
54
+            throw new MissingAssistant('No assistant ['.$assistantKey.'] registered on manager '.static::class);
55 55
         }
56 56
 
57 57
         $instance = app($this->getAssistantClass($assistantKey));
Please login to merge, or discard this patch.