Thinktomorrow\Chief\Concerns\Sluggable\UniqueSlug

Complexity

Total Complexity

12

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	slugResolver()	0	5	1
A	make()	0	3	1
A	get()	0	14	2
A	__construct()	0	7	1
A	isSlugUnique()	0	9	6
A	sluggify()	0	3	1

<?php

namespace Thinktomorrow\Chief\Concerns\Sluggable;

class UniqueSlug
{
    /** @var SluggableContract */
    private $model;

    /** @var array */
    private $blacklist;

    /** @var \Closure */
    private $slugResolver;

    public function __construct(SluggableContract $model, array $blacklist = [])
    {
        $this->model = $model;
        $this->blacklist = $blacklist;

        $this->slugResolver = function ($slug) {
            return str_slug($slug);

The function str_slug() has been deprecated: Str::slug() should be used directly instead. Will be removed in Laravel 5.9.

        };
    }

    public static function make($model, array $blacklist = [])
    {
        return new static($model, $blacklist);
    }

    public function slugResolver(\Closure $resolver)
    {
        $this->slugResolver = $resolver;

        return $this;
    }

    public function get($title, SluggableContract $entity = null)
    {
        $slug = $originalslug = $this->sluggify($title);
        $i = 1;

        while (!$this->isSlugUnique($slug, $entity)) {
            $slug = $originalslug.'-'.$i;
            $i++;
        }

        // Add to blacklist
        $this->blacklist[] = $slug;

        return $slug;
    }

    private function sluggify($value)
    {
        return call_user_func($this->slugResolver, $value);
    }

    /**
     *
     * @param $slug
     * @param SluggableContract $entity
     * @return bool
     */
    private function isSlugUnique($slug, SluggableContract $entity = null)
    {
        $model = $this->model->findBySlug($slug);

        if (!in_array($slug, $this->blacklist) && (!$model || ($entity && $entity->id && $model->id == $entity->id))) {

Accessing id on the interface Thinktomorrow\Chief\Concerns\Sluggable\SluggableContract suggest that you code against a concrete implementation. How about adding an instanceof check?

            return true;
        }

        return false;
    }
}