Thinktomorrow\Chief\Fields\RenderingFields

Complexity

Total Complexity

2

Size/Duplication

Total Lines	15
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	renderField()	0	8	1
A	fieldValue()	0	3	1

<?php

namespace Thinktomorrow\Chief\Fields;

use Thinktomorrow\Chief\Fields\Types\Field;

trait RenderingFields
{
    public function renderField(Field $field)
    {
        return view($field->view(), array_merge([

It seems like $field->view() can also be of type Thinktomorrow\Chief\Fields\Types\Field; however, parameter $view of view() does only seem to accept null|string, maybe add an additional type check?

            'field'           => $field,
            'key'             => $field->key(), // As parameter so that it can be altered for translatable values

The method key() does not exist on Thinktomorrow\Chief\Fields\Types\Field. Since you implemented __call, consider adding a @method annotation.

            'manager'         => $this,
            'formElementView' => $field->formElementView(),
        ]), $field->viewData())->render();

It seems like $field->viewData() can also be of type Thinktomorrow\Chief\Fields\Types\Field; however, parameter $mergeData of view() does only seem to accept array, maybe add an additional type check?

    }

    public function fieldValue(Field $field, $locale = null)
    {
        return $field->getFieldValue($this->model, $locale);
    }
}